From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#69809: 30.0.50; flymake: error in process sentinel Date: Wed, 17 Jul 2024 18:38:27 +0100 Message-ID: References: <867chv3mtf.fsf@gnu.org> <87le696o86.fsf@catern.com> <86v81bktv5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36398"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, Spencer Baugh , Eli Zaretskii , 69809@debbugs.gnu.org, sbaugh@catern.com To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 17 19:40:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sU8dS-0009By-CY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Jul 2024 19:40:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sU8dF-000231-5J; Wed, 17 Jul 2024 13:40:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sU8dC-00022n-NY for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2024 13:39:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sU8dC-0000so-E9 for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2024 13:39:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sU8dF-0007jY-Lm for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2024 13:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Jul 2024 17:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69809 X-GNU-PR-Package: emacs Original-Received: via spool by 69809-submit@debbugs.gnu.org id=B69809.172123799029703 (code B ref 69809); Wed, 17 Jul 2024 17:40:01 +0000 Original-Received: (at 69809) by debbugs.gnu.org; 17 Jul 2024 17:39:50 +0000 Original-Received: from localhost ([127.0.0.1]:36170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sU8d3-0007j0-Up for submit@debbugs.gnu.org; Wed, 17 Jul 2024 13:39:50 -0400 Original-Received: from mail-oa1-f45.google.com ([209.85.160.45]:53713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sU8d1-0007ik-IE for 69809@debbugs.gnu.org; Wed, 17 Jul 2024 13:39:48 -0400 Original-Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-25e3bc751daso10828fac.3 for <69809@debbugs.gnu.org>; Wed, 17 Jul 2024 10:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721237918; x=1721842718; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k6Iq8ntYV8VLv/VsXehkUdCfLNawZvjTAJLVmjk6gDc=; b=G1Ss8o443cQKsdNRoBSI8ycWf2Twd+QFY6ePY46DWZfVqwvos1KlsapIJ32cpWvNMn hRw6abz5/bdQRDF/MHr3Q95NK5CD5vx7OrvQhWmckMXmXhNjh0FbQkZvdR6b8tboFuD2 6SxnVooD5yTmRr9ypceiD1azq9/D6rcv+YZ/6U4rC9T7jaPi0kc5xix/OMpor2Z6/hUi 96Rt6aCIM0hnKLuEost1ugYef8I81GWnrFV0ii84zbrrYl92KaaTBKxHDNNw7GjXjpcq tcuN4g4feBgBYwSB+gLgBRyIdLueaixXD4mYsTMl7OEqpqj/ewjaFOLbBRvtdWz1LLlV bEuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721237918; x=1721842718; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k6Iq8ntYV8VLv/VsXehkUdCfLNawZvjTAJLVmjk6gDc=; b=mDbUCYSCxx8L06gzht93gtWGuzn99qaTtvlt/J1JDe4jOOVQUj9/fYfiHOh8NUnobf ulDCZX1ADlEP+sl2UiEXxJqaL2C+9k6IIzY1b7QoxWAih/I9OQwivOxJaLTUAlVMjEK0 NIIWHbQBNq38uCVvgyakomAvzZTKziQitI7ZQHRvgD7dmkULaac1cn9KD61SwQ/GHdtQ 3Y7r0dX5JFp4fFFGWxiSZPXWn2/n8hasPnJBZkRxj+TOQJRGL4xVuMMd/5pQbXcDkB35 skqaaPoahEmngfIFzb0BcACyUk2to+T0Ulin6yzlC6DMDPZoqnxFS6BxgF2XM5jZo2rO aDrA== X-Forwarded-Encrypted: i=1; AJvYcCVcZMUOGy3ZAI0X/tJYryrEcjnIZTgD6RgYanZUz3cjFfZ6WxOqaVJuSA3zbESKK0xwznAEQx98l09noICX3IWi8bmLYew= X-Gm-Message-State: AOJu0YySpJmubcry5kUklOJWs2zWvEcFd7aWid/MxmK/KFybpTqPD+NI 0DGHFLC8zH7BJd76rfefnZCMps25ogjnWBR5cecjON56urAjWF8LRv04xHhG1x61hOFcKdqXu13 DKdgxEOtoz3AKmmmr3op+mxobUPs= X-Google-Smtp-Source: AGHT+IEE1DDKFq88gZdXmgBVImXgqCpe3PRmhaSDmPI1hfUW86/wYEwWEHt4MmFWLzN0bSckvDP0GwhJuinBEraiqgc= X-Received: by 2002:a05:6870:d202:b0:250:70bb:1a97 with SMTP id 586e51a60fabf-260d90778a2mr2028907fac.24.1721237918618; Wed, 17 Jul 2024 10:38:38 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288931 Archived-At: On Wed, Jul 17, 2024 at 6:25=E2=80=AFPM Eshel Yaron wro= te: > > Jo=C3=A3o T=C3=A1vora writes: > > > On Wed, Jul 17, 2024 at 2:08=E2=80=AFPM Eshel Yaron = wrote: > >> > >> Hi Jo=C3=A3o, > >> > >> Jo=C3=A3o T=C3=A1vora writes: > >> > >> > On Wed, Jul 17, 2024 at 9:20=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: > >> >> > >> >> On Wed, Jul 17, 2024 at 7:12=E2=80=AFAM Eshel Yaron wrote: > >> >> > >> >> > > Yes, this seems good for emacs-30. Thanks Eshel! > >> >> > Great, thanks. Since this is a change in eglot.el, let me also a= sk Jo=C3=A3o > >> >> > before installing: Jo=C3=A3o, any objections to the change above? > >> >> > >> >> I'd like to understand what problem it is solving. > >> > > >> > I've read a bit of the thread. There seems to be an error involved, > >> > but I didn't see a backtrace for this error. Can someone produce it= ? > >> > >> Sure, here's one (also see the recipe I posted upthread): > > > > Thanks. Is the backtrace below what's unequivocally (or close) > > produced by that recipe? > > Yes, that's what I see. > > > Anyway, can you try this patch? > > That seems to work too :) I understand the source of _this_ problem, and the line I changed addresses it. My worry is that my fix also creates more problems, but it seems cleaner. It has to be tested, particularly with Eglot reconne= cts. Anyway the fix that someone proposed -- to refrain from issuing `flymake-mo= de` when flymake-mode is already active -- isn't right. It's just papering over a bug waiting to appear again when someone does that in another mode hook. The correct fix is similar to what I did, fixing the state management/clean= up in flymake.el. Maybe the reason for brutally resetting flymake--state does= n't apply anymore: it doesn't seem right at all. Jo=C3=A3o