From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#51549: 29.0.50; flymake error when filename contain '%' Date: Sat, 6 Nov 2021 16:45:59 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6396"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Ola x Nilsson , 51549@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 06 17:47:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjOqU-0001TW-OQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Nov 2021 17:47:10 +0100 Original-Received: from localhost ([::1]:59284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjOqS-0002iP-Si for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Nov 2021 12:47:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjOqM-0002iE-4y for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 12:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38774) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjOqL-0008A0-Sl for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 12:47:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjOqL-0001Ry-Ra for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 12:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Nov 2021 16:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51549 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 51549-submit@debbugs.gnu.org id=B51549.16362171785508 (code B ref 51549); Sat, 06 Nov 2021 16:47:01 +0000 Original-Received: (at 51549) by debbugs.gnu.org; 6 Nov 2021 16:46:18 +0000 Original-Received: from localhost ([127.0.0.1]:50320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjOpe-0001Qm-2l for submit@debbugs.gnu.org; Sat, 06 Nov 2021 12:46:18 -0400 Original-Received: from mail-pj1-f43.google.com ([209.85.216.43]:53157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjOpc-0001QZ-Bf for 51549@debbugs.gnu.org; Sat, 06 Nov 2021 12:46:16 -0400 Original-Received: by mail-pj1-f43.google.com with SMTP id h24so4066353pjq.2 for <51549@debbugs.gnu.org>; Sat, 06 Nov 2021 09:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MvV5kTExy3iEof+Fdu+D8hFwH2nFtFQ4CDTH9qP26aQ=; b=Lz6ocqPgkjfzQ3r37LNqYqVl1O0w0rkyRvXnoEBfzBj3a2ga8iOG8nusug99DIg7SW 8/XhL2R4i04FT4ko5u38gfKfpqtIMf0BBcSmcxZ5FbOIiCfeMRAIbJ4pVAmN//PIZtjH zoLvp5I8yLNvRCpvVzZCSUMz8iCQP2G05Dmxwq01Zw/bja8/pwZzk1/VE3WgNfTtXC0d RRry0LnScNpD8jvebcbk0Y9fmhEFP3WbLjOaDUhOutOdHAIWAf2stg/l7Jca6Z0XRgHh sUV3s15/+Wx3MVdrXYZeXTLuEUJSAqLhADraOlVFZZ/yQqB2bOfrfX+drmNhmua4XAnw LYKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MvV5kTExy3iEof+Fdu+D8hFwH2nFtFQ4CDTH9qP26aQ=; b=49JjJ/1epgtM7QuIhgwJVE0YLnGrYigQv/8ZlSY08cFn1cOwTZug+1oo0zL4ZgLJQh 73q8kojp4rHEjsajOyjjogW7tQxTgrWUidtd84ZPQkIOcTenyu2RrURDD4qSr2mmOC39 7W84f2KeBH+6daA70IedQD0pMzdMAWdeCQgoq3n/FHz7HV3GwPGVwNUYh9GLJMGYtlqi btaDAeyuCkswvJBFUrrr0z7Qf0rn8lnDlXpRFus2UbW0uYQpyd88B38bAZ03vgNCs01A ok6g8zPeOpAEj+XZtRaNNuVPnY+p3GH8QRJZ+baNBMPtrUHXzpQ6pmfV5lo8u5YJA9k4 8D/A== X-Gm-Message-State: AOAM533fJ7ALFQiJdqTvS1ooESftl+PT9WFr3/BPlnwi6f0Okkgd/bGT mh9elaS5XOwEtUauiVlOJaInxQe0bPUspb82ITE= X-Google-Smtp-Source: ABdhPJyEoCeTQZNFARpSpmsJNPC+G+fmjL0VUWhZua7xavvVjJXc3ycxaYixA2R3a+LrDfCFub4BqIMFZlW4XzKFaAo= X-Received: by 2002:a17:90b:188e:: with SMTP id mn14mr38723095pjb.91.1636217170509; Sat, 06 Nov 2021 09:46:10 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219119 Archived-At: On Sat, Nov 6, 2021 at 11:08 AM Stefan Kangas wrote: > That's what I thought too, until I looked at the code. Unfortunately, > the fix we both thought of isn't that trivial as we set > `warning-type-format' like this: > > (warning-type-format > (format " [%s %s]" > (or sublog 'flymake) > (current-buffer))) Ah I see. Then maybe the problem is how that is used forward. > And then we run `display-warning', which uses this variable as the first > argument to format. > > Is there a strong need to have this format for flymake warnings? Absolutely not. This is probably one of the most over-engineered things I put in Flymake. It's occasionally useful, but not terribly so. > Emergency [flymake foo%sbar.c]: foo > > If not, my best idea for fixing this is to remove the filename from the > `warning-type-format', and put it in the message instead. That would be > a backwards-incompatible change, however. Yes, do what you think is best, and thanks in advance. It's good to have the buffer name where the warning came from, but it doesn't have to be in that exact place. Maybe just escaping the "%" in the return value of `current-buffer` would work though? Doubling the "%" into "%%", perhaps. Jo=C3=A3o