From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#53853: [PATCH] Don't use string-replace in flymake Date: Tue, 8 Feb 2022 13:18:44 +0000 Message-ID: References: <87r18e7fb7.fsf@gmail.com> <87zgn1ublj.fsf@gnus.org> <87mtj17oqg.fsf@gmail.com> <87ee4d7o3f.fsf@gmail.com> <875ypp7kmu.fsf@gmail.com> <83iltpwlwn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000451bc005d7818c55" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37860"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Brian Leung , Robert Pluim , Lars Ingebrigtsen , 53853@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 08 15:45:53 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHRke-0009ai-LX for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 15:45:52 +0100 Original-Received: from localhost ([::1]:54250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHRkc-0004CV-Th for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 09:45:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHQOd-0004cc-AP for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 08:19:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51931) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHQOc-0002Cb-IX for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 08:19:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHQOc-00035D-Fb for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 08:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Feb 2022 13:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53853-submit@debbugs.gnu.org id=B53853.164432629611793 (code B ref 53853); Tue, 08 Feb 2022 13:19:02 +0000 Original-Received: (at 53853) by debbugs.gnu.org; 8 Feb 2022 13:18:16 +0000 Original-Received: from localhost ([127.0.0.1]:45826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHQNr-000349-Us for submit@debbugs.gnu.org; Tue, 08 Feb 2022 08:18:16 -0500 Original-Received: from mail-oi1-f171.google.com ([209.85.167.171]:39882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHQNp-00033v-8h for 53853@debbugs.gnu.org; Tue, 08 Feb 2022 08:18:14 -0500 Original-Received: by mail-oi1-f171.google.com with SMTP id s24so12803304oic.6 for <53853@debbugs.gnu.org>; Tue, 08 Feb 2022 05:18:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HzF65n7vTaz9AHtsMX4dzQoIrdUyUBw81qMYyzxa2qQ=; b=iT1zAxR8S1B46X7zb0wBZFDU3Y7fcvIr5s+zSq96xrs7v4ZBQYXcVXoiJwMKvsOnSB aWEGHeJwQHkMvWULWGlEoOYkAu1edRhjeCPjh3WNsN9+LtdPchwPhJbGfPhDsVZ4vS99 EE2HEVhytL/oRYxUZTUWYCeRZG6HtjA4A5dvrCxtLloEtPyIy6adP9WjCx9DbJ0Ip4w1 dTkNQp94Od3DJGWXJOaFCj5ekNvw0oa2FH2dlZb3kyJB7rWEcOcUerEG43xdst+oYojt 4xz6zxvrpnBNf9mEWFJhKXnzqsu3XVMrlNYRg5g3OKl1MJY4p6domUhKm+J6+6tjdWDj zAzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HzF65n7vTaz9AHtsMX4dzQoIrdUyUBw81qMYyzxa2qQ=; b=I4H7hNK/zkvzNKlZcVjzTQw2I3PkessoSHD1ZVlgYo3JSH+HtijrK/DsHXtfhqwpKq LceKPnHpisTkpPiC93JJI1P/EgAuEEyhouLnfsyQvoYNF0CD4JndkOYzta9PrGAVyElo 9DOB3X/3bnwRN9Ti5geZUN3HrasLTV7yXnVGTbAkEtVjV45WZGL78xgvu8ykKT0Z4/5y 29nq66TPuitIm6Di17/fOAAbdvVoN+On/5TW4EBjjcWTt+Gj0YGk0a7tBQia/sWhiDOz n7dXDof8L4WK0PFHK2Zn/ZUeCb6oAdF+CuNsqIIik2FRx4zYo2qd5jvOSpEVyWrpXIgR whZg== X-Gm-Message-State: AOAM532awVgQ3jeN+zjEO+PY38He4mtNfBu2NkJj26rtqcZKgsbo8l7/ GaCuNs5fEdX0aBJ06W+DDGzNsaYstORb3WVgM5g= X-Google-Smtp-Source: ABdhPJyroXi5Osv2Ls7kHNaeuHqg4mj2M/beLf8ND1JZCQeV9iJRJBmjKM1fBKRA26bqOyUchBUlgYBwyHfgAET9srA= X-Received: by 2002:aca:eb09:: with SMTP id j9mr481075oih.268.1644326287644; Tue, 08 Feb 2022 05:18:07 -0800 (PST) In-Reply-To: <83iltpwlwn.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226371 Archived-At: --000000000000451bc005d7818c55 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Alright. Seems that the discussion died down and there was never the fix and reversion we (presumably?) agreed on. So I think if the incompatible string-something has been now replaced by the replace-regexp-something that is compatible, we should now put the 26.1 in the header again. If everyone agrees, I ask someone with a Emacs master/emacs-28 checkout nearby to do that change and also bump flymake.el's version. Robert maybe? Thanks in advance. On Tue, Feb 8, 2022 at 1:04 PM Eli Zaretskii wrote: > > From: Jo=C3=A3o T=C3=A1vora > > Date: Tue, 8 Feb 2022 09:58:06 +0000 > > Cc: Brian Leung , Lars Ingebrigtsen , > 53853@debbugs.gnu.org > > > > This change: > > > > commit 6b8957852476e4ba31873424aa8f81d9e55bc34c > > Author: Eli Zaretskii > > Date: Thu Dec 9 17:01:57 2021 +0200 > > > > ; * lisp/progmodes/flymake.el: Update the minimum Emacs version. > > > > diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el > > --- a/lisp/progmodes/flymake.el > > +++ b/lisp/progmodes/flymake.el > > @@ -9,1 +9,1 @@ > > -;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0") (project "0.7.1")= ) > > +;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0") (project "0.7.1")= ) > > > > breaks "downstream" users of flymake.el as a "core" package, eglot.el > > most notably. > > > > Can you explain it? I'm not 100% sure if we have discussed this before= . > > If we have, I'm very sorry, but I forgot the context. > > Asked and answered, see > > https://lists.gnu.org/archive/html/emacs-devel/2021-12/msg01898.html > https://lists.gnu.org/archive/html/help-gnu-emacs/2021-12/msg00166.html > --=20 Jo=C3=A3o T=C3=A1vora --000000000000451bc005d7818c55 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Alright.=C2=A0 Seems that the discussion died down an= d there was never the fix and
reversion we (presumably?) agr= eed on. So I think if the incompatible string-something has
= been now replaced by the replace-regexp-something that is compatible, we sh= ould now
put the 26.1 in the header again.=C2=A0 If everyone= agrees, I ask someone with a Emacs
master/emacs-28 checkout= nearby to do that change and also bump flymake.el's version.

Robert maybe? Thanks in advance.

On Tue, Feb 8, 2= 022 at 1:04 PM Eli Zaretskii <eliz@gnu.o= rg> wrote:
joaotavora@gmail.com>
> Date: Tue, 8 Feb 2022 09:58:06 +0000
> Cc: Brian Leung <leungbk@posteo.net>, Lars Ingebrigtsen <larsi@gnus.org>, 53853@debbugs.gnu.org
>
> This change:
>
> commit 6b8957852476e4ba31873424aa8f81d9e55bc34c
> Author: Eli Zaretskii <eliz@gnu.org>
> Date:=C2=A0 =C2=A0Thu Dec 9 17:01:57 2021 +0200
>
>=C2=A0 =C2=A0 =C2=A0; * lisp/progmodes/flymake.el: Update the minimum E= macs version.
>
> diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
> --- a/lisp/progmodes/flymake.el
> +++ b/lisp/progmodes/flymake.el
> @@ -9,1 +9,1 @@
> -;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0&quo= t;) (project "0.7.1"))
> +;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0&quo= t;) (project "0.7.1"))
>
> breaks "downstream" users of flymake.el as a "core"= ; package, eglot.el
> most notably.=C2=A0
>
> Can you explain it?=C2=A0 I'm not 100% sure if we have discussed t= his before.
> If we have, I'm very sorry, but I forgot the context.

Asked and answered, see

=C2=A0 https://lists.gnu.org/arc= hive/html/emacs-devel/2021-12/msg01898.html
=C2=A0 https://lists.gnu.org/= archive/html/help-gnu-emacs/2021-12/msg00166.html


--
Jo=C3=A3o T=C3=A1vora
--000000000000451bc005d7818c55--