From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#56407: 29.0.50; desktop.el shouldn't be saving/restoring eglot--managed-mode, which is not for interactive use Date: Wed, 6 Jul 2022 14:59:25 +0100 Message-ID: References: <87y1x7pd53.fsf@gmail.com> <83v8sb73ga.fsf@gnu.org> <87tu7vpc8y.fsf@gmail.com> <83tu7v6kjv.fsf@gnu.org> <83r12y7b0y.fsf@gnu.org> <83let676fe.fsf@gnu.org> <83h73u75bi.fsf@gnu.org> <875ykajqks.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000645c2305e3235cdd" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14994"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Stefan Kangas , 56407@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 06 15:59:54 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o95ZJ-0003ZC-AJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 15:59:53 +0200 Original-Received: from localhost ([::1]:36182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o95ZI-0007nJ-7K for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 09:59:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o95YU-0007AA-SV for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 09:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60860) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o95YU-0008R2-JP for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 09:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o95YU-0005T1-GL for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 09:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2022 13:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56407 X-GNU-PR-Package: emacs Original-Received: via spool by 56407-submit@debbugs.gnu.org id=B56407.165711590520961 (code B ref 56407); Wed, 06 Jul 2022 13:59:02 +0000 Original-Received: (at 56407) by debbugs.gnu.org; 6 Jul 2022 13:58:25 +0000 Original-Received: from localhost ([127.0.0.1]:54757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o95Xs-0005S1-OA for submit@debbugs.gnu.org; Wed, 06 Jul 2022 09:58:25 -0400 Original-Received: from mail-ot1-f46.google.com ([209.85.210.46]:47082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o95Xq-0005Rl-Nf for 56407@debbugs.gnu.org; Wed, 06 Jul 2022 09:58:23 -0400 Original-Received: by mail-ot1-f46.google.com with SMTP id e14-20020a9d018e000000b00618ca3183a0so11229469ote.13 for <56407@debbugs.gnu.org>; Wed, 06 Jul 2022 06:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lnE2e1+hbvmp3H2Pc/C++pci3QCgPxuVyQ/W1H02xy0=; b=qlpJ6CHrRgAlkWdJ6Gm3EDXBmQYWe1VoVmkc/ew36QZq8c9ySJ4AbkgIZPRIBvZIVD pXrK98pQBMV64FA+1bN414iy9wnqLrbkB/wCzwgfPQ30JmVPHBCodbvEH2RJrHe4nbNl sN8/dr1saF2xp83Lc5+LJL/2TAFLcnnDOEl426FSOqGaKuaibmOSb0PSKFW2X7LYYQtU QUxjJdeJ7YJtwYkZSpQGT7G91C+EGSt2pNbQPOIlO+SdbtXafzfhc9pSkI2HEk8MwNY1 aq1Po8SYq/d2ImJAv5WT+4725Gtnx3btGUkpRpedXGRK7Cp4yvPuLdWnSmlWl3OR/KFN 3J7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lnE2e1+hbvmp3H2Pc/C++pci3QCgPxuVyQ/W1H02xy0=; b=Nk0jkBw3Qw2XBGu/+rfD3sLfnZzcdeUp/m1Idz6p6EZiC68Xpn1E/6ikUvq4YBRsWq 7y6L6mMK/GCt95ppAsYn0qGndCPBI/+M5IHFNayzSybAZG/xk+exzEitQVAhAALeSwZW 6pLOxkAWunEfkCrksPzXtfFhijzugSymtdndYNOGJ376pShIEyLay+lh5oCxG0ZpkQdZ Z0UJ3/wRiV7fYH5WjnDyBxjYJZkru8ISxcBRedh7IS8Tsgcr7RBTcl/1uS7d0L4/10r/ sZcdcI/9TrWbFlEfsF/OU1TH0Y/W6pw+j6kJcdJ7I1GoW5i6Tqx3CYCE0dWp8+AqIRWC qATg== X-Gm-Message-State: AJIora9VCk0uMwDUYISw+NUv6lNQ+L2h4/r0Tui9bUXpIQmQq87D85Wr LFymZPxLk6i44Igg5+ViJr20xfJlohO/QPakjUKLnpxM X-Google-Smtp-Source: AGRyM1udal6VId9Pijh0I8E2RVqMFzOgwQCpI3WRPKin9Eb6xiHuVlldF3yByi18pwd4AHiRzJa3WK9vpngMpnrQrDs= X-Received: by 2002:a9d:4e91:0:b0:616:8273:76e6 with SMTP id v17-20020a9d4e91000000b00616827376e6mr17372198otk.340.1657115896993; Wed, 06 Jul 2022 06:58:16 -0700 (PDT) In-Reply-To: <875ykajqks.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236250 Archived-At: --000000000000645c2305e3235cdd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jul 6, 2022 at 2:53 PM Lars Ingebrigtsen wrote: > Jo=C3=A3o T=C3=A1vora writes: > > > Why is it the easiest one? Because I've just remembered an obvious > > drawback of the symbol-property approach: it will only work on Emacs > trunk, > > _unless_ we make the little dance (that I've done a few times) of makin= g > > desktop.el a GNU ELPA :core package and making eglot.el depend on > > that package (which is different from _requiring_ the load of that > package). > > > > Lars, what do you think? > > Hm, I'd forgotten that eglot was also an ELPA package. > > Making desktop a :core package is fine by me, but you're right that it'd > be easier to use with-eval-after-load here. (I'm still in favour of > adding the symbol-plist thing for desktop as a more long term solution, > but we can do both.) > Yeah, the problem is if desktop.el uses recently added features of some _other_ library. Then I'd have to add that one to :core as well, or somehow clarify the supported uses of desktop.el in that context. I don't have time for that, so I think I'll go with `with-eval-after-load` in eglot.el and call it a day. Jo=C3=A3o --000000000000645c2305e3235cdd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Jul 6, 2022 at 2:53 PM Lars Ingebrigtsen <larsi@gnus.org> wrote:
Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> writ= es:

> Why is it the easiest one?=C2=A0 Because I've just remembered an o= bvious
> drawback of the symbol-property approach: it will only work on Emacs t= runk,
> _unless_ we make the little dance (that I've done a few times) of = making
> desktop.el a GNU ELPA :core=C2=A0 package and making eglot.el depend o= n
> that package (which is different from _requiring_ the load of that pac= kage).
>
> Lars, what do you think?

Hm, I'd forgotten that eglot was also an ELPA package.

Making desktop a :core package is fine by me, but you're right that it&= #39;d
be easier to use with-eval-after-load here.=C2=A0 (I'm still in favour = of
adding the symbol-plist thing for desktop as a more long term solution,
but we can do both.)

Yeah, the problem = is if desktop.el uses recently added features of
some _other_ lib= rary.=C2=A0 Then I'd have to add that one to :core as well,
o= r somehow clarify the supported uses of desktop.el in that context.

I don't have time for that, so I think I'll go wi= th `with-eval-after-load` in
eglot.el and call it a day.

Jo=C3=A3o
--000000000000645c2305e3235cdd--