From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62157: More control over the mouse behaviour in eglot Date: Mon, 13 Mar 2023 16:09:59 +0000 Message-ID: References: <87lek0vdzd.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16786"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62157@debbugs.gnu.org, Pedro Andres Aranda Gutierrez To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 13 17:11:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbklZ-0004FN-Qq for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Mar 2023 17:11:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pbklM-0005Xi-N2; Mon, 13 Mar 2023 12:11:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbklK-0005XR-Ma for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 12:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pbklK-0002GE-CY for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 12:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pbklJ-0003yu-Q2 for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 12:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Mar 2023 16:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62157 X-GNU-PR-Package: emacs Original-Received: via spool by 62157-submit@debbugs.gnu.org id=B62157.167872381915249 (code B ref 62157); Mon, 13 Mar 2023 16:11:01 +0000 Original-Received: (at 62157) by debbugs.gnu.org; 13 Mar 2023 16:10:19 +0000 Original-Received: from localhost ([127.0.0.1]:35497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbkkd-0003xt-1n for submit@debbugs.gnu.org; Mon, 13 Mar 2023 12:10:19 -0400 Original-Received: from mail-oa1-f41.google.com ([209.85.160.41]:45950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbkkZ-0003xf-Rv for 62157@debbugs.gnu.org; Mon, 13 Mar 2023 12:10:17 -0400 Original-Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-17711f56136so14242420fac.12 for <62157@debbugs.gnu.org>; Mon, 13 Mar 2023 09:10:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678723810; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8mZLTpSbkRPG+bKx2Ya5JhG5Ex+/vDHNdtzI7frjpl4=; b=UrEdKqkBh62elOS9HxQpyK4AA7sMgLPIopJu+B4yO7UWa35JgJtixhsDO8W1zukFLZ /EmaopI/nwMCo7s3IJjK650gzOqJtlKZcSsxKeYY8kkYXfaEdlv8hedKoDgOT613P5NW wILQMHCMKvrMm4GcEDTICFg/b3WGAQD/vBy6yZNYsPoXRrypP/0aiNvhMat1uLRdCvu2 Q0E3qVWSjGDHHOpoQLfW3Im8FG9NNuvhj3Yo6neqJwW1zId7LLg5gvo7/hLLEZhjhcaf ybEUyEeL3fPQ62GOok0paVcVegD46FAvveBxY183H8SZ1fNJAmD6xTnvEzyTLpqSbRVb C+cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678723810; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8mZLTpSbkRPG+bKx2Ya5JhG5Ex+/vDHNdtzI7frjpl4=; b=wLtTGzNbyo9rcozSspph5nIliVlXrh2u9KZrrTBED1wuMTL29OUZVMvpyA5LG8zFrE vufo/dYd7XuJ2DIdfc45i/N3fqe0cYDlZYMJsPN51ZV28YyxplgHrET8CWivWgrXQMci 9d6SGMxEFQI38GkRFQjGOcQ+QRyNrIyKhQ+rPQL8UiWU/hc7Kx7qmtyB1tPw6UWhJ0KB CaSKfLAxEorIplW74gRxgHdkQf0GuPb8nfbsNi+hbFYIgSoaWfwmiFUIezaY6BH+RuqA D3YNJP5uzpH1YrPcxClplavfJZYh5tCM6halOwezOCpWElgLih7vekgj8CzP+dL2mvaN qqkA== X-Gm-Message-State: AO0yUKU1+bHuaiX5rVE0yGnjN9jkx1YkUrKdo1k3dANgNwM/Su+eHIPT S/L+cCiPSifFEWb9ZPU813bxLEQgliGlOuVT5bA= X-Google-Smtp-Source: AK7set8REEgr2i0MqefXR5pbSYmLoOZbuxbM/WTITGd0xMclSZs1MWGVe/FH0JbQ3VlVPLTJVa5jyx/SE/oo6GUQD4o= X-Received: by 2002:a05:6871:6bb0:b0:176:2915:6451 with SMTP id zh48-20020a0568716bb000b0017629156451mr12475349oab.5.1678723810081; Mon, 13 Mar 2023 09:10:10 -0700 (PDT) In-Reply-To: <87lek0vdzd.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257912 Archived-At: On Mon, Mar 13, 2023 at 3:59=E2=80=AFPM Robert Pluim wro= te: > > >>>>> On Mon, 13 Mar 2023 15:47:38 +0000, Jo=C3=A3o T=C3=A1vora said: > Jo=C3=A3o> Can you try this patch? It also changes the default bindi= ng to > Jo=C3=A3o> [mouse-2]. > > I think you meant 'mouse-2', but you typed 'mouse-1' in the patch. Yes, sorry. > Jo=C3=A3o> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglo= t.el > Jo=C3=A3o> index 2491c86ea5b..256b4cd93ba 100644 > Jo=C3=A3o> --- a/lisp/progmodes/eglot.el > Jo=C3=A3o> +++ b/lisp/progmodes/eglot.el > Jo=C3=A3o> @@ -2084,15 +2084,18 @@ eglot--mode-line-format > Jo=C3=A3o> (defalias 'eglot--make-diag 'flymake-make-diagnostic) > Jo=C3=A3o> (defalias 'eglot--diag-data 'flymake-diagnostic-data) > > Jo=C3=A3o> +(defvar eglot-diagnostics-map > Jo=C3=A3o> + "Map active in Eglot-backed Flymake diagnostic overlays= ." > Jo=C3=A3o> + (let ((map (make-sparse-keymap))) > Jo=C3=A3o> + (define-key map [mouse-1] 'eglot-code-actions-at-mous= e) > Jo=C3=A3o> + map)) > Jo=C3=A3o> + > > I=CA=BCm guessing eglot is not yet using `defvar-keymap' because of > backwards compatibility? I'd think so yes. > In any case, this doesn=CA=BCt make the binding easily changable, you hav= e > to manually unset/set the `eglot-code-actions-at-mouse' binding. My > attempt to fix this descended into a circular dependency spiral > between the keymap and the key defcustom, so I=CA=BCm hoping you know a > good way to do it :-) A key defcustom isn't needed IMO. You may even want multiple bindings there. 99% percent of users will like the default bindings, the others can (define-key eglot-diagnostics-map [mouse-2] nil) or (unbind-key [mouse-1] eglot-diagnostics-map) which I don't know if exists in older Emacsen. Jo=C3=A3o