From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#73452: Code lens support in eglot Date: Tue, 24 Sep 2024 22:01:02 +0100 Message-ID: References: <05f4d679-d2cd-409c-aafd-bfac2eda7a21@fbengineering.ch> <86v7ylcatg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40170"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73452@debbugs.gnu.org, federico.beffa@fbengineering.ch To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 24 23:02:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1stCg2-000ALA-Aj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Sep 2024 23:02:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stCfD-0005ag-H1; Tue, 24 Sep 2024 17:01:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stCfB-0005aX-Qk for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2024 17:01:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1stCfB-0000x9-H9 for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2024 17:01:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=nbyiVT5XvM+v170Z1KLZn3i5CFguDc9QrQNr6t9HzpE=; b=ZfPhrzLVNhytupWGRah2Hh360pFjSVhGqjXmp9NOMybe7JIUaxOnjNHdwDRIjNL/tPNhtgpb2nKW2qGWhLyYaM/KLFvpBGpkJinKKoBRWvz3X8DrEOMutWfotQfAU4op0d3bhe4EFyjKo0vTKJET5DyrrrMUJS3gt2esGBeDJ9Vv8JGNC9RjYbD9LNsdDPlIG0/gKe8l2ExRo9sYr9+q8On5LmY/b8uyCxgwSugNYIFLYnPgXhl9wsE7IjwhZIn4M6lrumskCORnmUzZZbvR4Xdgx7sp2lpJZiuOOHjORzILF8yb045MRG6vXF7TjHl3Ood9xvQWqnefVeCGZytQDg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1stCfa-0007g9-9R for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2024 17:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Sep 2024 21:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73452 X-GNU-PR-Package: emacs Original-Received: via spool by 73452-submit@debbugs.gnu.org id=B73452.172721166729356 (code B ref 73452); Tue, 24 Sep 2024 21:02:02 +0000 Original-Received: (at 73452) by debbugs.gnu.org; 24 Sep 2024 21:01:07 +0000 Original-Received: from localhost ([127.0.0.1]:39560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stCeh-0007dP-9n for submit@debbugs.gnu.org; Tue, 24 Sep 2024 17:01:07 -0400 Original-Received: from mail-oi1-f176.google.com ([209.85.167.176]:43043) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1stCef-0007cZ-HL for 73452@debbugs.gnu.org; Tue, 24 Sep 2024 17:01:06 -0400 Original-Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3e06b72f3e7so132279b6e.0 for <73452@debbugs.gnu.org>; Tue, 24 Sep 2024 14:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727211575; x=1727816375; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nbyiVT5XvM+v170Z1KLZn3i5CFguDc9QrQNr6t9HzpE=; b=l7J6gRGNqUprvklW1Cq+XIxvqdHf9tKGZXNDLWT0ar0TlFSZvMwYwRtARLqA7SAV60 vuxmAaNNtiaiu2eQUkDRDkCEWldcT5T6RFitVMX7EQaTTaHn8VUtnkdewor5AU9kZ4xb X27ZiSTL6SM8+LpBWhlNWpzZKrOe23Q0LkAgsu/+EAn/1rdr6C50pi4VqaKASIqHSuXi dtE50JZACe3YpeYpuSMJAMXkobkL5e7cJQ5G21Cr5oCkfxxxLGRc8B5w7KfGBx/1NqX/ SVght/rvxifw+1RrZ0Oana+r0cfPB2rHn+qD2vpConF57aaP21GjRUQMLJFMivSUmD4O HO6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727211575; x=1727816375; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nbyiVT5XvM+v170Z1KLZn3i5CFguDc9QrQNr6t9HzpE=; b=FwpsdKmw2J16skc7xKzkM3P4vEAtzOGSi0unDBlyPYNPt3R8Wh3YusL/IF1Ly6y3LD UK7aHH3fCEHlqF2lLh4Q/8jJ1vF1ZMLgkbKOz2XLPN935O7KFQpBesjD4yLbWzA1hiva dN1PwH476m0LVKX5cbZX4UC7K6HeaX04ZWPOfJTQX6k+KNA0WR0fWaCwdr9k4iWeWpje Eo6Yb3i0sYBg+bGLYzynrnphAbWTAtaKJ9yIJSsNoKCLEK8vXD7pO3zeuqns+EDrft/U aIkebZOEW+aBRAoALwFvS2BcJDMvhSHVlPJvyrc6gUSoRuDaoCd1GCCigbpwCYTQPVj4 BrYQ== X-Forwarded-Encrypted: i=1; AJvYcCVnWGrWXRNT6cGt9Eixm5vU9QVcaQE1QVBbZrdNZWMHHrwb4BLA4kaBhH+kdhiAy2bauZkPig==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx93L0ggngU02sNPHbwOc7vD2Ov+NtHGbkE8dv7j8mgBh1vxeJX y7uZo3nX4roo8VkMtYuebITKj6H1NaRXlnlarZSMgj6LuyJkfIs95i7BN5JiXWVfuYUiqxHEnnb 291WCAg+7gAnzFPIgHXaOwhTbgPxzJg== X-Google-Smtp-Source: AGHT+IGzh2HpZsbcempvGol8etvnyjWT4c50W5vMMjGEBgWQQUGJ/bZwAg1Va5+W0lHtH+xPgpXEM4K4bNZMcti8UP8= X-Received: by 2002:a05:6808:2018:b0:3e0:41ce:e95e with SMTP id 5614622812f47-3e29220c245mr2147742b6e.2.1727211574711; Tue, 24 Sep 2024 13:59:34 -0700 (PDT) In-Reply-To: <86v7ylcatg.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292366 Archived-At: On Tue, Sep 24, 2024 at 4:48=E2=80=AFPM Eli Zaretskii wrote: > > > Cc: 73452@debbugs.gnu.org > > From: Jo=C3=A3o T=C3=A1vora > > Date: Tue, 24 Sep 2024 15:26:55 +0100 > > > > There is a discussion thread about this in the Eglot GitHub downstream = tracker. > > > > https://github.com/joaotavora/eglot/pull/71 > > > > The current consensus there is that the feature is not _that_ useful, > > and that a clean implementation isn't really trivial since there is no > > underlying Emcas support structure (like there is for documentation, > > cross-referencing, diagnostics, snippets, etc) > > What infrastructure would be needed? It's not easy to describe, you'd have to be very familiar with how code lens work on VSCode and Visual Studio (I'm not). It's a cross between Flymake and Eglot's custom inlay hints. The lower-level infrastructure (buttons, overlays, jit-lock-register) exist= s and is probably enough for a decent experience (though there are the typical annoying flaws with overlays and jit-lock-register). The probl= em is knowing how to tie this together in an sensible and robust infrastructur= e that Eglot (or other providers) can plug into. An abstraction that will mo= del something presumably more useful and practical than what is already available through other existing Emacs means (vc-* commands, M-x compile, Eglot code actions). Read the last parts of the discussion I linked to if you're interested. Jo=C3=A3o