From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#73355: 29.4; eglot-rename reports success when it shouldn't Date: Sat, 21 Sep 2024 21:15:42 +0100 Message-ID: References: <86plozvomz.fsf@fastmail.fm> <864j6947n1.fsf@gnu.org> <86zfo1kxx4.fsf@fastmail.fm> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000bb92ff0622a6d2b2" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39486"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73355@debbugs.gnu.org, Eli Zaretskii To: Joost Kremers Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 21 22:18:00 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ss6YK-000A8I-HP for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Sep 2024 22:18:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ss6Y3-00054g-J3; Sat, 21 Sep 2024 16:17:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ss6Y2-00054J-2G for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 16:17:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ss6Y1-0008Hz-P5 for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 16:17:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=S8XCJ3QhyN1q8Di0NXeMVT0J5LCEEWI8HvEq512Ypfk=; b=sgC4m4BH1fvInekLrAYUs6mrRTGsUCJRS6NCGMmJyG/zixZWsZY0uMC87ObuVrKixJszZfX1J7XRcNHqslQhqWpVayA2Ym/ox6KnP/n+Yo69UZPIxcxCF4gwdxst8xkgn4aucN05sdnhjt9LJFmioYbeI3vaAHtWlfWbdW1Bh6Rzv60dxTiXdkDhEE+YfTU+3ytnS4QfCyJjT7uKyb91s2Avf4Dx/VE5WeDzaflyiOl8ad0CO86Rdxa63fK8hEOBCrtGsUC3n3MJNynhkEye6s3B7gnxUUm1mBEh+zv4ksF1jRNpvALV2IbMmP3UFLKhy2DCwrPysHPmCurbqCYFhQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ss6YL-0005Vs-QA for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 16:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Sep 2024 20:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73355 X-GNU-PR-Package: emacs Original-Received: via spool by 73355-submit@debbugs.gnu.org id=B73355.172694984521134 (code B ref 73355); Sat, 21 Sep 2024 20:18:01 +0000 Original-Received: (at 73355) by debbugs.gnu.org; 21 Sep 2024 20:17:25 +0000 Original-Received: from localhost ([127.0.0.1]:40355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ss6Xk-0005Uo-In for submit@debbugs.gnu.org; Sat, 21 Sep 2024 16:17:24 -0400 Original-Received: from mail-oi1-f176.google.com ([209.85.167.176]:46198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ss6Xi-0005US-4b for 73355@debbugs.gnu.org; Sat, 21 Sep 2024 16:17:22 -0400 Original-Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3e03b6d99c3so1619570b6e.0 for <73355@debbugs.gnu.org>; Sat, 21 Sep 2024 13:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726949756; x=1727554556; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=S8XCJ3QhyN1q8Di0NXeMVT0J5LCEEWI8HvEq512Ypfk=; b=KAfC4GuOzFie0FTxNMpCISwNardLBLVyp0ok6HEFDbCc9XGA9GpNbGzRqJQwIY2rZx W78i1F5k+WMVz3nxK9VjuWHf3fC6aU+gBN4ARDiT1tLnIIGjTOqqa2Fs0zw5OGHzO3rN y0tnPVxyOBPmADt7uUAe5j2wFcp5+3axkrbaFs/Bf6Glb2TjpqKexkvrjQelAMxTzhet IgZC5zgEUh/tF7uYUJadi2YFgg9hPVx/dFM//iAPh0Bs2S0uuDnv6nnZYQiuMqF3lY+p wE7uqHAHtVDdbMLYIsQRStdGnyA3cc8ga7goDgA5fY3BdRx4Xhi4ezeCdqboLK+Dg8SC Zpew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726949756; x=1727554556; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S8XCJ3QhyN1q8Di0NXeMVT0J5LCEEWI8HvEq512Ypfk=; b=blNK5jofBEQVfz/lxLmDHy1WD7n0faad6WL83uJBogWlWHtSrhPAU3rUJadDFZ8z78 SN6U09DEdjDDADt01foYtoQ+Bnc1V1r1KbUyCWoFtyMO/lg+0OKNTHNJ1kWvFIZU8ZPd +Jl3O1TmXKsGGAhizg7aiL1oT7fMr3bzIw5TUz0Iypo4qe7ST+St1+VCiK8B1gp573bK Xce5yymhYZTTOK43X1d7tZ1tL1Bfmmiy6ckd9qbK3SV4wphVEvjBBbLLr0ft9LJk/8XY hq5ttAvG997akKZJAuW5qXgSxAF6zm1bfxN+/8nX/sjfi7E8PPUyP14/2HgL3ioGAjDN 3+hw== X-Forwarded-Encrypted: i=1; AJvYcCV78hzyAt5Cpm8YxMcgmxswOZS5QL48r1HOIRbysMZ5VFIY1cE1hmLp2J0o9X5vBl+LuDnYdQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yxo+xPfBSbtvKRVEOVWxhzhEIx6owHt7h9NwGOE5jy5UtC0CmRK RIi5j/3JENi8uYaQMSxIok7a6dRWVBXtomRJAs7LFZ3WzF3BFOvk91Rm8XsfIWEeRHG7NpEb406 SkfhtiA+ecLLQWVkBT8UAhgQErEg= X-Google-Smtp-Source: AGHT+IGxEg0BBMvlSJD8bqy42ZiGnHS2KiveyWTCmBY3WKDo13pU/j38/IwE0W3iM50AZDmcGz3inSdQANviLYAnkfM= X-Received: by 2002:a05:6808:199b:b0:3e0:3ab7:d7ad with SMTP id 5614622812f47-3e271bbd299mr5141904b6e.22.1726949755685; Sat, 21 Sep 2024 13:15:55 -0700 (PDT) In-Reply-To: <86zfo1kxx4.fsf@fastmail.fm> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292206 Archived-At: --000000000000bb92ff0622a6d2b2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Sep 21, 2024, 13:13 Joost Kremers wrote:= . > > > It's possible Eglot is just successfully applying 0 edits. > > I guess that's one way of looking at it. :-) > I'm say this because Eglot has no logic to check if a rename is valid or not. It just does what the server tells it to. If the intended rename is invalid, the server can error out (and Eglot will tell you this) out return 0 edits. Either way, the server calls all the shots. Jo=C3=A3o > --000000000000bb92ff0622a6d2b2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Sat, Sep 21, 2024, 13:13 Joost Kremers <joostk= remers@fastmail.fm> wrote:.

> It's possible Eglot is just successfully applying 0 edits.

I guess that's one way of looking at it. :-)

I'm say this because Eg= lot has no logic to check if a rename is valid or not. It just does what th= e server tells it to. If the intended rename is invalid, the server can err= or out (and Eglot will tell you this) out return 0 edits. Either way, the s= erver calls all the shots.

Jo=C3=A3o
--000000000000bb92ff0622a6d2b2--