From: "João Távora" <joaotavora@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 38992@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>,
waah@yellowfrog.io
Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep
Date: Thu, 5 Mar 2020 08:01:40 +0000 [thread overview]
Message-ID: <CALDnm50sG90JXDsa_gV9-xqBqtYOuPJ+dPoVHiZwnu0gAxvMkg@mail.gmail.com> (raw)
In-Reply-To: <adf10d07-92c8-0ac2-5be1-42f5f52c7482@yandex.ru>
[-- Attachment #1: Type: text/plain, Size: 1783 bytes --]
On Thu, Mar 5, 2020 at 12:01 AM Dmitry Gutov <dgutov@yandex.ru> wrote:
>
> On 05.03.2020 0:44, João Távora wrote:
> > fido-mode doesn't change icomplete-mode. It shouldn't, at least.
> > It just uses it as a library. And surely if it's a bug in fido-mode,
> > surely it needs fixing _there_ and not elsewhere. But it seems
> > not be the case (at least with your latest proposal), so you have
> > me confused.
>
> Since the problem isn't triggered by icomplete-mode, but is triggered by
> fido-mode, it seems the latter binds some commands that are not a great
> fit for it.
Sure fido-mode binds commands that it needs to bind for it
to be useful, the choice for M-j was the closest thing available at
the time. If you've made a better one since, that's great.
> ido-mode users, however, like to use RET for arbitrary inputs as well.
Let's first _not_ change the current fido-mode UI ok? At least
for now. Later (even before Emacs 27) could be fine.
> The previous patches are attached to the older message. Not too hard to
> find on the debbugs bug page.
I'm just looking for the patch to minibuffer.el that I remember you
saying you were preparing. (I'm sorry, but I don't have time right now to
find it in this very poor Gmail UI). I've pulled from your branch in Git
and yours patches look fine, but really I don't understand the minibuffer
one anymore at this kind of distance. But it it's the one we talked about
when I did understand it, I'm all for it.
> If I were to classify, the first one fixes a "UI deficiency", but the
> second one fixes a bug.
Don't know which is which, but classifiers will classify :-)
> I've pushed the updated (more limited) patches to the 'fido-mode-fix'
> branch.
Yes, thanks!
João
[-- Attachment #2: Type: text/html, Size: 2330 bytes --]
next prev parent reply other threads:[~2020-03-05 8:01 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 17:09 bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep waah
2020-01-09 3:25 ` Dmitry Gutov
2020-01-09 7:42 ` João Távora
2020-01-09 7:49 ` waah
2020-01-09 9:54 ` João Távora
2020-01-09 10:10 ` João Távora
[not found] ` <944631362.128066.1578605073103@office.mailbox.org>
2020-01-09 22:27 ` Dmitry Gutov
2020-01-10 10:10 ` João Távora
2020-01-10 11:22 ` waah
[not found] ` <fd9ede8f-50dc-3bb4-d3b7-850e38a146ec@yandex.ru>
2020-01-11 18:59 ` João Távora
2020-01-18 1:38 ` Dmitry Gutov
2020-01-19 13:00 ` João Távora
2020-01-20 14:54 ` Dmitry Gutov
2020-01-20 14:58 ` João Távora
2020-01-20 21:42 ` Dmitry Gutov
2020-01-20 23:04 ` Stefan Monnier
2020-01-20 23:56 ` Dmitry Gutov
2020-01-21 8:12 ` João Távora
2020-01-23 22:22 ` Dmitry Gutov
2020-01-24 14:35 ` João Távora
2020-01-21 16:32 ` Stefan Monnier
2020-01-21 16:41 ` João Távora
2020-01-21 17:02 ` waah
2020-01-21 17:24 ` João Távora
2020-01-21 18:54 ` Stefan Monnier
2020-01-21 22:58 ` Dmitry Gutov
2020-01-22 0:29 ` João Távora
2020-01-22 0:32 ` Stefan Monnier
2020-01-22 12:34 ` Dmitry Gutov
2020-01-23 16:28 ` Stefan Monnier
2020-01-23 16:51 ` João Távora
2020-01-23 22:07 ` Dmitry Gutov
2020-01-24 14:11 ` Stefan Monnier
2020-01-24 14:31 ` Dmitry Gutov
2020-01-29 21:23 ` Stefan Monnier
2020-01-31 1:48 ` Dmitry Gutov
2020-01-31 13:17 ` Stefan Monnier
2020-01-31 23:18 ` Dmitry Gutov
2020-02-01 8:07 ` Eli Zaretskii
2020-02-04 23:57 ` Dmitry Gutov
2020-02-05 14:20 ` Eli Zaretskii
2020-02-05 14:27 ` João Távora
2020-02-05 17:55 ` Dmitry Gutov
2020-02-05 18:12 ` João Távora
2020-03-04 22:07 ` Dmitry Gutov
2020-03-04 22:44 ` João Távora
2020-03-05 0:01 ` Dmitry Gutov
2020-03-05 8:01 ` João Távora [this message]
2020-03-05 8:36 ` Dmitry Gutov
2020-03-05 8:46 ` João Távora
2020-03-05 9:59 ` Dmitry Gutov
2020-03-05 11:51 ` João Távora
2020-03-05 12:14 ` Dmitry Gutov
2020-03-05 12:30 ` João Távora
2020-03-05 13:40 ` Dmitry Gutov
2020-03-05 13:54 ` João Távora
2020-03-05 14:03 ` Dmitry Gutov
[not found] ` <CALDnm52HzQym7RosF3AdTNwprqXs7Kk4GBi+3UGjkJt6ZDUJWQ@mail.gmail.com>
2020-03-05 14:17 ` Dmitry Gutov
2020-03-05 14:26 ` João Távora
2020-03-05 14:40 ` João Távora
2020-03-05 14:53 ` Dmitry Gutov
2020-03-05 14:58 ` João Távora
2020-03-08 16:22 ` Stefan Monnier
2020-02-05 14:46 ` Stefan Monnier
2020-03-05 0:15 ` Dmitry Gutov
2020-03-05 6:08 ` Eli Zaretskii
2020-03-07 14:10 ` João Távora
2020-03-07 14:46 ` Eli Zaretskii
2020-03-07 16:42 ` João Távora
2020-03-07 16:47 ` Drew Adams
2020-03-07 17:42 ` Eli Zaretskii
2020-03-07 19:28 ` João Távora
2020-03-08 16:28 ` Stefan Monnier
2020-03-08 16:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm50sG90JXDsa_gV9-xqBqtYOuPJ+dPoVHiZwnu0gAxvMkg@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=38992@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=monnier@iro.umontreal.ca \
--cc=waah@yellowfrog.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).