From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#73472: [PATCH] Substitute quotation marks in Eglot messages Date: Thu, 12 Dec 2024 10:57:48 +0000 Message-ID: References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> <865xowojsi.fsf@gnu.org> <86frnim9ol.fsf@gnu.org> <86y10lyy3s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25169"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Thomas Voss , 73472@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 12 12:00:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tLgve-0006NV-Cj for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Dec 2024 12:00:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLgvP-0005q9-8U; Thu, 12 Dec 2024 06:00:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLgvM-0005pS-5K for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2024 06:00:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLgvL-0000j1-Rj for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2024 06:00:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=Xww+ybNJIOZPFWFqcbsE7LuBaIB4gOLkm+owyzgGheY=; b=B5jO6trD3Hmv2KSp9R1hZgBarCFAsvP1Ze4PlQfOQakit1e51zLxTM8VNozfQXo5GL7xaYOMfJKVoPtmPJwe3QITjOBRqN27t3tYOlvkL8zCR30DEAb22ukxz42mBcpwPEfdCC6sEmt5+Dr56Bn8PhNQ53jQAsYft1/iVTjhLmBANk23rF86/eimKHu4IU7qbHIOO5/joPsGyGQNPJseOR/JM5G8QFu+Qz8GNUGrt9B5izCa+/l/yVxnY3ROgHly4HeREF1ghaqKrmOo9tFl46h1q4hbQ+L2OwFOgsjezvJ6WhBj1g62YmEvG13+kXWM//5QqwC5cOMs/wMHfLICEw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tLgvK-0000O4-Dv for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2024 06:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Dec 2024 11:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73472 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73472-submit@debbugs.gnu.org id=B73472.17340011501355 (code B ref 73472); Thu, 12 Dec 2024 11:00:02 +0000 Original-Received: (at 73472) by debbugs.gnu.org; 12 Dec 2024 10:59:10 +0000 Original-Received: from localhost ([127.0.0.1]:37825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLguT-0000Lm-M3 for submit@debbugs.gnu.org; Thu, 12 Dec 2024 05:59:10 -0500 Original-Received: from mail-oo1-f49.google.com ([209.85.161.49]:48458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLguQ-0000L0-4R for 73472@debbugs.gnu.org; Thu, 12 Dec 2024 05:59:08 -0500 Original-Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-5f2c51478e5so197779eaf.1 for <73472@debbugs.gnu.org>; Thu, 12 Dec 2024 02:59:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734001079; x=1734605879; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Xww+ybNJIOZPFWFqcbsE7LuBaIB4gOLkm+owyzgGheY=; b=Xwa2XrqizTNem9mMjHWBMcEik7h82StKuYjWUZZKX5oGCm056Ar0B/ltkF58MNCgHv YhnvzHxsS03LtXDE24AADO6amMd8g1CEMCV699ck2ZI8FYg3srG4799OZe614LqnZTc0 s5QJfSnnMwSxPvmwhHefBW2Pz9oKnGgoedfBGZwy1Bk8iNPd0RNK9PGEKbAL+BXiS9AN f50XLHDgFbdSNH3tV6AkJKWIOeenOIi6UfOtQSqyOZqQqllgvfZbj0GOfpk3BWP1l1Jn N/Rl33WY3EmR6RL/CgwMaMwb/xwa2Oiw5kDjh6r8wlHPdeIGE/dYDZZrnZJ1RLUSQRZF erEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734001079; x=1734605879; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xww+ybNJIOZPFWFqcbsE7LuBaIB4gOLkm+owyzgGheY=; b=g0QxrriT5RwdpcmgZhd/5f9qCsai1Q7Y9SrAV/ufZRQsiLA1lQFjUH+iEZ6FTOMrlQ cqhj71Nc0L7d56u1FCN0Rs3lqwOOyEVYtX7/RvRqlX9IKxbbuLi9uvAwX0QpHiqOwcbz 7EmDvP/hoqddgv56g9U1XxXAjMT7fXPL3KbUXaccn/qGlsmYDtmHrTIDESYFDMCkD63H d6ruMCg408sbl9Nc0S1LfwxAgE2Bs7/IfiO6F4g+mHnYDZ/bX5/SEFWTTkCWSKzXAG76 FgkZzYcbxOvUfdX67S1PGXF0jvHomhPNOkhNd2TMXjdwdPt/IPMjVwVZ4uQdemtYOp5Z M3dQ== X-Forwarded-Encrypted: i=1; AJvYcCWAtETu1xYU63JG9/3T5BPnyKdALTQ7zah+Po64Bs/kBiid9EIrHzP7N/m7M0LVex6lgT7gxQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxoaC3k657ms20YV5tMXpJgqalADpIvSbA9PeaohBw09ZRHd8Eu RtNR+TVvXYI3cgeiTal18o24OmRXvdWmtLhVih47WF5OLz7YL7VMGndGE8PazM3zF7FDm9/1GmF UYupCEUc+IR8GpN7M9UcWZ7xs6Eg= X-Gm-Gg: ASbGncssBvR3GSeGNTuLSvtQQyN34w4WEFmXd0OWB+dohqSQu8W4WYmlzmLBNXkBnYr CCWonsjYl2uSQs+kzAIHWhA351+aIdBhG1+2qcg== X-Google-Smtp-Source: AGHT+IE4lKZX9McnrzFT4GYR7RuoIKEL6YtTs6uV7UeCYCkkwTfx3hu6dIscGL1PWHsTLcKWGgwPQE38M94IYWhUXSw= X-Received: by 2002:a05:6870:1491:b0:29e:4340:b1b with SMTP id 586e51a60fabf-2a012baff1amr3903222fac.9.1734001079314; Thu, 12 Dec 2024 02:57:59 -0800 (PST) In-Reply-To: <86y10lyy3s.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296904 Archived-At: On Thu, Dec 12, 2024 at 10:50=E2=80=AFAM Eli Zaretskii wrote= : > > > Date: Mon, 09 Dec 2024 19:01:28 +0100 > > From: "Thomas Voss" > > > > Apologies for the long delay; I have been super busy recently. > > > > > Ping! > > > > > > > Thanks. Jo=C3=A3o, any comments? > > > > > > > > My only comment is that the log message says "format-prompt", but t= he > > > > code actually uses substitute-quotes. > > > > Uh=E2=80=A6 are we looking at the same patch? The log message in the p= atch I > > last sent does say =E2=80=98substitute-quotes=E2=80=99 for all the plac= es where I used > > that function, and only says =E2=80=98format-prompt=E2=80=99 for the pl= ace where I used > > that function (=E2=80=98eglot-rename=E2=80=99). > > > > Just in case, I attached the patch again to this email. > > Thanks. > > Jo=C3=A3o, are you okay with me installing this? Just had a look. The patch won't break anything, but it has some problems around the part where substitute quotes isn't around a literal, but wraps a bigger block. I'll try to fix it. It would also be great to have some f= ile local symbol-shortening mechanism to avoid that long name, but I'm not going to worry about that. Jo=C3=A3o