From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Thomas Voss <mail@thomasvoss.com>, 73472@debbugs.gnu.org
Subject: bug#73472: [PATCH] Substitute quotation marks in Eglot messages
Date: Thu, 12 Dec 2024 10:57:48 +0000 [thread overview]
Message-ID: <CALDnm50r=XuV8i-f8dZh-E-XCR69afSYjDQjcMj6fZTYZD43kA@mail.gmail.com> (raw)
In-Reply-To: <86y10lyy3s.fsf@gnu.org>
On Thu, Dec 12, 2024 at 10:50 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > Date: Mon, 09 Dec 2024 19:01:28 +0100
> > From: "Thomas Voss" <mail@thomasvoss.com>
> >
> > Apologies for the long delay; I have been super busy recently.
> >
> > > Ping!
> > >
> > > > Thanks. João, any comments?
> > > >
> > > > My only comment is that the log message says "format-prompt", but the
> > > > code actually uses substitute-quotes.
> >
> > Uh… are we looking at the same patch? The log message in the patch I
> > last sent does say ‘substitute-quotes’ for all the places where I used
> > that function, and only says ‘format-prompt’ for the place where I used
> > that function (‘eglot-rename’).
> >
> > Just in case, I attached the patch again to this email.
>
> Thanks.
>
> João, are you okay with me installing this?
Just had a look. The patch won't break anything, but it has some problems
around the part where substitute quotes isn't around a literal, but wraps
a bigger block. I'll try to fix it. It would also be great to have some file
local symbol-shortening mechanism to avoid that long name, but I'm
not going to worry about that.
João
prev parent reply other threads:[~2024-12-12 10:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 14:03 bug#73472: [PATCH] Substitute quotation marks in Eglot messages Thomas Voss via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-25 16:01 ` Eli Zaretskii
2024-09-25 18:03 ` Thomas Voss via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-26 5:52 ` Eli Zaretskii
2024-09-26 6:11 ` João Távora
2024-10-05 10:14 ` Eli Zaretskii
2024-10-05 12:48 ` João Távora
2024-10-07 8:12 ` Thomas Voss via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-07 11:32 ` Eli Zaretskii
2024-10-19 7:07 ` Eli Zaretskii
2024-10-19 8:33 ` Thomas Voss via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-21 21:58 ` Thomas Voss via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-09 9:09 ` Eli Zaretskii
2024-11-09 9:20 ` Thomas Voss via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-23 12:11 ` Eli Zaretskii
2024-11-29 8:27 ` Thomas Voss via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <D67D7KRE11VT.2VSGQYKYR6Q6F@thomasvoss.com>
2024-12-12 10:49 ` Eli Zaretskii
2024-12-12 10:57 ` João Távora [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm50r=XuV8i-f8dZh-E-XCR69afSYjDQjcMj6fZTYZD43kA@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=73472@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mail@thomasvoss.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).