From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#61412: Hover github discussion Date: Wed, 15 Feb 2023 15:05:13 +0000 Message-ID: References: <20230211081335.312224-1-dalal.chinmay.0101@gmail.com> <83o7pvav46.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000e2b6a705f4be68c6" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23126"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Chinmay Dalal , 61412@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 15 16:06:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSJMT-0005lR-9f for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Feb 2023 16:06:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSJMB-0002Xu-SJ; Wed, 15 Feb 2023 10:06:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSJMA-0002XZ-Ka for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 10:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSJMA-0005eC-Bt for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 10:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSJMA-0006kN-7V for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 10:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Feb 2023 15:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61412 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61412-submit@debbugs.gnu.org id=B61412.167647353225879 (code B ref 61412); Wed, 15 Feb 2023 15:06:02 +0000 Original-Received: (at 61412) by debbugs.gnu.org; 15 Feb 2023 15:05:32 +0000 Original-Received: from localhost ([127.0.0.1]:33582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSJLf-0006jL-Id for submit@debbugs.gnu.org; Wed, 15 Feb 2023 10:05:32 -0500 Original-Received: from mail-ot1-f48.google.com ([209.85.210.48]:43657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSJLd-0006j7-UN for 61412@debbugs.gnu.org; Wed, 15 Feb 2023 10:05:30 -0500 Original-Received: by mail-ot1-f48.google.com with SMTP id bv2-20020a0568300d8200b0068dc615ee44so5760686otb.10 for <61412@debbugs.gnu.org>; Wed, 15 Feb 2023 07:05:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7XrVNQ8lufeoKHoUcojGlFZnZ5CzdZO75QkRycMdQ+A=; b=MyH7/0XW0MFYQ3ub/6Q/+ZSWHGabez4dWzqTXE0X3jANJQ9vvsxPGUcPlNo2mgWEh4 28O7lQRlyOKXUKNVMyxlfo1+1h6ga/mjSwIStgg1QmNOR1dsTQAS7J+i0K86lpa711s2 kUtr68zKceXklj1hbS8fCggu7LrJm8QzjeN+/AoYJIjpkQDkTRcSBSxDHbpdF1DvSCGk yvx27XhrTH2bvSxNe4lbFEmcgEaY9O99FzuFtmEvtyin3eYzU4EOvRhGYaqNcPOphRZp gRYFJ09G84mYo/tbt+7e0h9EC2RIFENie7d7HToO1YkS64j0SwI8iHKSV0uo0L0RRAGz A1ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7XrVNQ8lufeoKHoUcojGlFZnZ5CzdZO75QkRycMdQ+A=; b=yTY/FJ6vW8oU8MFcHpwpc6QhDGTENiT8h5lMuE2VmvsTXtBZE25mZAbqbgfRBuWh/i 88P7zeMOl87SdNCEdi3skKdWSlEpVCFBF8gJ56Z8rOuXO0DNnngLHjQwRwuIwReungGz fTqLFE4BV/yX22EP6L2GQyLn2aDfXiZEssD5hUQnO+JRNZg1YAY43T5WXTV0aYGQnEHY fHG6P4N3xB83pE07o203e67wLVdkg45z+1qXwPciz+ef7z//1RUhjDlmq/t4Jo1SwTOL dU1Rg/wUyTIYb1opdC39EtkVVvewNbuaHJwFuwgJbrUdxbVvmA2zZwd5Huba66vkXI3H m7dg== X-Gm-Message-State: AO0yUKUmdLdBdgulM91dOMUTsDID/tLwvFonoRNKLGGyh+hkXhVF/KKM IWIWoBvBTQtKyREgDOGxduEGLUJIgUGCNXfVgXo= X-Google-Smtp-Source: AK7set8jWqAwjPDuD5BpbCNLmtNB90guuSNyS1cojlJkCEDB48tMhzMeDQMd49cPydZ1N0HteE/xoordJJAl34W61Es= X-Received: by 2002:a05:6830:6111:b0:690:c81f:d459 with SMTP id ca17-20020a056830611100b00690c81fd459mr144109otb.3.1676473524203; Wed, 15 Feb 2023 07:05:24 -0800 (PST) In-Reply-To: <83o7pvav46.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255730 Archived-At: --000000000000e2b6a705f4be68c6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 15, 2023 at 1:58 PM Eli Zaretskii wrote: > > From: Chinmay Dalal > > Date: Mon, 13 Feb 2023 21:05:12 +0530 > > > > > > From the discussion on github > > https://github.com/joaotavora/eglot/discussions/963 > > > > > The default version would be a hoverable symbol that shows something > in the echo area when you mouse hover over it. > > > > > > > Let's continue in the bug tracker discussion initiated by your bug > report. > > > As far as I understand, inlay hints will show the type of many visibl= e > expressions at once, so it's different from the "hover" scenario. > > > > Yes, so it is impossible to use mouse hover for this as you can only > > hover on one thing at once, right? > Yes. I haven't looked at your code, but my expectation is for inlay hints to activate either on a timer after each change, or by the explicit request of the user via a keybinding. It simply doesn't make sense to use mouse hover for this because the hover mechanic is for a single text and inlay hints are about overlaying multiple pieces of information in multiple locations of the buffer. Jo=C3=A3o, could you please look into this? > Hi Eli, this is about the "inlay hints" feature. It's on the radar, but I don't have time in the very near future to handle this. I seem to recall that recently you voiced some opinion in another bug report that this feature could be handled by a separate library instead of a custom Eglot-only implementation. This could be quite reasonable -- or it could be overkill/overengeering. Only a look at the pros and cons of this implementation can tell that, and I haven't had time, sorry. Anyway, if there is indeed a separate discussion for this, then the two discussions should be merged. Be sure to keep me in the loop if you can as I am overwhelmed with other activies in the moment and am not scanning the bug-tracker, or even emacs-devel, for Eglot-related emails at the moment. Jo=C3=A3o --000000000000e2b6a705f4be68c6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Feb 15, 2023 at 1:58 PM Eli Zaret= skii <eliz@gnu.org> wrote:
> From: Chinmay Dalal <dalal.chinmay.0101@gmail.com>
> Date: Mon, 13 Feb 2023 21:05:12 +0530
>
>
> From the discussion on github
> https://github.com/joaotavora/eglot/discussi= ons/963
>
> > The default version would be a hoverable symbol that shows someth= ing in the echo area when you mouse hover over it.
>
>
> > Let's continue in the bug tracker discussion initiated by you= r bug report.
> > As far as I understand, inlay hints will show the type of many vi= sible expressions at once, so it's different from the "hover"= scenario.
>
> Yes, so it is impossible to use mouse hover for this as you can only > hover on one thing at once, right?

Yes.=C2=A0 I haven't=C2=A0 looked at your code, but my expectation is = for inlay hints to
activate either on a timer after each change, = or by the explicit request of
the user via a keybinding.

It simply doesn't make sense to use mouse hover for th= is because the
hover mechanic is for a single text and inlay hint= s are about overlaying
multiple pieces of information in multiple= locations of the buffer.

Jo=C3=A3o, could you please look into this?

Hi Eli, this is about the "i= nlay hints" feature.=C2=A0

It's on th= e radar, but I don't have time in the very near future
to han= dle this.

I seem to recall that recently you voice= d some opinion in another
bug report that this feature could be h= andled by a separate library
instead of a custom Eglot-only imple= mentation.=C2=A0 This could be=C2=A0
quite reasonable -- or it co= uld=C2=A0 be overkill/overengeering.=C2=A0 Only a look=C2=A0
at t= he pros and cons of this implementation can tell that, and I haven't
had time, sorry.

Anyway, if there is indee= d a separate discussion for this, then the=C2=A0
two discussions = should be merged.=C2=A0 Be sure to keep me in the loop
if you can= as I am overwhelmed with other activies=C2=A0in the moment=C2=A0
and am not scanning the bug-tracker, or even emacs-devel, for=C2=A0
<= div>Eglot-related emails at the moment.

Jo=C3=A3o<= /div>
--000000000000e2b6a705f4be68c6--