From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#32243: 26.1; eldoc takes priority over flymake-diagnostics Date: Sat, 22 Aug 2020 17:05:43 +0100 Message-ID: References: <87r1ryk9jq.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000030e66405ad7987f5" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14483"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 32243@debbugs.gnu.org, Dmitry Gutov To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 22 18:07:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k9W2u-0003cl-AN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Aug 2020 18:07:08 +0200 Original-Received: from localhost ([::1]:58686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9W2t-0007F2-A7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Aug 2020 12:07:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9W2n-0007Ei-WD for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2020 12:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k9W2n-0008C3-NC for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2020 12:07:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k9W2n-0006ko-II for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2020 12:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Aug 2020 16:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32243 X-GNU-PR-Package: emacs Original-Received: via spool by 32243-submit@debbugs.gnu.org id=B32243.159811236225896 (code B ref 32243); Sat, 22 Aug 2020 16:07:01 +0000 Original-Received: (at 32243) by debbugs.gnu.org; 22 Aug 2020 16:06:02 +0000 Original-Received: from localhost ([127.0.0.1]:51138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9W1q-0006jb-Aj for submit@debbugs.gnu.org; Sat, 22 Aug 2020 12:06:02 -0400 Original-Received: from mail-wr1-f68.google.com ([209.85.221.68]:44539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9W1o-0006j0-5H for 32243@debbugs.gnu.org; Sat, 22 Aug 2020 12:06:01 -0400 Original-Received: by mail-wr1-f68.google.com with SMTP id c15so4599657wrs.11 for <32243@debbugs.gnu.org>; Sat, 22 Aug 2020 09:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VzjH44fzuN8pPEmTkCtEuoLuggSLTNmn3MtuTfwc4FE=; b=QUiyur2JeIqwV7v8dgfnEQsVXobAPcCMjKXSoL6A5A6QUFn7ZBFtzs6cEgjweKFXxA cnswzVicVF0RrHyj+RbYNl07OKXN9lcc9utgWDbNk91PxpAOfanyJf3rNlFFXJKxXan6 Cfz+WaxQLgRAzRG4SZ0SHMjewBQVp1fAnXjjIn5zf7ArHZdpqx7pXoF5eEHc/DNxkmgV kB204E7Kd5swr4Tiv/rKKMRiZSSB/5Klm1ckix7foZo2FEcoxKGtKI2SLCY3JBZF+GlV Bjswra1VP7i0NIanDJyZEawYzsAwUpivoTcf0+wFrnL/gQf65WHZE8ZfY6e4ieyD+A7Z H4Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VzjH44fzuN8pPEmTkCtEuoLuggSLTNmn3MtuTfwc4FE=; b=QPuysvx3OciIm3YykdCXubadWhFVXXpmgnruANzpGnHWuNJufJbWCkd2CCCp7PdXU5 TvqAC6tJfiUUaJRCA9yQy4z9VogO7LQMcs0s9URKwU1BOYu6WwwtAE93rhejBFRRUXpa yci+JRf4iEEa/pcein4iccf6jA2SGHz06g+RRSRZ71LZ0V77PWjonA1qEOu+omX4VWFs apliYnFb12DSyjBN4Cl86wfdXu7TGubwt5v0rKtH6No8JX0Tg9m9eCpcFosnap4cxutj gIF7xzn2PTNDL+ZbE9KJwuSD2EN6hERrDopumPu/uwCk+QXnCIdBUhd74f9zOJblS7OP /jbQ== X-Gm-Message-State: AOAM532yO2C6VtGqPXyBAnmXhsSTjwopjw6Q9vdW83uhe2jzKyjAQzMl dXUpH29IxKuni1GxGK6VYjDooMihVyNhcGMC91w= X-Google-Smtp-Source: ABdhPJwDv3kn5xVo4H08K9LJDOIXd03k18B9Ub2mlG4gNhyr0Q3FN9us3LRKeW79IEoRDaChjrlNINVY/sPqqgTAqfI= X-Received: by 2002:a5d:6047:: with SMTP id j7mr7397796wrt.315.1598112354329; Sat, 22 Aug 2020 09:05:54 -0700 (PDT) In-Reply-To: <87r1ryk9jq.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185967 Archived-At: --00000000000030e66405ad7987f5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Lars Answering your question, the patch should NOT be applied. The situation has now completely changed in master. Actually, the problem is reversed, with flymake diagnostics taking priority over eldoc, which isn't ideal either. Fortunately, the new system allows for these things to be easily configured by the user, and also allows eldoc and flymake messages to coexist. I'll open a new bug describing the current situation soon. Up to you if this one should be closed. If it isn't, I guess I can continue the discussion here. Jo=C3=A3o On Sat, Aug 22, 2020, 16:03 Lars Ingebrigtsen wrote: > Jo=C3=A3o T=C3=A1vora writes: > > > A naive fix for this could be > > [...] > > > which imitates what help-at-pt-maybe-display-does. > > > > It seems to work more or less well in my testing, but not always. > Obviously > > I haven't studied the full impact of this. > > > > Dmitry, do you have any thoughts on this? > > This was two years ago. I've respun the patch; included below. > > Is this something that should be applied or not? > > diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el > index 4825b5c5e6..0bcd04f84a 100644 > --- a/lisp/emacs-lisp/eldoc.el > +++ b/lisp/emacs-lisp/eldoc.el > @@ -300,7 +300,9 @@ eldoc-minibuffer-message > (when (stringp format-string) > (apply #'format-message format-string args))) > (force-mode-line-update))) > - (apply #'message format-string args))) > + (unless (and (current-message) > + (not (string=3D (current-message) "Quit"))) > + (apply #'message format-string args)))) > > (make-obsolete > 'eldoc-message "use `eldoc-documentation-functions' instead." > "eldoc-1.1.0") > > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no > --00000000000030e66405ad7987f5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi, Lars

Answering your question, the patch should NOT be applied.

The situation has now completely = changed in master. Actually, the problem is reversed, with flymake diagnost= ics taking priority over eldoc, which isn't ideal either. Fortunately, = the new system allows for these things to be easily configured by the user,= and also allows eldoc and flymake messages to coexist. I'll open a new= bug describing the current situation soon.

Up to you if this one should be closed. If it isn't= , I guess I can continue the discussion here.

Jo=C3=A3o


On Sat, Aug 22, 2020, 16:03= Lars Ingebrigtsen <larsi@gnus.org= > wrote:
Jo=C3=A3o T=C3=A1vora &= lt;joaotavora@gmail.com> writes:

> A naive fix for this could be

[...]

> which imitates what help-at-pt-maybe-display-does.=C2=A0
>
> It seems to work more or less well in my testing, but not always. Obvi= ously
> I haven't studied the full impact of this.
>
> Dmitry, do you have any thoughts on this?

This was two years ago.=C2=A0 I've respun the patch; included below.
Is this something that should be applied or not?

diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el
index 4825b5c5e6..0bcd04f84a 100644
--- a/lisp/emacs-lisp/eldoc.el
+++ b/lisp/emacs-lisp/eldoc.el
@@ -300,7 +300,9 @@ eldoc-minibuffer-message
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(when (string= p format-string)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(apply= #'format-message format-string args)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(force-mode-line-update)))
-=C2=A0 =C2=A0 (apply #'message format-string args)))
+=C2=A0 =C2=A0 (unless (and (current-message)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(not (string= =3D (current-message) "Quit")))
+=C2=A0 =C2=A0 =C2=A0 (apply #'message format-string args))))

=C2=A0(make-obsolete
=C2=A0 'eldoc-message "use `eldoc-documentation-functions' ins= tead." "eldoc-1.1.0")


--
(domestic pets only, the antidote for overdose, milk.)
=C2=A0 =C2=A0bloggy blog: http://lars.ingebrigtsen.no
--00000000000030e66405ad7987f5--