From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62694: 30.0.50; eglot-tests fails with recent pylsp Date: Sun, 9 Apr 2023 13:41:33 +0100 Message-ID: References: <87sfddibcn.fsf@gmx.de> <87o7o1tfvc.fsf@gmx.de> <87ile5gv0c.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000bbb64705f8e69480" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21840"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62694@debbugs.gnu.org, Michael Albinus To: Basil Contovounesios Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 09 14:42:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plUNI-0005WK-DS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Apr 2023 14:42:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plUMv-0007Ld-A8; Sun, 09 Apr 2023 08:42:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plUMt-0007LC-5w for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 08:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plUMs-0000N4-Oi for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 08:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plUMr-0007KG-QX for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 08:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Apr 2023 12:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62694 X-GNU-PR-Package: emacs Original-Received: via spool by 62694-submit@debbugs.gnu.org id=B62694.168104411528146 (code B ref 62694); Sun, 09 Apr 2023 12:42:01 +0000 Original-Received: (at 62694) by debbugs.gnu.org; 9 Apr 2023 12:41:55 +0000 Original-Received: from localhost ([127.0.0.1]:60350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plUMl-0007Jt-6S for submit@debbugs.gnu.org; Sun, 09 Apr 2023 08:41:55 -0400 Original-Received: from mail-oa1-f52.google.com ([209.85.160.52]:38614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plUMg-0007Jd-SA for 62694@debbugs.gnu.org; Sun, 09 Apr 2023 08:41:54 -0400 Original-Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-18412684c50so6321125fac.5 for <62694@debbugs.gnu.org>; Sun, 09 Apr 2023 05:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681044105; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DIO3geqARrZEElt5tIU1w53CWYWPl4E8b3Hnt6xFOpo=; b=k/xOjtTQ7VPTpYn83nWnSVnEzXYt0GQDgh1tvNy0D57qDe8Jwv2d1b2jkzf81n0gZP tGxLL/TrIXkyX3Lcptb6c+O4vKPvtdvluPEF9KClbJhABRO64zIrI1gnAXZvVHr216Dw MWX22w/pAHRBAaYDoviOWQ1jipMGm8p95ZWs9ni8WalBeI+bJ4p+2ysHZO3smxWDoZ85 U/8CVMZkABlUSpBG0TLei25hTWcKBKyZ4jMYRDx7nrTJioK0l1K2+dcd9F40W+7UDt1n o7xeaOni2VbcvByCTtsuZYr4SaNtD5tH/EqtEZqDBuIVn1Am9LwHa/FaXsHy5KQOs8Zu y01Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681044105; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DIO3geqARrZEElt5tIU1w53CWYWPl4E8b3Hnt6xFOpo=; b=11Jqm69tM8v+5mfuF0MZ7Ty9RkRwVuyIYcOmdGVSG4HnCglHBfSPi6ggnj7dDVboeP +cFczNBgA0aCawQc92ZoGhgtXGMmbvAZCLRfRVZgxrCFwTVj0Y8ZjmGSLLgYyyBWBm5l pkJe3VCmdu9cPPacER0rrUDvVM648JiiycDVqC+xpj5se3vSBLtcCqScW2MfE4WbppyG Bod7fZdPZgXpgll9vcI60ReatsQutu6Zm6rewoeGoe58FdNJ+4qwV4l3ZszFP7WKUloa sGRpLRJJtMlIdg+hgPXZkRMdmFGZjt94jDq8pAWzmMbqhztAzqGcjWIhuUvNRyPn9Wo2 ggZg== X-Gm-Message-State: AAQBX9coSgvxQDabkSgIG8UhcRmqlNb02nSv6N3vp+tPt0+khOaYSaFU Zu11/Dk6pVSe68Bz0P+mSGnghUHHreFUa5LFdxQ= X-Google-Smtp-Source: AKy350a6xbyuzBF+E0x6IuD1pCFo376M2+AgLPN77FzpIN/uaECHwayERvscia6yUHX081zAlL+b+GjL94xfXxOBxTk= X-Received: by 2002:a05:6870:e392:b0:183:fa09:d20b with SMTP id x18-20020a056870e39200b00183fa09d20bmr3545312oad.5.1681044105048; Sun, 09 Apr 2023 05:41:45 -0700 (PDT) In-Reply-To: <87ile5gv0c.fsf@tcd.ie> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259519 Archived-At: --000000000000bbb64705f8e69480 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Apr 9, 2023, 12:22 Basil Contovounesios wrote: > Jo=C3=A3o T=C3=A1vora [2023-04-06 13:49 +0100] wrote: > > > On Thu, Apr 6, 2023, 12:22 Michael Albinus > wrote: > > > >> > Instead of using your distribution package manager, I recommend > >> > installing pylsp via the official Python package manager, pip, and > >> > doing it like so: > >> > > >> > pip install "python-lsp-server[all]" > > IME this may not be sufficient to get the latest version of pylsp's > dependencies, such as autopep8, which I presume is the component > responsible for the differences in formatting across development > environments. > > IOW it may be necessary to explicitly 'pip install -U autopep8'. > If that were true, GitHub CI would be failing, since it used this command, and it's not. Tests run on my laptop and I've never run that command, just the one I suggested. >> I disagree. Running regression tests towards bleeding edge development > >> version of pylsp is not the intention. You cannot expect, that everybo= dy > >> running Emacs tests has installed pylsp like this. But she could have > >> installed the Debian pylsp package. > > > > Sure, or she has a 'pylsp' that prints the complete works of > > Shakespeare. But these tests are designed for the number one > > recommended pylsp installation method. It's AFAIK not the > > "bleeding edge" (which would be a Git installation). And tests > > have been running fine with that installation method for a > > number of months now, maybe even years. > > FWIW the autopep failure in bug#61637 was with latest pip-installed > pylsp and autopep8, and the patch in that report worked around it by > accepting one of a number of possible formattings. > > A version check for autopep8 (rather than pylsp) may have been an > alternative solution Who knows? Did you try it? If it works i would have been happy to accept it Noone proposed it. Instead, some truly vague and complex vapourware things were proposed. --000000000000bbb64705f8e69480 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Apr 9, 2023, 12:22 Basil Contovounesios <contovob@tcd.ie> wrote:
Jo=C3=A3o T=C3=A1vora [2023-04-06 13:49 +0100] wrote:<= br>
> On Thu, Apr 6, 2023, 12:22 Michael Albinus <michael.albinus@gmx= .de> wrote:
>
>> > Instead of using your distribution package manager, I recomme= nd
>> > installing pylsp via the official Python package manager, pip= , and
>> > doing it like so:
>> >
>> > pip install "python-lsp-server[all]"

IME this may not be sufficient to get the latest version of pylsp's
dependencies, such as autopep8, which I presume is the component
responsible for the differences in formatting across development
environments.

IOW it may be necessary to explicitly 'pip install -U autopep8'.

If = that were true, GitHub CI would be failing, since it used this command, and= it's not. Tests run on my laptop and I've never run that command, = just the one I suggested.


>> I disagree. Running regression tests towards bleeding edge develop= ment
>> version of pylsp is not the intention. You cannot expect, that eve= rybody
>> running Emacs tests has installed pylsp like this. But she could h= ave
>> installed the Debian pylsp package.
>
> Sure, or she has a 'pylsp' that prints the complete works of > Shakespeare. But these tests are designed for the number one
> recommended pylsp installation method. It's AFAIK not the
> "bleeding edge" (which would be a Git installation). And tes= ts
> have been running fine with that installation method for a
> number of months now, maybe even years.

FWIW the autopep failure in bug#61637 was with latest pip-installed
pylsp and autopep8, and the patch in that report worked around it by
accepting one of a number of possible formattings.

A version check for autopep8 (rather than pylsp) may have been an
alternative solution

Who knows? Did you try it? If it works i would have been ha= ppy to accept it=C2=A0 Noone proposed it. Instead, some truly vague and com= plex vapourware things were proposed.

=

--000000000000bbb64705f8e69480--