From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Mon, 20 Jan 2020 14:58:08 +0000 Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="9654"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 38992@debbugs.gnu.org, waah@yellowfrog.io, Stefan Monnier To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 20 15:59:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1itYWM-0002LQ-DD for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jan 2020 15:59:18 +0100 Original-Received: from localhost ([::1]:38170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itYWL-0001Rp-A4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jan 2020 09:59:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45615) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itYWA-0001RZ-8K for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 09:59:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itYW6-0002M9-33 for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 09:59:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39839) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1itYW6-0002M4-09 for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 09:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1itYW6-0006tF-0U for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 09:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jan 2020 14:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157953231626452 (code B ref 38992); Mon, 20 Jan 2020 14:59:01 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 20 Jan 2020 14:58:36 +0000 Original-Received: from localhost ([127.0.0.1]:45812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itYVb-0006sV-Vn for submit@debbugs.gnu.org; Mon, 20 Jan 2020 09:58:36 -0500 Original-Received: from mail-io1-f52.google.com ([209.85.166.52]:39265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itYVW-0006sD-JE for 38992@debbugs.gnu.org; Mon, 20 Jan 2020 09:58:31 -0500 Original-Received: by mail-io1-f52.google.com with SMTP id c16so33942245ioh.6 for <38992@debbugs.gnu.org>; Mon, 20 Jan 2020 06:58:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1c8/8Genzsfv8JFSCOdA13G7dpXpp0Uv7qOblP5Gi6I=; b=LTOPMW1hJbRSe25BMj69nuFy2RSlA5KCWil6eyRftbDcuqXKQIO2+IItBLLU6Jnz83 RWrKsJzSm8vSuum1S4pmo8cxxC0ysRToLhb2QurIDJBC7Ux8b2y1QmNZizWsERhAlBKM PNtWzQ2HwtcmAiqmTJRqTD0Ed7nBk3kQxpFMSzTwmxBpKdCS+Sz0H+UcNnWkbLY6Z3i1 qod5WM5jQH7gyAy6jxHM3ztkNMe+2InhI7S11p3qs2vXuVUR/roChVwBFNwCPJLPx+vw 8rVIIj75OSEBAfV2gLRzUu0ega+b0Y+Ioundl+yfV5IskofWtIsGjtpJoa+RzIMeFRrj 70tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1c8/8Genzsfv8JFSCOdA13G7dpXpp0Uv7qOblP5Gi6I=; b=mVHnaqbiHon0INHP+wafavuoxdExsxAT0NYpY4y33buWzb9nkiFgZmDpdhD8k1PHJQ 3YHBScvQg/lp9C50y0IcH8tjF83acbleuzOOz00S2wwmanAPfMHvyNcKbUOqyx/fq9aA wHOSF2wQiJqPNxp64ufvk9ha1M8heIYB6d76kQGNXKlSKmZDSjkWbcGlOHGFOfsIoghP cBQvS8djXf8PoOZ2J7N1IzsRk4QnvDOwYfp1K9AR4RTLlSnGxVcmOKeEQqkbp7RBEijT ddgwqv3rUGKD+xnQjCCEV9nzusVtgwmWjj+Cs44Ir5IoATOAFwtkzGSDNO43AthKQ/aN 1Xqg== X-Gm-Message-State: APjAAAWupPCQ9Sp9YEweTgzm6B/SmtwSrA0pfQMikZhRPFN3c8eZb8Mt FTQ/Ivg5IMuMtc4b7Ywwzv0c+WrqbrDq1aWbLhE= X-Google-Smtp-Source: APXvYqzBpgeaNTGyO9s9w1Fu1G+feWyHxN0vG34z+qUxoSVzH+76tCklsEX8yKIsae33n5XEX+w2sZacB6r2T8SurY4= X-Received: by 2002:a5d:9f05:: with SMTP id q5mr41961769iot.199.1579532300846; Mon, 20 Jan 2020 06:58:20 -0800 (PST) In-Reply-To: <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174921 Archived-At: On Mon, Jan 20, 2020 at 2:54 PM Dmitry Gutov wrote: > > On 19.01.2020 16:00, Jo=C3=A3o T=C3=A1vora wrote: > > The second option looks pretty good, so you can just push that at will, > > if no other objections. > > I'm not very familiar with the code. Do we really need the > minibuffer-force-complete call there? I commented it out and can't see > the difference. I can't tell right now. But do you need to remove it to add the message or is this a refactoring that you are thinking about? Maybe do both changes separately so that either can be reverted individually? Or are they somehow connected? > > Incidentally, I would also think it reasonable to > > provide the same help text if there is a single partial match. > Makes sense, but that sounds a bit more complicated. We don't show any > message in this case now, do we? I *think* the "[Matched]" message is shown. Jo=C3=A3o