From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, Richard Copley <rcopley@gmail.com>
Cc: arash@gnu.org, arstoffel@gmail.com,
Danny Freeman <danny@dfreeman.email>,
59338@debbugs.gnu.org
Subject: bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows
Date: Wed, 23 Nov 2022 12:51:37 +0000 [thread overview]
Message-ID: <CALDnm50c1caTEwgiE18pT=c81D8wQHsNXehFm22inv+4r+natA@mail.gmail.com> (raw)
In-Reply-To: <83edu0d9dg.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2385 bytes --]
I just found out this bug was ongoing.
Eli, if you're proposing to fix url-parse.el to not be fooled by windows
file names, then I support that idea, and I think it's the correct
thing to do.
But.... we still need the eglot.el kludge installed because url-parse.el
is not distributed as an ELPA package and Eglot is. So users of
Emacs < 29 would not receive the fix and would have their
WIndows Eglot broken.
João
On Fri, Nov 18, 2022 at 7:13 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Danny Freeman <danny@dfreeman.email>
> > Cc: Eli Zaretskii <eliz@gnu.org>, Arash Esbati <arash@gnu.org>,
> > 59338@debbugs.gnu.org, bug-gnu-emacs@gnu.org
> > Date: Thu, 17 Nov 2022 17:27:40 -0500
> >
> > Is there something we can do to detect a windows path
>
> You mean, a Windows-style file name? You can detect that, but it is
> easier to test system-type instead: these file names cannot happen on
> any system except Windows, and if they do happen, they don't have the
> same semantics (i.e., "d:/foo/bar" is NOT an absolute file name on
> Posix systems).
>
> Or maybe I don't understand the purpose of the test you have in mind?
>
> > and continue treating it as a path like we were before this change?
>
> I'd advise against such kludges. If a function wants a file:// URL,
> it should receive a valid file:// URL on all systems, and it should be
> capable of handling file:// URLs on MS-Windows as well as on Posix
> systems. Likewise with functions which produce file:// URLs. Letting
> local file names into this is a clear path to future bugs, because
> many people will not realize this subtlety, and will think they deal
> with file:// URLs on all platforms.
>
> > If there is no function available already, it may be enough to check if
> > the return value of `url-type` is not 1 character. Looking at this list
> > of what I believe are official URI schemes, all of them have at least
> > two characters:
> > https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml
>
> But hosts can have 1-character names (although that is unlikely).
>
> Anyway, I'm against such kludges, especially since we don't need them
> here. We just need to make our functions that handle file:// URLs to
> be capable of supporting file:// on MS-Windows. It is not hard to do,
> so let's do that.
>
>
>
>
--
João Távora
[-- Attachment #2: Type: text/html, Size: 3393 bytes --]
next prev parent reply other threads:[~2022-11-23 12:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 16:51 bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows Arash Esbati
2022-11-17 17:06 ` Eli Zaretskii
2022-11-17 17:18 ` Augusto Stoffel
2022-11-17 22:27 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-17 23:12 ` Augusto Stoffel
2022-11-18 7:14 ` Eli Zaretskii
2022-11-18 13:39 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-18 14:35 ` Eli Zaretskii
2022-11-18 14:55 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-18 20:01 ` Arash Esbati
2022-11-18 7:12 ` Eli Zaretskii
2022-11-23 12:51 ` João Távora [this message]
2022-11-24 13:42 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-24 15:27 ` João Távora
2022-11-17 22:33 ` Arash Esbati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm50c1caTEwgiE18pT=c81D8wQHsNXehFm22inv+4r+natA@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=59338@debbugs.gnu.org \
--cc=arash@gnu.org \
--cc=arstoffel@gmail.com \
--cc=danny@dfreeman.email \
--cc=eliz@gnu.org \
--cc=rcopley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).