From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot Date: Wed, 12 Apr 2023 12:35:23 +0100 Message-ID: References: <87a5zj2vfo.fsf@gmail.com> <87wn2modrm.fsf@posteo.net> <87ile6o2ov.fsf@posteo.net> <87y1mz38rl.fsf@posteo.net> <87ile2n0kn.fsf@gmail.com> <83v8i2abqi.fsf@gnu.org> <87wn2ilgx7.fsf@gmail.com> <83a5ze9uc1.fsf@gnu.org> <831qkq9rpy.fsf@gnu.org> <83pm898xb9.fsf@gnu.org> <87h6tlleg0.fsf@gmail.com> <8335558qc7.fsf@gnu.org> <83sfd5761f.fsf@gnu.org> <87zg7djrgr.fsf@gmail.com> <83o7nt73za.fsf@gnu.org> <83mt3d73c2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35140"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 62720@debbugs.gnu.org, philipk@posteo.net, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 12 13:36:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmYm2-0008xD-50 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Apr 2023 13:36:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmYli-0001Qq-M5; Wed, 12 Apr 2023 07:36:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmYlg-0001Nh-OQ for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 07:36:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmYle-00010P-C1 for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 07:36:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pmYld-0005qb-Nk for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 07:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Apr 2023 11:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62720 X-GNU-PR-Package: emacs Original-Received: via spool by 62720-submit@debbugs.gnu.org id=B62720.168129934422453 (code B ref 62720); Wed, 12 Apr 2023 11:36:01 +0000 Original-Received: (at 62720) by debbugs.gnu.org; 12 Apr 2023 11:35:44 +0000 Original-Received: from localhost ([127.0.0.1]:39212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmYlL-0005q5-Op for submit@debbugs.gnu.org; Wed, 12 Apr 2023 07:35:44 -0400 Original-Received: from mail-oa1-f48.google.com ([209.85.160.48]:38777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmYlI-0005pq-FU for 62720@debbugs.gnu.org; Wed, 12 Apr 2023 07:35:41 -0400 Original-Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-184518754bfso9769657fac.5 for <62720@debbugs.gnu.org>; Wed, 12 Apr 2023 04:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681299334; x=1683891334; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9tUaYAkdahc3apC135W33EKc26iOjbY0JDeHZ1MBuuU=; b=ewEJhG/z3tSMsZlb/anSLIOazYpEODbtygiF6PxgAP5be10TDyO+9/h0gaFz8lUFrO 76KE2PApRfE+7WF3fOoxNpjNhXyi+Bkq7dywhMjqLxkq0ySGq0D2kchtnMG/D5ke4BCA aA3zzpABd/xEbkvQzCzmaoGsSZ6BLCUPBXET1WkTEdIUiW0saWFiIuJTxVDEHiID2VOX 71anP5gpEevwYwFwOSabnmGC4i3yESWn1Ru6NXr+FPcDFbSdbhfk49y9a4WDFubJ5M6K u2W9HJqwazLPHQfmRnVQTgUWXWNm8YgSVgfrLV7lSarHKTdVDNyHw/sB3j+4HnCW1Ec6 cl3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681299334; x=1683891334; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9tUaYAkdahc3apC135W33EKc26iOjbY0JDeHZ1MBuuU=; b=wD3HdmrH1G+MR24d+tGS+E5xMlgacr+HincjVk8zZTYfo7EpDvV+YdY60DJgYZpySw gx1GqowpqKa8nLYz01SualiGOF8y4rDjdvbGGOIrHiH8RoKcAqL13MOsp8/JyEOMb2uf 9zJyvNVcESa2lLqLxFx9ev4HwCGg9nr7tymd7dw/rG7c0XIIRyI1NKOtAgmjr+bRN43f YVQMJX3xxsHkD66bVBaPdRLq1vc3ntrI0HiaWyvNjySxG0HzO+QaqK9kk5pUi7exfUHZ Jjr3qccX7kImma4XhIpQ/SROjnfSTQ2q+u7YeNmHHvfXHngnXgyiz1rypObVdZH4X0P3 DlMQ== X-Gm-Message-State: AAQBX9dxtu6Cg57BEm2AyFd9972UJ7w5H2fRCxW339JvHcsblaNxLvGu EUVtVkWpuuHEOu0coPLckZ2WKWSXRLhF9zj6o2w= X-Google-Smtp-Source: AKy350Zr5Eb8fHkhSKiSpjemb8rDMTdMGmmTGOK+dF3E8X+LxUstIma+Ohk998fjjvCcDO5nz0oM+WMNem55OBA8bss= X-Received: by 2002:a05:6870:c18f:b0:17f:2918:2f46 with SMTP id h15-20020a056870c18f00b0017f29182f46mr7851112oad.5.1681299334651; Wed, 12 Apr 2023 04:35:34 -0700 (PDT) In-Reply-To: <83mt3d73c2.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259727 Archived-At: On Wed, Apr 12, 2023 at 12:21=E2=80=AFPM Eli Zaretskii wrote= : > > > From: Jo=C3=A3o T=C3=A1vora > > Date: Wed, 12 Apr 2023 12:15:11 +0100 > > Cc: philipk@posteo.net, monnier@iro.umontreal.ca, 62720@debbugs.gnu.org= , > > larsi@gnus.org > > > > > This has the same problem: it modifies a function that is called in > > > too many places. package-installed-p has half a dozen callers in > > > package.el alone. The change is tiny, but what about its > > > implications on every use case where it is involved? > > > > What about them? I volunteer to help test whichever cases you (or > > anyone else) think may be problematic. > > We will never be able to reveal them all, let alone test them, before > Emacs 29.1 is released. Were there even :core packages back in 2015 when this package-install safeguard was added in package-installed-p? I haven't checked, but I think not. I think this is just a plain oversight in an irregularly maintained library, if I've ever seen one. Why not just fix it? The other use cases of package-installed-p you mention pass a package-desc structure, and there this safeguard doesn't even exist (see the docstring). > > Can we put this tiny patch on master then? > > Yes, if Philip and Stefan don't object. But, since there will be a > command for updating core packages, doesn't this go against your > desire not to change the UX? IMO The user experience is bad/broken. So at least I want to change it, if minimally. That's what any bug report is about, to change UX for the better. Here, to let people not to have to go through odd hoops big or small to install packages or know if something is built-in/core or not. Jo=C3=A3o