From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#69605: [PATCH] Query Eglot version via package.el Date: Fri, 3 May 2024 12:54:05 +0100 Message-ID: References: <87y1auo0nw.fsf@posteo.net> <87seyz73bs.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000001ed8cc06178b61df" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19870"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69605@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 03 13:55:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2rVT-0004tc-AC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 May 2024 13:55:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2rUv-00081U-6D; Fri, 03 May 2024 07:54:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2rUu-00081G-BX for bug-gnu-emacs@gnu.org; Fri, 03 May 2024 07:54:40 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2rUu-0002VS-3p for bug-gnu-emacs@gnu.org; Fri, 03 May 2024 07:54:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s2rVG-0008RI-2f for bug-gnu-emacs@gnu.org; Fri, 03 May 2024 07:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2024 11:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69605-submit@debbugs.gnu.org id=B69605.171473729032420 (code B ref 69605); Fri, 03 May 2024 11:55:02 +0000 Original-Received: (at 69605) by debbugs.gnu.org; 3 May 2024 11:54:50 +0000 Original-Received: from localhost ([127.0.0.1]:46406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2rV3-0008Qq-Hb for submit@debbugs.gnu.org; Fri, 03 May 2024 07:54:49 -0400 Original-Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:61783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2rV0-0008Qg-J7 for 69605@debbugs.gnu.org; Fri, 03 May 2024 07:54:47 -0400 Original-Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-51f4d2676d1so1874257e87.3 for <69605@debbugs.gnu.org>; Fri, 03 May 2024 04:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714737258; x=1715342058; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jmaLf0JUqoIXDn7k1U70I4w3YYQpCyfwOt4bqwX1rT0=; b=hXicMpsto/pAmFATZ5nuVA8zn6oT0X0ZEtg40pdbaSQRe+hYQRfhzFRQW22yY3jR+T 8YBiVUj2eTBu6k9FtRQBnrVwUy7EkE2jmqfjwiqyT4FXbFy+1BSq71Ihu8ewC/eIl4WN pperV/6xK+Ksti4hs80Hjj1/Ks0gweNRqeNcW2IIL1EPrFps1PwxCVVDZL+O8/vms0dy Ksghp1vjHzaUWglZWpcmSb8HNsLIut3V4Mn5JpnbcuY4cR7D643M7VHJDmY9tqQ0kUok piEULtfniC4lq7x2nrdCCY3zvl0BvvMPQ7eTKU568ynur/sRk5fBVFw7QTLTQJLbzNJl 5gYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714737258; x=1715342058; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jmaLf0JUqoIXDn7k1U70I4w3YYQpCyfwOt4bqwX1rT0=; b=CFv0apiGce/ujZYcy9NJ+ZJ9nWg9m9vb/5NQCdjA2a33bk/n+31RlzIbIcqiE2i9fG 8/z2F0nOoEv1hiN4DQvkXrQQhsoXug/DzI7aYhH2oQLpV26YIBrxJIqFtDfh6XmTzwId Quy+JW9+9tkNW2qBYzSr07l0QeHHpWPWFl1P+owDLesYaDqk3E8kiZZd7MhDMrHvDp/P I6B0bF7G8aLXr5nvCSJHN96ZEAWBu/E22zacJTYKYTnL1l2+FyXVi+6GiG33bdVVknYM wN4rbghHVIzmRE4TfUdz0allxxEkEUnQqXfrEd5XbzpEZn7F7Ku4mVAiXgAiNQub0FkM 58cQ== X-Gm-Message-State: AOJu0Yy6odOXL45lgJEfL25M23igPbbL5za5J2bJAJ5I3ERV6UTrEtuF vz/DX6Utc27+R2tykATmsB7+XiMJK4tMcOxJKDipEUo5iVHExuz9cgdzZit8oTHcl2u9Z52ajbW qZa4x73yG9Z3qL9M1De3wEi1PxvY= X-Google-Smtp-Source: AGHT+IEhvW4wC542mcmUiXL+N6nkVgkzJuLwFC9SvHSGums/sTbubWLHrzJiSEG8eoyzNqpn2qC504rIV9zrWEib8Cw= X-Received: by 2002:ac2:4895:0:b0:51b:214c:5239 with SMTP id x21-20020ac24895000000b0051b214c5239mr1656908lfc.62.1714737257565; Fri, 03 May 2024 04:54:17 -0700 (PDT) In-Reply-To: <87seyz73bs.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284379 Archived-At: --0000000000001ed8cc06178b61df Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, May 3, 2024 at 8:38=E2=80=AFAM Philip Kaludercic wrote: > Ping? > Patch looks good to me, I'm generally in favour of things that replace Eglot-rolled facilities with standard ones. But I haven't tested it. What will `package-get-version` say of a master build of Emacs where lisp/progmodes/eglot.el has changes that haven't been published to GNU Elpa yet? Does it even matter? Anyway, I think the change is safe to install, just please make sure it doesn't trip the GitHub CI (it shouldn't). Jo=C3=A3o --0000000000001ed8cc06178b61df Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, May 3, 2024 at 8:38=E2=80=AFAM Philip Kaludercic <= philipk@posteo.net> wrote:
Ping?
=C2=A0
Patch looks good= to me, I'm generally in favour of things that replace
Eglot-= rolled facilities with standard ones.

But I haven&= #39;t tested it.=C2=A0 What will `package-get-version` say of a master
build of Emacs where lisp/progmodes/eglot.el has changes that haven&#= 39;t
been published to GNU Elpa yet?=C2=A0 Does it even matter?

Anyway, I think the change is safe to install, just= please make sure it=C2=A0
doesn't trip the=C2=A0GitHub CI (it shouldn't).

=
Jo= =C3=A3o
--0000000000001ed8cc06178b61df--