From: "João Távora" <joaotavora@gmail.com>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 69605@debbugs.gnu.org
Subject: bug#69605: [PATCH] Query Eglot version via package.el
Date: Fri, 3 May 2024 12:54:05 +0100 [thread overview]
Message-ID: <CALDnm50WSUcUu3E+Senz0yRiedq6nFVdCMgZba2WamdwFZkSHw@mail.gmail.com> (raw)
In-Reply-To: <87seyz73bs.fsf@posteo.net>
[-- Attachment #1: Type: text/plain, Size: 544 bytes --]
On Fri, May 3, 2024 at 8:38 AM Philip Kaludercic <philipk@posteo.net> wrote:
> Ping?
>
Patch looks good to me, I'm generally in favour of things that replace
Eglot-rolled facilities with standard ones.
But I haven't tested it. What will `package-get-version` say of a master
build of Emacs where lisp/progmodes/eglot.el has changes that haven't
been published to GNU Elpa yet? Does it even matter?
Anyway, I think the change is safe to install, just please make sure it
doesn't trip the GitHub CI (it shouldn't).
João
[-- Attachment #2: Type: text/html, Size: 1183 bytes --]
next prev parent reply other threads:[~2024-05-03 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 9:23 bug#69605: [PATCH] Query Eglot version via package.el Philip Kaludercic
2024-05-03 7:38 ` Philip Kaludercic
2024-05-03 11:54 ` João Távora [this message]
2024-05-03 18:13 ` Philip Kaludercic
2024-05-18 22:27 ` Stefan Kangas
2024-05-18 22:30 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm50WSUcUu3E+Senz0yRiedq6nFVdCMgZba2WamdwFZkSHw@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=69605@debbugs.gnu.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).