From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#59929: [PATCH]: Eglot, request progress notification on server init Date: Sat, 25 Mar 2023 19:15:29 +0000 Message-ID: References: <87y1rgtk78.fsf@dfreeman.email> <87k030tf4t.fsf@dfreeman.email> <87fs9s7iiq.fsf@dfreeman.email> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14113"; mail-complaints-to="usenet@ciao.gmane.io" To: Danny Freeman , 59929-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 25 20:14:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg9LI-0003Re-ES for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Mar 2023 20:14:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pg9L2-0003qo-Ez; Sat, 25 Mar 2023 15:14:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg9L1-0003qQ-3y for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 15:14:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pg9L0-0005ae-Qj for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 15:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pg9L0-000251-Bu for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 15:14:02 -0400 Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59929 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 59929@debbugs.gnu.org, joaotavora@gmail.com, danny@dfreeman.email Original-Received: via spool by 59929-done@debbugs.gnu.org id=D59929.16797716257957 (code D ref 59929); Sat, 25 Mar 2023 19:14:02 +0000 Original-Received: (at 59929-done) by debbugs.gnu.org; 25 Mar 2023 19:13:45 +0000 Original-Received: from localhost ([127.0.0.1]:43513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg9Ki-00024F-Jr for submit@debbugs.gnu.org; Sat, 25 Mar 2023 15:13:44 -0400 Original-Received: from mail-oi1-f170.google.com ([209.85.167.170]:35491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg9Kg-00023z-M4 for 59929-done@debbugs.gnu.org; Sat, 25 Mar 2023 15:13:43 -0400 Original-Received: by mail-oi1-f170.google.com with SMTP id s8so3634657ois.2 for <59929-done@debbugs.gnu.org>; Sat, 25 Mar 2023 12:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679771617; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=by5M0R54r0bdrrecdMGGR/t42uvgtk7+k1NFH/mObMo=; b=BiwKUV/dv2pACbaaYuKsATHu2QG054LXwayR3hFHg2n67tstW1QEp7HJsm1Per3ulP n5XkWCAGkT437nI6PfBPUcRjW+QWJt9nCHdy1ejLEfndbVHMZIe49swhvhE2Dphwl1mY pa1SqjpJiDfkj4+aS0KEfukw79nC66hl/7Jtn5qiWNvZTILoGHTCQMsGzF7hY21CHcwU Gfp7Hlu9ZlWhk0A+A57A4SvS05nR3d39GNFceZ/g02e6ZFIdQ/8DvDDjVAVgRoulizJy y6QskdLE8uV6ORX/RMGn8IYyZ9jXfOZ/0wI/L063WI9MeWl/Y8uq3nUXog2MsCFTJD9P v4pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679771617; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=by5M0R54r0bdrrecdMGGR/t42uvgtk7+k1NFH/mObMo=; b=IdqXuECeZe1QkAHgdfY7l6XBVG2cJjI/FHeQdrPjbYvc5tjJb4IvZjqKmluZPtA7wa I2QuuS8Glf1H7BewVP+ZnERaS2lZiDH+wWfQJekcGA0ku3uVeisCYL/GCKv0AtIRzmjW UigzpXl9xo8/QVyA68NNYsqeZCa8MBImOllRLkStzwv4jpKfFj5Ljv5kRgOE46xHwYwe /Qsy90XaJORx/+qC6bVa8CbjPD5caa/tSHIETqa1JqPfHUM9168/YhFOnJ6XvxTR8ZyV zqyasEFK9pJj40gRl6FjUgLjlEHFtOYzA8ObI0X4lKyyvW9P0SDFE1VD5mO7dFuStJcW L1Ow== X-Gm-Message-State: AO0yUKUT0Cwcj8BSWXWiHbt5sB26ALR9lsnZd2O6bih2NUiQBOg6UVJG noJb3+6aAVAPwWY7Zz40EJffx8wm+wIZNfoEQuWbqA7b X-Google-Smtp-Source: AK7set8WdTHsZe/LIqJqhqiq6FmP2/1JH1QsRsQjcRUfR7HxvqwNgDyS+XqNHhlJcLj+KzSvoId76OSfAYuHLN/L9ZA= X-Received: by 2002:aca:240d:0:b0:386:9b6f:f300 with SMTP id n13-20020aca240d000000b003869b6ff300mr1922807oic.5.1679771616893; Sat, 25 Mar 2023 12:13:36 -0700 (PDT) In-Reply-To: <87fs9s7iiq.fsf@dfreeman.email> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258619 Archived-At: On Sat, Mar 25, 2023 at 7:12=E2=80=AFPM Danny Freeman wrote: > > > Danny Freeman writes: > > > Another patch for consideration related to the first in this thread, > > I've confirmed that clients can signal to servers that they are willing > > to accept server initiated progress notifications with the client > > capability in the attached patch. > > > > Note: there is still no server capability for this that can be ignored, > > and the `eglot-report-progress` defcustom remains relevant here. Any > > server initiated progress report will be ignored if > > `eglot-report-progress` is `nil`. > > > > Server will send a `window/workDoneProgress/create` request, but nothin= g > > needs to be done with it. That request will be followed by the already > > implemented $/progress notifications. > > > > I need to find a server that I can test this with before this patch is > > applied. I will report back in this thread once I've done that. > > I think this bug can be closed. It is old and I lost track of it, but > some recent commits in Emacs I think addressed this > > - 82523dc621ace104d8f379509a436fcb03c48c26 > - 47d8e4b0d3835f5e0b0b6ab76f242ef0aa25bda7 > > Thank you, > Danny Freeman Yes, I think so to. I had lost track of this bug, thanks for reminding me. Jo=C3=A3o