From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#32243: 26.1; eldoc takes priority over flymake-diagnostics Date: Sun, 19 Aug 2018 19:48:22 +0100 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000007c44690573ce3df0" X-Trace: blaine.gmane.org 1534704433 5992 195.159.176.226 (19 Aug 2018 18:47:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 19 Aug 2018 18:47:13 +0000 (UTC) To: 32243@debbugs.gnu.org, Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 19 20:47:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frSjD-0001SV-L5 for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Aug 2018 20:47:07 +0200 Original-Received: from localhost ([::1]:43803 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frSlK-00089d-63 for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Aug 2018 14:49:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frSlD-00089W-BP for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 14:49:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frSl5-00016O-FQ for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 14:49:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49794) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1frSl4-00016A-Fz for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 14:49:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1frSl4-0007yX-8t for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 14:49:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Aug 2018 18:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32243 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32243-submit@debbugs.gnu.org id=B32243.153470452330626 (code B ref 32243); Sun, 19 Aug 2018 18:49:02 +0000 Original-Received: (at 32243) by debbugs.gnu.org; 19 Aug 2018 18:48:43 +0000 Original-Received: from localhost ([127.0.0.1]:54812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frSkk-0007xt-Lg for submit@debbugs.gnu.org; Sun, 19 Aug 2018 14:48:42 -0400 Original-Received: from mail-qk0-f171.google.com ([209.85.220.171]:42477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frSkj-0007xi-Gj for 32243@debbugs.gnu.org; Sun, 19 Aug 2018 14:48:41 -0400 Original-Received: by mail-qk0-f171.google.com with SMTP id p71-v6so4269302qka.9 for <32243@debbugs.gnu.org>; Sun, 19 Aug 2018 11:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=uD85ePuNYzyhAAxVkS/WXE9dgok31bwbKzQbiOe/roM=; b=UuOd8Q43/y5ahK/16vG57XuI705FrHJOz5cAMgxYjOrsP1d8LhVVRmZqdZc1oa47PR ZbJZohUVRp+e4CBSaAAvVUj0Wb1tAX/hKiX5k7AkyYo0HbyjQ//QNLb2sH/RXfzlX2Uq XfpIHkhOrHjn3Avtnz1SoacVDKVD27+WOx394Bc0ErsozMdnDYnOkVjMRWj3e6GuMBtI defnd9cK0EnqumsTB31QY1rlcK4DoLQ7WAG/0vlHIk1zNMAEtkj66JzjHpzDFvqB31zK PZ/KguPwuDquAm7CXMgd7E74FB6a2J/XCVyoYUPitmIu9DHglUlBRdRVq3F1jhW5RALw 6YPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=uD85ePuNYzyhAAxVkS/WXE9dgok31bwbKzQbiOe/roM=; b=LrM2A3J1uiqLxPYpdDV0j2Oo7CvdazCXQ7qAybZyfIKvVUJgvkjBrko31KAPrr0HVM nZe2F+UxXLmcZDu6pm2+KGRrQcg9o/1gNiM9h3Ddg9h8hxd59AdZy+4ag8kOwPXp5WQA LZFWCedURPagtNa2UoazdxDuQvCatH+KZAoSoEMfUpqWcBIXt/OoBAUu4rBDGdEGJCWe FlJEjdSuPkXC68+7bGZlN08FGn3NlUTsmYeGFYwteBv1I19gNfqOSvLoacmqAnOGPIBp JKvOaaMv4TO3TOadA2vZ76ysP1Bc5e0buJx4ATXDkOMfPxkLzxWNGpQqdyLKCmqCe0gw 5qHQ== X-Gm-Message-State: APzg51B17H1Qo2taZDJzhoyO/UbyGsDU0Fttf3hhFa8gctM/bDTM9Jz4 0QHGWFuAN+4WTpn+8MBlbSn/qW3HBXGhVujQwxbbSfr6 X-Google-Smtp-Source: ANB0VdbYTtGPpTzo2W5mR1yR6NE0hOP9P3gcnsHgbwCjnbMVPEosyjCPaUJeFSKbkrwS6VPWkV9uem2pDVAcDGsYDvc= X-Received: by 2002:a37:dc47:: with SMTP id v68-v6mr2094378qki.136.1534704515563; Sun, 19 Aug 2018 11:48:35 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149599 Archived-At: --0000000000007c44690573ce3df0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable A naive fix for this could be diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el index 49ba71fb1b..5fafd066db 100644 --- a/lisp/emacs-lisp/eldoc.el +++ b/lisp/emacs-lisp/eldoc.el @@ -272,7 +272,9 @@ eldoc-minibuffer-message (when (stringp format-string) (apply #'format-message format-string args))) (force-mode-line-update))) - (apply 'message format-string args))) + (unless (and (current-message) + (not (string=3D (current-message) "Quit"))) + (apply 'message format-string args)))) (defun eldoc-message (&optional string) "Display STRING as an ElDoc message if it's non-nil. which imitates what help-at-pt-maybe-display-does. It seems to work more or less well in my testing, but not always. Obviously I haven't studied the full impact of this. Dmitry, do you have any thoughts on this? --=20 Jo=C3=A3o T=C3=A1vora --0000000000007c44690573ce3df0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
A naive fix for this could be

dif= f --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el
index 49ba= 71fb1b..5fafd066db 100644
--- a/lisp/emacs-lisp/eldoc.el
+++ b/lisp/e= macs-lisp/eldoc.el
@@ -272,7 +272,9 @@ eldoc-minibuffer-message
=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (when (stringp format-string)
=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (apply #'format-message format-string args)))
=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (force-mode-line-update= )))
-=C2=A0=C2=A0=C2=A0 (apply 'message format-string args)))
+= =C2=A0=C2=A0=C2=A0 (unless (and (current-message)
+=C2=A0=C2=A0=C2=A0 = =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (not (string=3D (current-m= essage) "Quit")))
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (apply '= message format-string args))))
=C2=A0
=C2=A0(defun eldoc-message (&am= p;optional string)
=C2=A0=C2=A0 "Display STRING as an ElDoc message= if it's non-nil.

which imitates what help-at-pt= -maybe-display-does.=C2=A0

It seems to work m= ore or less well in my testing, but not always. Obviously
I = haven't studied the full impact of this.

Dmitr= y, do you have any thoughts on this?

--
Jo=C3=A3o T=C3=A1vora
<= /div> --0000000000007c44690573ce3df0--