From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#72701: eglot crash when project-files-relative-names t Date: Thu, 22 Aug 2024 21:38:49 +0100 Message-ID: References: <86bk1ksawn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27034"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 72701@debbugs.gnu.org, Ship Mints To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 22 22:39:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1shEag-0006qo-Pa for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Aug 2024 22:39:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1shEaU-0006T9-5j; Thu, 22 Aug 2024 16:39:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shEaS-0006Sw-K9 for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2024 16:39:16 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1shEaS-0002fR-BW for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2024 16:39:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=Wb9iT5vppBtwL/HlO9k8xiV0FbMQ13TlTupGx26RFKo=; b=V9wnA03cB4C6daVhmdhUpT3W90JxxqxtIMxCk0yNrplhzLNKwdqCi9J9mYTclBRE5HdaEBpXOAa3wW1clkqhdhGIKE2eOcw9n89IeVxfZk1EjIvO5j26z0WsbmUZLp51iQePuq+V3kohnHMehuQJBZzblnh4N+ZnYBcsQOgrhzGmy+BjlFH+sa623zWFZfiadWnbuSw8YjmMEYwc6PG6Dz6G1eI/SwcfQidZaKZsWoCQp19MRsD76Th3RH4+XY89q2YHIWcF45Ffjb5DYc3HBbNavp1ykluM6NX1t5vr6rQSEIaEWKONeO6Fo8uTVKJrRW/hHGk1DG4gmTF+LP8Mng==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1shEbC-0006DV-HD for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2024 16:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Aug 2024 20:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72701 X-GNU-PR-Package: emacs Original-Received: via spool by 72701-submit@debbugs.gnu.org id=B72701.172435917123844 (code B ref 72701); Thu, 22 Aug 2024 20:40:02 +0000 Original-Received: (at 72701) by debbugs.gnu.org; 22 Aug 2024 20:39:31 +0000 Original-Received: from localhost ([127.0.0.1]:38419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shEag-0006CV-PW for submit@debbugs.gnu.org; Thu, 22 Aug 2024 16:39:31 -0400 Original-Received: from mail-oo1-f41.google.com ([209.85.161.41]:52403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shEac-0006CE-FF for 72701@debbugs.gnu.org; Thu, 22 Aug 2024 16:39:30 -0400 Original-Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-5d5ed6f51cfso938372eaf.0 for <72701@debbugs.gnu.org>; Thu, 22 Aug 2024 13:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724359054; x=1724963854; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Wb9iT5vppBtwL/HlO9k8xiV0FbMQ13TlTupGx26RFKo=; b=OWnOkem+yJ4XLCWQbP94/WZFtLDGiJTET6vcGHnAV6ekJTA+R5cYbRgKYjLueIKEC6 4qdgf/6juhEpVHiiuW3CRy99otTeW4YyCPKbSyqMxQTTbXfDFmF5d6wGCkbFrYwv9bL4 3F5vKFSDqQintLwjh0Rmy49o1FG29ceJBIkJIntSlYo2aZkN3rfriAd6XnffauYz1I2x SN514RGYbpEGCdoqzFuAEh8h4Ghl958KAp40LH1TJxkayFshvcKwY8twCG35/zFgeUtP tawXc/o4HKRhVx3nJmCmKo4Mpw6XcbMKvMZxBA5ySDCmHjUAGxtlWR6TIsVtW32iaU7d dNPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724359054; x=1724963854; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wb9iT5vppBtwL/HlO9k8xiV0FbMQ13TlTupGx26RFKo=; b=wiB8iiqAatq3EHiCLwbG5+r5hxxbNvz0+aXpnX4apNvJ3E9NGxPnP6zlM6HWZwwI5D A2dKrYKSfG5XcRoMcmgBviKQrixflQUYD/xbJvqq2gtf4BmTxGJ9i9afez+uhxu1JHfi YuvbHBDRyrpMH2W65m3PAw/GZEQTUI21tFZ+7GVyovec98twycPcPsgrvipCtz8nqqr2 Ydwq/z6Y6VDyM0RX8CyO4WiDZVJCMIHFDzhLnJJ2VZOf42PYF4dQiI9kU+k50qdAYZqH KN+Oc13FITCXkTTxNY8JfBQAtsfuKJ6GNz3ZN9VhJUUPvbBOM0PwarvNadq8O/ZtfRyy uCYg== X-Forwarded-Encrypted: i=1; AJvYcCUUxglZMM4Mn4WxRx7Ve32dw361BIy/Jzn5OPIy6qa5ffBxWLg249Ds0IDWYr3+WMrT0CjzXw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yxy10ORt5CaRinIrbc3fLHb/dbAxypLN7K75WGv7N8e5Kl+pI7S xiWjAPjNd8GI7jjY8K2bxGUpFySI1kJ5bWG+LAW3hqF6A4200LlP7w1pONz9FyjltlLWY2KyAj4 +lMWvY0MLkdNxGsOwzbTap8E8Jk4= X-Google-Smtp-Source: AGHT+IGoHX7nK2PoGm8nLR0WrDstcP88U78M7PKrqA8j/PhMLHmwwFR+sVC7TLk4j75Wm/n1s/hcE5zfVUKTH0fzPO0= X-Received: by 2002:a05:6820:2221:b0:5ce:f75b:1755 with SMTP id 006d021491bc7-5dcb67f1267mr3862084eaf.4.1724359054283; Thu, 22 Aug 2024 13:37:34 -0700 (PDT) In-Reply-To: <86bk1ksawn.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290562 Archived-At: If I understand the problem and the fix it's that `project-files` has its return value controlled by a global. Not sure that's a great API design (maybe it should change the end result some interactive commands instead). But adding the dynamic binding sounds fine, feel free to push, just add a good explanation in the commit message. Jo=C3=A3o On Thu, Aug 22, 2024 at 6:52=E2=80=AFPM Eli Zaretskii wrote: > > > Cc: Dmitry Gutov , > > Jo=C3=A3o T=C3=A1vora > > From: Ship Mints > > Date: Thu, 22 Aug 2024 13:04:23 -0400 > > > > Greetings, just want to make sure this fix doesn't get lost... > > Fear not, patches don't get lost here. --=20 Jo=C3=A3o T=C3=A1vora