From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#42149: Substring and flex completion ignore implicit trailing =?UTF-8?Q?=E2=80=98any=E2=80=99?= Date: Wed, 25 Nov 2020 12:22:55 +0000 Message-ID: References: <87sgbsv7gg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005500d005b4ed7d13" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33259"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42149@debbugs.gnu.org, Stefan Monnier To: Dario Gjorgjevski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 25 13:24:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khtqI-0008ZH-V0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Nov 2020 13:24:15 +0100 Original-Received: from localhost ([::1]:33004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khtqG-0005Vb-L1 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Nov 2020 07:24:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47946) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khtq6-0005VG-6E for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 07:24:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51313) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khtq5-0003PY-Tp for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 07:24:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1khtq5-0000Mu-Pz for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 07:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Nov 2020 12:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42149-submit@debbugs.gnu.org id=B42149.16063069931350 (code B ref 42149); Wed, 25 Nov 2020 12:24:01 +0000 Original-Received: (at 42149) by debbugs.gnu.org; 25 Nov 2020 12:23:13 +0000 Original-Received: from localhost ([127.0.0.1]:34626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khtpJ-0000Li-CY for submit@debbugs.gnu.org; Wed, 25 Nov 2020 07:23:13 -0500 Original-Received: from mail-io1-f52.google.com ([209.85.166.52]:46627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khtpI-0000LW-5g for 42149@debbugs.gnu.org; Wed, 25 Nov 2020 07:23:12 -0500 Original-Received: by mail-io1-f52.google.com with SMTP id r1so1898911iob.13 for <42149@debbugs.gnu.org>; Wed, 25 Nov 2020 04:23:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RziVHkx+OUKrrQ6HG8z8mcXiVspTk2mc49YTf3yjvEE=; b=RWd6abhg1g8dGKqQlHl1O6a3KvNMoau1Q9A8WgWsgRogNPPWur4B4QJaTLUtlGU8ka 9kMQDDItXWZAokfHvO901VKCacOsc3BTSnlM2fb+S2ykWUv9qzan/1ra5YWFGMQCq1UK Fes4h4fPlAtmW7j78Y3SXr07PGKuNjBikhEwrgQPqwscQ30IMlmirr7RaZfhFj8R2GD+ 8zbds6k0UiVC8WolBqZrLOm1FrVVU0z3YqhZdshEqjspoR1ScOtfgi2gFwnFPmKBO56v DwUwAyG1Cqto+KwWqstIf4EFFV+b7hbf73LNLZd8NSGxPHKyVMCJ/oG5JI5j4F+qZ5Cy pmEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RziVHkx+OUKrrQ6HG8z8mcXiVspTk2mc49YTf3yjvEE=; b=cmOPu7M/ErmeL9JvpaiJ9H18vhE5vYObaHXHXwM6KYEbTKA3P/BTpD/Oc5Kpgkx0PX cLfz+Ffp3lWm0mmx8dif9rbYl+/QaVjWFL0q7xjkXjoQ6lF0GYLGOo9d2cw2iAMydm0B FPftukB1wUMKQSTR1RGVU7ebHomHI05vvYH2YoKDo031qa09xYkbRCoLhPmGn8aXnnny SYeDOHqodDDjQp39SVA6VJ//5tpW/DP7wZpRIvdbvweND/6WCym9hMR2v29BXx79bgVD KUudRkha0UhIA8ojjIX0t4X4ChGHIOwDIfOLFLZYw+Flv6gg4xYtcIMDluC2EqI+DDDA w+Og== X-Gm-Message-State: AOAM530QchP3lrYHNPj/HDAad+Jp8zjEXKNiGXYZCLdL+UiolqLPXtCC f/aSOtJm1cwCqawj+WIECXAtz+/SZSFLjPfKSi0= X-Google-Smtp-Source: ABdhPJy3wl3okc0RMHLrG2wapLdlY2hKPhdu1o6Vg1jurr/3Y+jPELVOmKiJhkrRILjCL6gEV8ZSX49Dcz+XMbJI2Z0= X-Received: by 2002:a02:29c8:: with SMTP id p191mr2940880jap.71.1606306986523; Wed, 25 Nov 2020 04:23:06 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194190 Archived-At: --0000000000005500d005b4ed7d13 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Nov 25, 2020 at 8:22 AM Dario Gjorgjevski < dario.gjorgjevski@gmail.com> wrote: > > Don't worry, I will soon. First thing I looked at > > was the tests you provided, which are very welcome. > > I restructured them, creating instead 13 small tests > > instead of just 3 tests that currently fail. > Thanks a lot once again, this is very appreciated. Admittedly, the > tests weren=E2=80=99t very good and I wasn=E2=80=99t sure how to make the= m better. Maybe you misunderstood me. I didn't write any new tests, I used your code and split it up into multiple ert-deftests so that I could get a better idea of which assertions are failing. The tests you wrote seem decent (but if you have even better ones, I'm OK with that too :-) ) Jo=C3=A3o --0000000000005500d005b4ed7d13 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Nov 25, 2020 at 8:22 AM Dario Gjorgjevski <dario.gjorgjevski@gmail.com&= gt; wrote:

> > Don't worry, I will soon.=C2=A0 First thing= I looked at
> > was the tests you provided, which are very welcom= e.
> > I restructured them, creating instead 13 small tests
>= ; > instead of just 3 tests that currently fail.
> Thanks a lot on= ce again, this is very appreciated.=C2=A0 Admittedly, the
> test= s weren=E2=80=99t very good and I wasn=E2=80=99t sure how to make them bett= er.

Maybe you misunderstood me. I didn't write= any new tests, I used
your code and split it up into multiple er= t-deftests so that I could get
a better idea of which assertions = are failing.=C2=A0 The tests you wrote
seem decent (but if you ha= ve even better ones, I'm OK with that
too :-) )

Jo=C3=A3o
--0000000000005500d005b4ed7d13--