From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#66938: 30.0.50 [PATCH]: Make EIEIO :accessor behave like :reader when reading a slot's value Date: Wed, 29 Nov 2023 00:29:31 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2139"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66938-done@debbugs.gnu.org To: Stefan Monnier , 66938@debbugs.gnu.org, brandon.irizarry@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 29 01:31:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r88UJ-0000Ps-7z for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Nov 2023 01:31:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r88Tv-00078f-Aq; Tue, 28 Nov 2023 19:31:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r88Tk-00075X-2k for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2023 19:31:09 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r88Tf-00009u-CJ for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2023 19:30:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r88Tm-0002tH-6n for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2023 19:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Nov 2023 00:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66938 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66938-submit@debbugs.gnu.org id=B66938.170121780210942 (code B ref 66938); Wed, 29 Nov 2023 00:31:02 +0000 Original-Received: (at 66938) by debbugs.gnu.org; 29 Nov 2023 00:30:02 +0000 Original-Received: from localhost ([127.0.0.1]:48462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r88Sn-0002qF-UZ for submit@debbugs.gnu.org; Tue, 28 Nov 2023 19:30:02 -0500 Original-Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:53260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r88Si-0002oj-8U; Tue, 28 Nov 2023 19:30:01 -0500 Original-Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-5098e423ba2so8922363e87.2; Tue, 28 Nov 2023 16:29:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701217783; x=1701822583; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cXcgjP61+ReK3d1LpcVUaluNHf+szbrEsbwnyoneZRg=; b=RKt8rFNVTXOApGCVxT6V9HMkhShgelj64z4DMgyTyWXD6q+olBGGD9kwkS+wlr3vZl dpssB9UlLraP8XMjHRC7E6SSsdAI4HcZF029Wcc1HF+6tocJ1/1B0E20ifIvs/z16+CI y/T822wecpKD0nG7WZz6ZuxDR0j1+8RSmHjwxHXmK1k5mgcxyN2VH8niVByz9L/dyFh2 F6p0xlIlVoQqU0PNe4mw7FggX50NIiDjCsluLWeZLLPacQGVJXki1HXMD8/7w+ljh7gQ NhJndsw1l15D6rD86YoDAuiYab07YpZ12uQdan8FGjT/1em0n3xpjV9DA5zzO+k3vpNg wYEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701217783; x=1701822583; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cXcgjP61+ReK3d1LpcVUaluNHf+szbrEsbwnyoneZRg=; b=TrwlGHrye1IRC/V+CjFN/jxGndW4EORmhYxljZdEsavTUXymhz4JxpfRuiX02ykTmQ YB0Hhiqf93xbxIRnqudLOpfkJcxRAUkLdxS1TZUR9W4+VxJ/p1jgU9CGjiigtFiCqYyK wtC+wRGdV74OYxRvf4COeisyLExiCJZZlQI+whICgf3m0IHV9GGJfSax/+UPV0bG7yLG iDCujAHqgaAHBvlVbMRSusucBpOgJVx7OpP1FTr0iw6Dxi8AAIcOTIj36lLR1yY8pU7H zQHT3uK050By8nOyPlk/KpPmOSO6y+PDUU0sVJ3wvCLQiKTSdxctyr0JQE/F33J05mQR XFdg== X-Gm-Message-State: AOJu0YwJ0dDcFnUOziA45fTUvNvVMwgfgqn2syBcXsEWlhqPel1CKum0 grR/g+tbnL1/54P+v0EeI23bs2iuk6hWPUMc3kQ= X-Google-Smtp-Source: AGHT+IHEbQ2Vq1fzRZ0Nxdu3HGkIMFzC8xGwWEzxRoQBAHgilQgybOEejSbZCGQ+uTMiD6BHml5WI/TTLJEFv53PLgQ= X-Received: by 2002:ac2:43bc:0:b0:50a:aa7d:2c18 with SMTP id t28-20020ac243bc000000b0050aaa7d2c18mr9045696lfl.61.1701217782859; Tue, 28 Nov 2023 16:29:42 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275187 Archived-At: Just wanted to say that while I think this is all very fine to improve on EIEIO's inaccurate emulation of CLOS, this breaks a lot of stuff, broke Eglot and Jsonrpc, immediately. This is mainly because EIEIO users like me got sloppy with their slot definitions and don't put explicit :initforms in them, instead relying on this quirk. Oh well, I'm fixing this now as part of bug#67480, but we should definitely expect flak more or less proportional to the use of EIEIO out there (and in here). BTW another reason I get sloppy is that EIEIO doesn't allow me to use a (some-slot :initform (error "required!") ...) like I do in CLOS. The initform is meant to be evaluated during instantiation (that's why it's a "form" ;-) ) Jo=C3=A3o