From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#51437: 29.0.50; The annotated example of a complete working Flymake backend does not work with narrowed buffers Date: Fri, 29 Oct 2021 19:07:09 +0100 Message-ID: References: <871r44ymw6.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000002a205805cf81b37c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32262"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51437@debbugs.gnu.org, Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 29 20:08:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mgWIX-0008A7-O8 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Oct 2021 20:08:13 +0200 Original-Received: from localhost ([::1]:52448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgWIW-0004Fr-1x for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Oct 2021 14:08:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgWIM-0004ER-VJ for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 14:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44313) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgWIL-0001VF-Th for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 14:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mgWIL-0006AL-MM for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 14:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Oct 2021 18:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51437 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51437-submit@debbugs.gnu.org id=B51437.163553085623660 (code B ref 51437); Fri, 29 Oct 2021 18:08:01 +0000 Original-Received: (at 51437) by debbugs.gnu.org; 29 Oct 2021 18:07:36 +0000 Original-Received: from localhost ([127.0.0.1]:55859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgWHv-00069Y-Ih for submit@debbugs.gnu.org; Fri, 29 Oct 2021 14:07:35 -0400 Original-Received: from mail-pf1-f177.google.com ([209.85.210.177]:42783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgWHs-00069H-WD for 51437@debbugs.gnu.org; Fri, 29 Oct 2021 14:07:34 -0400 Original-Received: by mail-pf1-f177.google.com with SMTP id m14so9927355pfc.9 for <51437@debbugs.gnu.org>; Fri, 29 Oct 2021 11:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q1im/QYg5ZhD5Ay30ueXaa/wQl8+BtUuGdaC1e+t8Fg=; b=ikgioSAs1rvRbk9quU+qHXhXOjVE3AZIGyorfaIfNMHk7ybfkvQIdxsMmWse7r47yy lbCHccqEqUoabDS8D/N8GbwUNqeoQHfmVjKpm2SZWQ8iuLPZDaHBihkNfUhLtuh4qLnP SmMiCc5M+E5NRfGoIV3SHaVCl2d8gUeFAnEIFkEml6RJQwMJMbOPI2w5HyWr79zSnE7x sO2+X++NdATG+xiPt8RDn26eVHsqOvmw/pgReIMZn2KVr10P+9DBV6Pe+I2bCPl0sMPX /4ommuY4T/kIz4tGCTXnagXbP4iR9LFylkfAatdmRV9IwaYp2q95kuWIK6gwiFni0B3U QCEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q1im/QYg5ZhD5Ay30ueXaa/wQl8+BtUuGdaC1e+t8Fg=; b=q17cWLxm12nsvhbIRLosDYeVJNbppiKGBthvxOd1G+c689uBVVICOA9tetSXGYEVPL jAXciEYGc86ARR7xRsZNJi48MAScJTww8tooVWCd7QAjaD2YHsJYbmUdIN6K0++hyNhX g2I3XYyFSFtou47to/NzmC+Qo+erUtY5QpM6CmcAozuozzexAABc1aXEuJLaLWz3t3t8 1kMx4ATS5nTbeq8WPfRDEZVwh64DWJO7FOaJs6BvUSie/4mxU27j/Cds3kEy0xjpqBel IEn+v4nUFkCmzXfMwaxqYJ0H+uXvYFapxS2SrDr+zpF5EQ7thR93oZAvVALx/7D1zxnh A14w== X-Gm-Message-State: AOAM533r57vmtR1s5G4gK/25E9/80oR9ujHS4KJgyziLPubxIg1moHcz VY8VZf2YXuIlf8lpwsd6uLj03v7YIfeH45JlNBM= X-Google-Smtp-Source: ABdhPJyICBP4NXx0Wul8+Y3NkNZ5MJhh4szqcX1dJkG3seGSi7yNn8oqSZj1lDZ+H6d512UMgg7u94JVnitnBc6ltsU= X-Received: by 2002:aa7:8a0e:0:b0:47c:1116:3ce with SMTP id m14-20020aa78a0e000000b0047c111603cemr12343794pfa.76.1635530847164; Fri, 29 Oct 2021 11:07:27 -0700 (PDT) In-Reply-To: <871r44ymw6.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218583 Archived-At: --0000000000002a205805cf81b37c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Might be. I can't test right now, but maybe Rudolf can. If it works then I'd say commit it. Jo=C3=A3o On Fri, Oct 29, 2021, 14:35 Lars Ingebrigtsen wrote: > Rudolf Adamkovi=C4=8D writes: > > > When checking a narrowed buffer with errors outside of the narrowed > region, I get: > > > > =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80 > > =E2=94=82 error in process sentinel: flymake--highlight-line: Wrong typ= e > argument: integer-or-marker-p, nil > > =E2=94=82 error in process sentinel: Wrong type argument: integer-or-ma= rker-p, > nil > > =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80 > > > > Looks like `flymake-diag-region' returns `(nil . nil)' and > `flymake-make-diagnostic' does not like that. > > Perhaps this is the correct fix? (Jo=C3=A3o added to the CCs.) > > diff --git a/doc/misc/flymake.texi b/doc/misc/flymake.texi > index 309bed7760..1d99342060 100644 > --- a/doc/misc/flymake.texi > +++ b/doc/misc/flymake.texi > @@ -798,6 +798,7 @@ An annotated example backend > for type =3D (if (string-match "^warning" msg) > :warning > :error) > + when (and beg end) > collect (flymake-make-diagnostic source > beg > end > > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no > --0000000000002a205805cf81b37c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Might be. I can't test right now, but maybe Rudolf ca= n. If it works then I'd say commit it.

Jo=C3=A3o

On Fri, Oct 29, 2021, 1= 4:35 Lars Ingebrigtsen <larsi@gnus.org= > wrote:
Rudolf Adamkovi=C4= =8D <salutis@me.com> writes:

> When checking a narrowed buffer with errors outside of the narrowed re= gion, I get:
>
> =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80
> =E2=94=82 error in process sentinel: flymake--highlight-line: Wrong ty= pe argument: integer-or-marker-p, nil
> =E2=94=82 error in process sentinel: Wrong type argument: integer-or-m= arker-p, nil
> =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80
>
> Looks like `flymake-diag-region' returns `(nil . nil)' and `fl= ymake-make-diagnostic' does not like that.

Perhaps this is the correct fix?=C2=A0 (Jo=C3=A3o added to the CCs.)

diff --git a/doc/misc/flymake.texi b/doc/misc/flymake.texi
index 309bed7760..1d99342060 100644
--- a/doc/misc/flymake.texi
+++ b/doc/misc/flymake.texi
@@ -798,6 +798,7 @@ An annotated example backend
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 for type =3D (if (string-match "^warning" msg)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0:warning<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0:error)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0when (and beg end)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 collect (flymake-make-diagnostic source
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0beg
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0end


--
(domestic pets only, the antidote for overdose, milk.)
=C2=A0 =C2=A0bloggy blog: http://lars.ingebrigtsen.no
--0000000000002a205805cf81b37c--