From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#73279: [PATCH] Eglot: use immediate-mode eglot--request for :completionItem/resolve Date: Mon, 16 Sep 2024 16:50:35 +0100 Message-ID: References: <87v7ywoh7m.fsf@taipei.mail-host-address-is-not-set> <86wmjbdehl.fsf@gnu.org> <8734lz7hn2.fsf@taipei.mail-host-address-is-not-set> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10225"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 73279@debbugs.gnu.org, Dmitry Gutov To: Brennan Vincent Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 16 17:51:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sqE0U-0002Qt-Nv for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Sep 2024 17:51:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqE02-00063v-CS; Mon, 16 Sep 2024 11:50:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqE01-00063f-F4 for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 11:50:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqE01-0000Of-60 for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 11:50:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=HN/2lt1YPPANqmDrEMUgEtCyznqSmVOl2Sw+dNjXtxo=; b=m6XKJn8ANW7+dFCOSYltcnS0NCKg4dXVau5cXOdsyaNmzmWiR+REam5D6G2Y/2eiadklL2N1jecii0YoyIZq2TY77eQ8LVTIDcGWPmsN1dhhVSVkQk7b3pdxesdzKaSyFHdWXweL+PJhMIfveE5BZwNiST2hvf5p2u9Suqrfso9G+9CyvCHjcerW4wpBnzeaxaEtdQLGy8LS+F5YPiSG7D8SY01D3m9KeY5J4LeTFqmBNXkqAZC64Y5HDEflsNuz6pCZNLwlrUsl47Byco0OUZuwDnPPWbsKin+37gr6ORTvHrt0YwiiL1av2MOXbJZmJpfYtnJy6Afo+TLlQ207Yw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqE0E-000831-I9 for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 11:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Sep 2024 15:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73279 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73279-submit@debbugs.gnu.org id=B73279.172650183130874 (code B ref 73279); Mon, 16 Sep 2024 15:51:02 +0000 Original-Received: (at 73279) by debbugs.gnu.org; 16 Sep 2024 15:50:31 +0000 Original-Received: from localhost ([127.0.0.1]:53101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqDzj-00081t-0k for submit@debbugs.gnu.org; Mon, 16 Sep 2024 11:50:31 -0400 Original-Received: from mail-oo1-f48.google.com ([209.85.161.48]:55349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqDzh-00081e-C8 for 73279@debbugs.gnu.org; Mon, 16 Sep 2024 11:50:30 -0400 Original-Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-5d5f24d9df8so1507788eaf.2 for <73279@debbugs.gnu.org>; Mon, 16 Sep 2024 08:50:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726501750; x=1727106550; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HN/2lt1YPPANqmDrEMUgEtCyznqSmVOl2Sw+dNjXtxo=; b=jgnFyNftsI0y8noRVjG+IQHbOtvWDnXhSmnbBmB5TKAwh2auEj3MPW9KNeo2p8EXif 57FVwJpJdsuMkKjyxiaTnU6x3wBrHCOlXki7sgNYhf8v0eq2R142ss6s6Lr8lnV1LtMI dZ3OzBcg828wRafuoThXJRkH3vWfKOaQiO89t7tfHPEExG0/0DjRNRIj9rHSDdIhkzFL wpd9tNZsjzRyVyddl4N2CetJZDU205THa/6OkWsjFVPt3ycm2D0ttkHZKDst91WH7qzh 4XfjKyJuxec01cfS2bkxNXrXS8CzULUvE9MMxE7K748z4fdSBVU/Jv/myVgunoTs0QEy D5fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726501750; x=1727106550; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HN/2lt1YPPANqmDrEMUgEtCyznqSmVOl2Sw+dNjXtxo=; b=Gbb8yr0Goqvu8aheEg9YPznTgD9L/O/VOe30DdL3sB01UuCbwrcXrhF/r7FOAwpm5Q 18MFqOLe1NqGlBeuYRKEwFUt+2igdtqgBtugcT5kQ5BzhyLxj19W+h/wHEpobuIgsdIq hsVyd+rs6iXEHfiTV99msajShGZqVWh9iueQLmOKWgluBkX1d3vNRv+2v6qVrBLnQC6V JBjjx6t8WHeXINmHI+OrAmwqv4a5gTgzQ52ymngGvw0wRUsCfYi3wRmqXhuiO/amqAp2 IVzLd7umZCy6w2yeSpEFz5Qch2twxt3nxd5MDaBI7NKezYwNzTRzA4bvg8ZXOoK6ar6H SBKw== X-Forwarded-Encrypted: i=1; AJvYcCUwPzCdtRs1K+qriY9BrAvWZqqdETAo3QKll55OXizFxJtJvjpz9VjXajV8nTZZaPIRPz0I2Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzmCEgAbRSIi2fCP3wicpkZlRuFN/2TICL/a2XSGkl85VdhkmR8 S3soLULLKMCaS5n5d5q1k4r9yt2K4tdSegyIWzrEeGsJGw26uyvjzwvPfuc7zL2uCMfHcRZAFXz ZQ95bcSKmuKfOzqSnh3qI50W5Xk2/eA== X-Google-Smtp-Source: AGHT+IFGRAXNyzfy2PXsbKa8quWFgTPdnqHOazHayIykfuwOcjj2CNLKLYeP8l+Jw9EH1vvJSXlFDSrWB0Zo3bB66Jg= X-Received: by 2002:a05:6820:160a:b0:5e1:cabe:a3 with SMTP id 006d021491bc7-5e20bfc6df9mr4405653eaf.0.1726501750335; Mon, 16 Sep 2024 08:49:10 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291897 Archived-At: On Mon, Sep 16, 2024 at 4:40=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > On Mon, Sep 16, 2024 at 4:17=E2=80=AFPM Brennan Vincent wrote: > > > As for the regression: yes, it's a regression from 29.4, and in fact I > > have bisected to the commit that regressed it: > > a8c1559a663d9bc21776e33303251e244f86f0d7 > > Oh alright, that clears it up. It was an oversight indeed, so I think > your patch is TRT. I'll install it in emacs-30. Actually, not so fast. The code before that allegedly broken commit _also_ sent outstanding changes to the server before resolving (via the advice that was then removed). So I must be missing something, and must investigate more closely. Jo=C3=A3o