From: "João Távora" <joaotavora@gmail.com>
To: Brennan Vincent <brennan@umanwizard.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
73279@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#73279: [PATCH] Eglot: use immediate-mode eglot--request for :completionItem/resolve
Date: Mon, 16 Sep 2024 16:50:35 +0100 [thread overview]
Message-ID: <CALDnm50HsJYLVSTUpSuVTJmjky5iiFcooSrYynvGRhPzhcYT_Q@mail.gmail.com> (raw)
In-Reply-To: <CALDnm51ajXGkcj8qU-8jS_82Tw30qEctds00HmOzD=8bsd3Lvw@mail.gmail.com>
On Mon, Sep 16, 2024 at 4:40 PM João Távora <joaotavora@gmail.com> wrote:
>
> On Mon, Sep 16, 2024 at 4:17 PM Brennan Vincent <brennan@umanwizard.com> wrote:
>
> > As for the regression: yes, it's a regression from 29.4, and in fact I
> > have bisected to the commit that regressed it:
> > a8c1559a663d9bc21776e33303251e244f86f0d7
>
> Oh alright, that clears it up. It was an oversight indeed, so I think
> your patch is TRT. I'll install it in emacs-30.
Actually, not so fast. The code before that allegedly broken commit
_also_ sent outstanding changes to the server before resolving
(via the advice that was then removed).
So I must be missing something, and must investigate more
closely.
João
next prev parent reply other threads:[~2024-09-16 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-15 19:22 bug#73279: [PATCH] Eglot: use immediate-mode eglot--request for :completionItem/resolve Brennan Vincent
2024-09-16 11:28 ` Eli Zaretskii
2024-09-16 13:43 ` João Távora
2024-09-16 15:17 ` Brennan Vincent
2024-09-16 15:40 ` João Távora
2024-09-16 15:50 ` João Távora [this message]
2024-09-16 16:21 ` João Távora
2024-09-16 17:06 ` Brennan Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm50HsJYLVSTUpSuVTJmjky5iiFcooSrYynvGRhPzhcYT_Q@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=73279@debbugs.gnu.org \
--cc=brennan@umanwizard.com \
--cc=dgutov@yandex.ru \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).