From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#53853: [PATCH] Don't use string-replace in flymake Date: Tue, 8 Feb 2022 15:30:34 +0000 Message-ID: References: <87r18e7fb7.fsf@gmail.com> <87zgn1ublj.fsf@gnus.org> <87mtj17oqg.fsf@gmail.com> <87ee4d7o3f.fsf@gmail.com> <875ypp7kmu.fsf@gmail.com> <83iltpwlwn.fsf@gnu.org> <83fsotwjiw.fsf@gnu.org> <87h7995rd6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c3bddc05d78363a8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10151"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Brian Leung , Lars Ingebrigtsen , 53853@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 08 17:55:48 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHTmO-0002UP-IU for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 17:55:48 +0100 Original-Received: from localhost ([::1]:38090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHTmN-00068f-HA for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Feb 2022 11:55:47 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHSSR-000241-H0 for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 10:31:12 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54472) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHSSM-0001oY-1p for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 10:31:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHSSL-00079f-NW for bug-gnu-emacs@gnu.org; Tue, 08 Feb 2022 10:31:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Feb 2022 15:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53853-submit@debbugs.gnu.org id=B53853.164433420527368 (code B ref 53853); Tue, 08 Feb 2022 15:31:01 +0000 Original-Received: (at 53853) by debbugs.gnu.org; 8 Feb 2022 15:30:05 +0000 Original-Received: from localhost ([127.0.0.1]:48369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHSRR-00077M-0Y for submit@debbugs.gnu.org; Tue, 08 Feb 2022 10:30:05 -0500 Original-Received: from mail-oo1-f48.google.com ([209.85.161.48]:43642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHSRP-00076J-JR for 53853@debbugs.gnu.org; Tue, 08 Feb 2022 10:30:04 -0500 Original-Received: by mail-oo1-f48.google.com with SMTP id v17-20020a4ac911000000b002eac41bb3f4so17907511ooq.10 for <53853@debbugs.gnu.org>; Tue, 08 Feb 2022 07:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h/BHGPwHN6Jp1GHoSWJfV2FwZLdcE28V5tg9xs5Wv0Q=; b=Jhol+2eDSN8+VaB5O6uva/Fze5Why/ownNi/vcAT9SSFOYZOwPgddpnVEQhi7cLuer zYYbqqnSFL05zpcbFFPjf6eo4FsvyPnrcDBg8ix4CmeeAADGTc4834yr6/tJHA+TNJts D/3sAMSsa3KvBA4P69NkHydZXdXxAiGefNHBVm/owORzMg1g1jvzLzd2p1ELYKRptghe LAr/BXO2xbDnLMBHU3grHbFHxVcpy9AdHaPJmd6esgGubCyxM9NIVeobZdlnEhdeapbh GpPQkxTkrewiK4K4CLd79heSHEhc3UBNsCcLGqr051sTYewuLI3TyquRUMtOOSZqoolq Sixg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h/BHGPwHN6Jp1GHoSWJfV2FwZLdcE28V5tg9xs5Wv0Q=; b=niHGvbuCYjP2TZMdupPqK46FXHgYpwAl6fKFw5SsE+XWQCjti4NfiKS+y8Mtrd9JgL EYHIJUr0jtBjZzdKe+MshBtNatI8F/WWEWH0yA3CQN+MpAEUkKd7LT510pJvtTTiX9sc kdsTm49/7YvNLCuUrMea9QFeG0W9VXaCh8Wzl8ooUQZuhfZkemkwqREoIIwRSzGM9yDg +5YlQFRrL6SzyYQ3HxcBf3WVVrFfXwpON3T87sK96bwHoXFpTXLcMv3PiLFcbKo3JAv9 /XOu1+DWbDfvZgHkPUXFEkE0c4o46XB7mdFrXjGVuxM7VWAHImo7LLu4fjLfMtuiNn7O xSYw== X-Gm-Message-State: AOAM531D/g2kP5iS9d8D2xnFaQQE5X6GLv5XDjDQF8OjlgaeNHdR0tFD gqaYwPWjSxCSQ6DbN6FMKdpIQLbVoUBNifJwEeA= X-Google-Smtp-Source: ABdhPJzPS+Kl5Xbs9LRc2GcewAbC5NllaQrRI9K+W4zagsVmKlmJsw5lKvsTlhU/lp4icQ5lNRZcFKnWjGOdhNMjX7w= X-Received: by 2002:a05:6870:ea05:: with SMTP id g5mr551541oap.181.1644334198011; Tue, 08 Feb 2022 07:29:58 -0800 (PST) In-Reply-To: <87h7995rd6.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226386 Archived-At: --000000000000c3bddc05d78363a8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Feb 8, 2022 at 3:07 PM Robert Pluim wrote: > >>>>> On Tue, 8 Feb 2022 14:09:34 +0000, Jo=C3=A3o T=C3=A1vora > said: > > Jo=C3=A3o> Well, technically, I did "show the patch" even though I di= dn't > author said > Jo=C3=A3o> patch myself. I answered: > > >> It would seem that the right thing to do is to keep 26.1 dep and d= o > what > Jo=C3=A3o> Guillaume Pasquet suggests: > >> "or substitute the `string-replace` call with > `replace-regexp-in-string` > Jo=C3=A3o> to maintain compatibility as I have done here: > >> > Jo=C3=A3o> > https://github.com/Etenil/flymake/commit/9f5f76907b1c258645f65728dd71e7ca= cffe6d22 > > Jo=C3=A3o> Anyway, all good now, just bring the Emacs dep down to 26.= 1. > Thanks. > > Just so we=CA=BCre all clear, we want this in emacs-28 (on top of Lars's > change to use `replace-regexp-in-string'? > I think so. We're in that phase of the release cycle where everything in emacs-28 that fixes a bug ends up in main, right? If so I would say yes. But let Eli or Lars confirm. Jo=C3=A3o --000000000000c3bddc05d78363a8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Feb 8, 2022 at 3:07 PM Robert Pluim <rpluim@gmail.com> wrote:
>>>>> On Tue, 8 Feb 2022 14= :09:34 +0000, Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> said:

=C2=A0 =C2=A0 Jo=C3=A3o> Well, technically, I did "show the patch&q= uot; even though I didn't author said
=C2=A0 =C2=A0 Jo=C3=A3o> patch myself. I answered:

=C2=A0 =C2=A0 >> It would seem that the right thing to do is to keep = 26.1 dep and do what
=C2=A0 =C2=A0 Jo=C3=A3o> Guillaume Pasquet suggests:
=C2=A0 =C2=A0 >> "or substitute the `string-replace` call with `= replace-regexp-in-string`
=C2=A0 =C2=A0 Jo=C3=A3o> to maintain compatibility as I have done here:<= br> =C2=A0 =C2=A0 >>
=C2=A0 =C2=A0 Jo=C3=A3o> https://github.com/Etenil/flymake/commit/9f5f76907b1c258645f65728d= d71e7cacffe6d22

=C2=A0 =C2=A0 Jo=C3=A3o> Anyway, all good now, just bring the Emacs dep = down to 26.1.=C2=A0 Thanks.

Just so we=CA=BCre all clear, we want this in emacs-28 (on top of Lars'= s
change to use `replace-regexp-in-string'?

I think so. We're in that phase of the release cycle where every= thing in emacs-28 that
fixes a bug ends up in main, right?=C2=A0 = If so I would say yes. But let Eli or Lars confirm.

Jo=C3=A3o
--000000000000c3bddc05d78363a8--