On Tue, Feb 8, 2022 at 3:07 PM Robert Pluim <rpluim@gmail.com> wrote:

> >>>>> On Tue, 8 Feb 2022 14:09:34 +0000, João Távora <joaotavora@gmail.com>
> said:
>
>     João> Well, technically, I did "show the patch" even though I didn't
> author said
>     João> patch myself. I answered:
>
>     >> It would seem that the right thing to do is to keep 26.1 dep and do
> what
>     João> Guillaume Pasquet suggests:
>     >> "or substitute the `string-replace` call with
> `replace-regexp-in-string`
>     João> to maintain compatibility as I have done here:
>     >>
>     João>
> https://github.com/Etenil/flymake/commit/9f5f76907b1c258645f65728dd71e7cacffe6d22
>
>     João> Anyway, all good now, just bring the Emacs dep down to 26.1.
> Thanks.
>
> Just so weʼre all clear, we want this in emacs-28 (on top of Lars's
> change to use `replace-regexp-in-string'?
>

I think so. We're in that phase of the release cycle where everything in
emacs-28 that
fixes a bug ends up in main, right?  If so I would say yes. But let Eli or
Lars confirm.

João