From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot Date: Sat, 15 Apr 2023 11:44:08 +0100 Message-ID: References: <87a5zj2vfo.fsf@gmail.com> <87edonlsxi.fsf@posteo.net> <83jzyf4vzb.fsf@gnu.org> <871qknllkj.fsf@posteo.net> <83fs934pjf.fsf@gnu.org> <87wn2fk47y.fsf@posteo.net> <83sfd2g2ek.fsf@gnu.org> <875y9yfxrr.fsf@gmail.com> <87y1muefks.fsf@gmail.com> <834jpifizy.fsf@gnu.org> <83y1mue1qi.fsf@gnu.org> <83sfd2e01f.fsf@gnu.org> <87v8hynsbu.fsf@posteo.net> <87a5z935ly.fsf@gmail.com> <875y9x5szf.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9494"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62720@debbugs.gnu.org, rpluim@gmail.com, dmitry@gutov.dev, monnier@iro.umontreal.ca, Eli Zaretskii , larsi@gnus.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 15 12:43:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pndND-0002Jp-5w for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Apr 2023 12:43:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pndN1-0004EV-Vl; Sat, 15 Apr 2023 06:43:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pndN0-0004EH-Ic for bug-gnu-emacs@gnu.org; Sat, 15 Apr 2023 06:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pndN0-0002ZY-Ah for bug-gnu-emacs@gnu.org; Sat, 15 Apr 2023 06:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pndN0-0000mo-6i for bug-gnu-emacs@gnu.org; Sat, 15 Apr 2023 06:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Apr 2023 10:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62720 X-GNU-PR-Package: emacs Original-Received: via spool by 62720-submit@debbugs.gnu.org id=B62720.16815553402955 (code B ref 62720); Sat, 15 Apr 2023 10:43:02 +0000 Original-Received: (at 62720) by debbugs.gnu.org; 15 Apr 2023 10:42:20 +0000 Original-Received: from localhost ([127.0.0.1]:48327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pndMK-0000la-4q for submit@debbugs.gnu.org; Sat, 15 Apr 2023 06:42:20 -0400 Original-Received: from mail-oa1-f54.google.com ([209.85.160.54]:43926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pndMI-0000lJ-LW for 62720@debbugs.gnu.org; Sat, 15 Apr 2023 06:42:19 -0400 Original-Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-187a742a963so6143884fac.10 for <62720@debbugs.gnu.org>; Sat, 15 Apr 2023 03:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681555332; x=1684147332; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OvhCi2xm4S5aPjMVTDsBuQhZnEiwfRxi8hL7sQkNsYI=; b=TXq7tkDklFdH5QhvlenPh3Std618IodPULQbyt5j8ca2F7M4BX7/YtQAmGzyzF4ntV qjuSLRbBk0BRSSd59XPpjVR6tWEeblyxC8+/QjyGoHEb3B6xloVEcmDOA3/7/0BZ17Qi WH3mQmqE4pyTRrHGwz99ITvpc4BvzYppV9hf4/SmsB9o5LugBa2OHZFUvZj3Ijtuwt8z YZtwx7hioCFORrGELvrjY+epftaZmwinwEWdpULbuD4oAj3FoiCSJ6mhZoZUMyBHIFtM s2wWkTkgsjZwCS3ehvXCZwjRccD36psM9MHZZtIlVCyMHSNwpmYLUmsWwAyN5JMIPGYe xpcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555332; x=1684147332; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OvhCi2xm4S5aPjMVTDsBuQhZnEiwfRxi8hL7sQkNsYI=; b=Dxwc965L5/N7Q1Sf7LLLRYYIXyzE/4h13ehJoeoY2UEW/RHJFiCuOX8r4J7qI8MJEt XdLK3Xqlpgv0oBI0D0kz9qK3B9NJQRx9egr1GXqNbP4K2wMH0kuMIv06HmAxwTwSUFif h+IvwjvQ6ot2+giwZ5HxHbY/CYuh44q0CkQbz3d7T5rpSvcL4RGuwHUi3wlbafg3CZrD /IfVKEG61BMSQ6HlD7qP9pzmnshu9JHLb5RIBsXRwDDwUcnRywBvJAmkGK2p9rJOswo3 sMciEenPqvANaVOJwiFg/a8Mh6kbg+qIgUlKKGQNZ+XkQqMtmtTbGQoHXYdV9FPgVRb0 lMQA== X-Gm-Message-State: AAQBX9eMjbdmFwhAebI67fU147LaFP1d18s1pixomxG1qeaSuo84TI91 EYq2PSlvS19q0c6RFc7sEXroPejDYAKcYUHuEXE= X-Google-Smtp-Source: AKy350aX1IrjeLCp3DhWDZO2j6Ivid5ZAS7JQR9bu0ctn79lz8KirHLzGEdl2H0ld6rl2mhAAhoCX/qeUl66rn5tCOg= X-Received: by 2002:a05:6871:113:b0:187:9bf2:af63 with SMTP id y19-20020a056871011300b001879bf2af63mr3137297oab.5.1681555332699; Sat, 15 Apr 2023 03:42:12 -0700 (PDT) In-Reply-To: <875y9x5szf.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260022 Archived-At: On Sat, Apr 15, 2023 at 11:40=E2=80=AFAM Philip Kaludercic wrote: > > Eli said something like this patch could be acceptable for master and > > maybe 29.2. > > > > ----------8<----------8<----------8<----------8<----------8<----------8= < > > --- a/lisp/emacs-lisp/package.el > > +++ b/lisp/emacs-lisp/package.el > > @@ -652,6 +652,9 @@ package--builtins > > name (a symbol) and DESC is a `package--bi-desc' structure.") > > (put 'package--builtins 'risky-local-variable t) > > > > +(defvar package--safely-upgradeable-builtins '(eglot use-package) > > + "See bug#62720 for longest docstring ever.") > > + > > (defvar package-alist nil > > "Alist of all packages available for activation. > > Each element has the form (PKG . DESCS), where PKG is a package > > @@ -2201,14 +2204,19 @@ package-install > > (package--archives-initialize) > > (list (intern (completing-read > > "Install package: " > > + (append > > (delq nil > > (mapcar (lambda (elt) > > (unless (package-installed-p (car= elt)) > > (symbol-name (car elt)))) > > package-archive-contents)) > > + package--safely-upgradeable-builtins) > > nil t)) > > nil))) > > (package--archives-initialize) > > + (when-let ((desc (and (memq pkg package--safely-upgradeable-builtins= ) > > + (cadr (assoc pkg package-archive-contents))))) > > + (setq pkg desc)) > > (add-hook 'post-command-hook #'package-menu--post-refresh) > > (let ((name (if (package-desc-p pkg) > > (package-desc-name pkg) > > ---------->8---------->8---------->8---------->8---------->8---------->= 8 > > > > 1. Node code complexity. It's 6 lines of trivial code. > > 2. Absolutely no risk of "silent installation of software that wasn't e= ver > > installed before" > > 3. Fixes all the aforementioned issues > > Personally I think this would be a fine solution considering the > constraints. Me too, of course. Good luck :-) Jo=C3=A3o