unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 71367@debbugs.gnu.org, Andrea Corallo <acorallo@gnu.org>,
	theo@thornhill.no, tsdh@gnu.org
Subject: bug#71367: 30.0.50; ELPA package breadcrumb causes Emacs freeze when editing json file
Date: Thu, 6 Jun 2024 11:07:54 +0100	[thread overview]
Message-ID: <CALDnm508Qf2XBubgPEOQboFWe+ofh8sZXTXsq+yCdsd34cTR2w@mail.gmail.com> (raw)
In-Reply-To: <867cf2ifbp.fsf@gnu.org>

> Maybe João could suggest some trick or user option to cut down that
> initial time to reasonable level.

No, but feel free to profile and suggest Elisp changes or algorithmic
changes.  Maybe the vconcat re-allocations in breadcrumb--ipath-plain
re-allocations are to blame?  It's O(N^2) allocations I think.  What's
the length of bc--ipath-plain?  17500ish?  If so, then the thing would
be to reserve some space in the vector upfront, but I don't know how
to do that easily in Elisp (in CL there's VECTOR-PUSH and
VECTOR-PUSH-EXTEND).  Or maybe the vector could be list instead, though
that would possibly slow down things elsewhere.

I'm of course just guessing and leaving these notes for the curious, I
won't be tackling this myself.

> Failing that, I suggest not to
> enable breadcrumb-mode in such large JSON buffers (something that can
> be done in a mode hook, I guess?)

Yes, there is `breadcrumb-local-mode`.





  reply	other threads:[~2024-06-06 10:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04 19:40 bug#71367: 30.0.50; ELPA package breadcrumb causes Emacs freeze when editing json file Tassilo Horn
2024-06-04 20:49 ` Andrea Corallo
2024-06-05  7:24   ` Tassilo Horn
2024-06-05  9:36     ` Andrea Corallo
2024-06-06  9:35       ` Eli Zaretskii
2024-06-06 10:07         ` João Távora [this message]
2024-06-06 11:33           ` Eli Zaretskii
2024-06-06 11:47             ` João Távora
2024-06-06 12:08               ` Eli Zaretskii
2024-06-06 13:00                 ` João Távora
2024-06-06 13:37                   ` Eli Zaretskii
2024-06-06 14:01                     ` João Távora
2024-06-06 14:29                       ` Tassilo Horn
2024-06-07 21:23 ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDnm508Qf2XBubgPEOQboFWe+ofh8sZXTXsq+yCdsd34cTR2w@mail.gmail.com \
    --to=joaotavora@gmail.com \
    --cc=71367@debbugs.gnu.org \
    --cc=acorallo@gnu.org \
    --cc=eliz@gnu.org \
    --cc=theo@thornhill.no \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).