From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62694: 30.0.50; eglot-tests fails with recent pylsp Date: Thu, 6 Apr 2023 13:49:42 +0100 Message-ID: References: <87sfddibcn.fsf@gmx.de> <87o7o1tfvc.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28427"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62694@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 06 14:51:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkP53-0007Er-8l for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Apr 2023 14:51:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkP4x-00084b-RE; Thu, 06 Apr 2023 08:51:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkP4w-00083i-7o for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2023 08:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkP4v-000245-VH for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2023 08:51:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pkP4v-0000an-Np for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2023 08:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Apr 2023 12:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62694 X-GNU-PR-Package: emacs Original-Received: via spool by 62694-submit@debbugs.gnu.org id=B62694.16807854042042 (code B ref 62694); Thu, 06 Apr 2023 12:51:01 +0000 Original-Received: (at 62694) by debbugs.gnu.org; 6 Apr 2023 12:50:04 +0000 Original-Received: from localhost ([127.0.0.1]:53643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkP3z-0000Ws-PC for submit@debbugs.gnu.org; Thu, 06 Apr 2023 08:50:04 -0400 Original-Received: from mail-oi1-f179.google.com ([209.85.167.179]:34559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkP3v-0000W9-1Y for 62694@debbugs.gnu.org; Thu, 06 Apr 2023 08:50:02 -0400 Original-Received: by mail-oi1-f179.google.com with SMTP id w133so28957036oib.1 for <62694@debbugs.gnu.org>; Thu, 06 Apr 2023 05:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680785393; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LoUfyJdj4ARtOp+zzS0A73BIjwV435rY3KzF5dHJWyg=; b=MNzQgepkBzyKIKFqWS7iADviUn7a05+UafM4MIxfkrumixAv8Mloq1GrR/y+A1OXbK byCooaVFQRvwfmnD3wxFvQTTEYiXEp8U9Nb3aThIZekOMAmgSYoBxZOIOvOLNt4t7Wh3 ba+xy6o5YqjUI4Bbr+g6TXrG6FcvarvYGZEWglyxp91/s/RvodogbEQ32NGsZ4hjBAi3 lYFXTm4XVjeNJOkVORg3HWUzA64b42IwPLcsoz/Xxr/CvgnITlfR8WWgG82jMwro1+aR 7/b4XCvSbStN24IeZC0rJoPws4xPMST4zJdoErefwQck0F6xnpSmICjdF7R4LVGkHGOE 6CEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680785393; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LoUfyJdj4ARtOp+zzS0A73BIjwV435rY3KzF5dHJWyg=; b=QmPPstFkLYigs+VMqqsvy4TaZ8QZcvGriWhUI5qTez9/YpLNQqTbVAtP3T3m2rD/bL cIXW2JL2EwhtbisoX6mq6ALXAQekAi8MOaJBi+8TNBgG3AFqlYhrLNor8BdYoRZK5UjX Y2z6OTDDB3oMHFlxoyOaWgnMgWM30bnXVKnrcu+qE14cp9uwoP39Rb4tU2YBjZXA7Ls2 OJ6hJrBSwCXFIBPdKDEMUEb6SIrpUU1TDh04jgmAhiJCh7fO6XflLZULpITza1LW/ewh N82I9VX48Bin01YVAZjXMMGNZ3fQqkIpiPnpc5OrTi/d6VwYlai3MWzVjEn44OWdn941 T16A== X-Gm-Message-State: AAQBX9eOaT9ZVrvqJrjZHZFj0g1b8WXjPoXlCyeg3sdXLQ4IMqYtG6in UTLnQ44PjibjY2THfA7Uxr4dWhnBwUhp8zj9obE= X-Google-Smtp-Source: AKy350a1qtOYaKVnl7koMEuf+9/9E9jFHDu56KSkQE0mLUXOQLnbWObNBmTJy2xVfyCdUj8MWzX5zcITq4I6sI41gME= X-Received: by 2002:a05:6808:2a0d:b0:389:53dc:cdfd with SMTP id ez13-20020a0568082a0d00b0038953dccdfdmr2959793oib.5.1680785393018; Thu, 06 Apr 2023 05:49:53 -0700 (PDT) In-Reply-To: <87o7o1tfvc.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259323 Archived-At: On Thu, Apr 6, 2023, 12:22 Michael Albinus wrote: > > Instead of using your distribution package manager, I recommend > > installing pylsp via the official Python package manager, pip, and > > doing it like so: > > > > pip install "python-lsp-server[all]" > > I disagree. Running regression tests towards bleeding edge development > version of pylsp is not the intention. You cannot expect, that everybody > running Emacs tests has installed pylsp like this. But she could have > installed the Debian pylsp package. Sure, or she has a 'pylsp' that prints the complete works of Shakespeare. But these tests are designed for the number one recommended pylsp installation method. It's AFAIK not the "bleeding edge" (which would be a Git installation). And tests have been running fine with that installation method for a number of months now, maybe even years. > I have used the most recent pylsp package from Debian. If it doesn't > cooperate with eglot, we have a problem. We? I'd say Debian has, right? I don't have anything against it, quite the contrary, but I don't have Debian, and I don't program against it (that's also a reason why I can't debug this right now). As I explained, eglot-tests.el, is just testing eglot.el's logic and pylsp happens to be an easy server to install in most operating systems that exercises some of eglot.el's functionality. I can probably switch to tests to use some other server, maybe one whose Debian package is more well-behaved, but this is hardly a priority for me. What/whose problem or scenario are you trying to solve? Who is this hypothetical she-user and what is she trying to do? Develop Emacs, develop Eglot, run eglot tests, use Eglot with python? All/some of the above? What is preventing you or her from installing this external tool using its recommended installation method? Does Debian's python not carry its 'pip' package manager? Why do you want to install it, and why do you want to install it specifically like this? > I recommend that you investigate why the tests fail. And if this sounds > too much, at least the sanity checks shall be improved. (skip-unless > (executable-find "pylsp")) doesn't seem to be sufficient then. I don't have Debian. We can overhaul the sanity checks, but I don't immediately see how. Or why. So it's hardly a priority. Jo=C3=A3o