From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#47711: bug#48841: bug#47711: bug#48841: bug#47711: [PATCH VERSION 2] Add new `completion-filter-completions` API and deferred highlighting Date: Fri, 27 Oct 2023 00:52:06 +0100 Message-ID: References: <3d3f894f-a6fa-53ae-5d50-c3aa9bffc73e@daniel-mendler.de> <56ab18b1-4348-9b2c-85bb-af9b76cd429a@daniel-mendler.de> <328f87eb-6474-1442-e1ca-9ae8deb2a84a@yandex.ru> <83fsvcbio7.fsf@gnu.org> <9f432d18-e70f-54c1-0173-1899fb66d176@gutov.dev> <877cnafv39.fsf@gmail.com> <8734xy73n7.fsf@gmail.com> <87zg05awbw.fsf@gmail.com> <2703531c-333f-c4a1-837b-c151ef3fd57d@gutov.dev> <87v8atarsf.fsf@gmail.com> <785a64d1-80cd-571f-126b-594ba69f2e56@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3663"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Daniel Mendler , Eli Zaretskii , Stefan Monnier , 47711@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 27 01:50:51 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qwA7n-0000oF-5N for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Oct 2023 01:50:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qwA7V-0007kC-6d; Thu, 26 Oct 2023 19:50:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwA7T-0007jk-Md for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2023 19:50:31 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qwA7T-0000TF-BR for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2023 19:50:31 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qwA7y-0002RM-9s for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2023 19:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Oct 2023 23:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47711 X-GNU-PR-Package: emacs Original-Received: via spool by 47711-submit@debbugs.gnu.org id=B47711.16983642069305 (code B ref 47711); Thu, 26 Oct 2023 23:51:02 +0000 Original-Received: (at 47711) by debbugs.gnu.org; 26 Oct 2023 23:50:06 +0000 Original-Received: from localhost ([127.0.0.1]:34701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwA74-0002Px-0j for submit@debbugs.gnu.org; Thu, 26 Oct 2023 19:50:06 -0400 Original-Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]:59878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwA6r-0002Oo-Ev for 47711@debbugs.gnu.org; Thu, 26 Oct 2023 19:49:54 -0400 Original-Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-507adc3381cso2208870e87.3 for <47711@debbugs.gnu.org>; Thu, 26 Oct 2023 16:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698364156; x=1698968956; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=q/KZMNRS24o04AwjPPPYHDQomX9rImjXc+1Hk+DQtVs=; b=LLPk0NER+zbLGv20qLkH19MIghAeLSxwVUqZD2W4OeDXwugk2kyJ/n7DnMrH/Da+eh fogCQXRx6fVbZ49L2D+xKNQpdGHrxpD1x7BOPyOsyXSWbfJ/sm22Erip3LdxtG7zoBdN E6kp5MOwQ/+HdqUm1wtLM51wY7SMMiZI9vD0lhMp29/+5RpfwGcrbQBfhoajBZGpfQoE IgGJgAlSTYrEL+nOSoWUD7Ec+rID8BdzouCdC72/bAhg+EVVL/JTJm/cGHxwnQcf9kkA zIx+NSXcy/srJnaxRxfMqs2s1bkfoYHKXWZ4ezCpWYdNdvu3hQKe1W/67MQGD02QBb6Q SfKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698364156; x=1698968956; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q/KZMNRS24o04AwjPPPYHDQomX9rImjXc+1Hk+DQtVs=; b=H9krQR/WBU/HW1HUDy33wvujOrBd53yShuDL5DZjOroXVWb5rwHIG5W/gOhgc77dzf nFY+h5rv4ixLJNryQGZRgCWxtaWSXRqAIGuRLXoGl++6PxI5Nr1gL+IFgN4WvjdM+X2r GpXp5jVkkqbLeO8zmKG4nU+PrGWU0TqCN1FeAJ1p8HwR6RnPyqjIkdZkGOQRFB03Q6fE /FtFB7CrKEeixjUU7un9oqjlsvtVZ8A7UDvsixpQAi0GMUPUrdC60IDZ2Oc4uP3JANiT mbHDUju24SWyebRotz1qXOULj2AcXQBjwtgI62fyDTFkY/aqM5ZbLKVvhG4Qpla2CRBC JOdw== X-Gm-Message-State: AOJu0Yw7WryLG7LP9E8oB/UuIbrHZehRKF123CkisFUAfGl9RkSrCzTv A6eSNUbQszMN+OFCF8vNm6TuAqdLoRcQAjmr8jo= X-Google-Smtp-Source: AGHT+IHRapnXKZSr87ikToJEEYUSwHvjgqWnDmzYWYfXlyq1RWwONyfLFMNPhPLsOGYIlIdOFooO4mf6uE8xEq9+8t0= X-Received: by 2002:ac2:4adc:0:b0:500:7685:83d with SMTP id m28-20020ac24adc000000b005007685083dmr519005lfp.48.1698364156314; Thu, 26 Oct 2023 16:49:16 -0700 (PDT) In-Reply-To: <785a64d1-80cd-571f-126b-594ba69f2e56@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273327 Archived-At: On Fri, Oct 27, 2023 at 12:35=E2=80=AFAM Dmitry Gutov wr= ote: > > On 27/10/2023 02:27, Jo=C3=A3o T=C3=A1vora wrote: > > Dmitry Gutov writes: > > > >> My understanding is it's due to the judicious call (copy-sequence > >> orig) that you added before 'put-text-property' is called. While it > >> seems like a good idea to preserve the original value, when almost all > >> of obarray matches the current input (which is the current scenario), > >> a lot of strings will be copied. > > You're right, I reproduced the regression. I thought I had taken out > > the copy-sequence, but forgot it there. In an earlier stage I suspecte= d > > that I needed the copy, but I don't think I do. Please try this new > > patch that removes it. I've also pushed it to the > > feature/completion-lazy-hilit branch. > > Yep, without copy-sequence the regression is gone. Now the input strings > are routinely mutated, though. ;-( Not sure what you mean by mutated, the strings look fine to me, does this make any visible problem? I couldn't detect it. Jo=C3=A3o