From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#72824: Eglot highlights matches incorrectly wrt case sensitivity Date: Tue, 27 Aug 2024 15:36:49 +0100 Message-ID: References: <05924929-997f-4d37-ba3b-a4620a687c03@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40630"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72824@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 27 16:37:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sixK1-000ANX-Ei for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Aug 2024 16:37:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sixJm-0004XB-MI; Tue, 27 Aug 2024 10:37:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sixJl-0004Wy-8I for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2024 10:37:09 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sixJk-0005SS-Vs for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2024 10:37:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=VnfXNCF1KBF4rlWVelRTUGApghL75WzMzCfMoz4kvws=; b=p1jepCAgFlz39L3qZRphy8KVmLq/YWQwe8ajc7O4qldig1gha6Ht5MXTnbsUBTpmkI97FY34OUVM0FH5eX38IvvzLtVxhMbFHwdr+sGXWlkuS7K2F/R9mgjEbhbPiio+11F736mEt6rsEXN/G9EdFtEv47BdHrLTfJJV2ue3KpvLqBly7xdUmag4WvVMSKRa0X80aUYH6q0LOK7LWxnmoQk8BIFHhJ0hNBlqq5P8eB3o5FhyXutF0A7iwziWAQI50+NW93L/JSzHyVl6j/CmtwLi0TejGQF3rk1IYgBc/doqeGO5N6skEmRlmDOrIXX8QEHtOXGlDY5Il7cGC24AlQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sixKb-0006Ta-LY for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2024 10:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Aug 2024 14:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72824 X-GNU-PR-Package: emacs Original-Received: via spool by 72824-submit@debbugs.gnu.org id=B72824.172476945524855 (code B ref 72824); Tue, 27 Aug 2024 14:38:01 +0000 Original-Received: (at 72824) by debbugs.gnu.org; 27 Aug 2024 14:37:35 +0000 Original-Received: from localhost ([127.0.0.1]:47148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sixKB-0006So-0u for submit@debbugs.gnu.org; Tue, 27 Aug 2024 10:37:35 -0400 Original-Received: from mail-oi1-f178.google.com ([209.85.167.178]:48276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sixK8-0006SZ-CI for 72824@debbugs.gnu.org; Tue, 27 Aug 2024 10:37:33 -0400 Original-Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3de13126957so519704b6e.0 for <72824@debbugs.gnu.org>; Tue, 27 Aug 2024 07:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724769333; x=1725374133; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VnfXNCF1KBF4rlWVelRTUGApghL75WzMzCfMoz4kvws=; b=ceRDyvndQpfjtV20viNvDKdMoAiTQ53CJAgQNmdUn7OAHDrzKKR/Vlv5S1r//zXL7W 8z6sm7bqyJd42RqI/62NAhPL1gVYEF8eqQfHsiqKAVWv7G6KQt9fo5llHYwtO5jAH7xg R2xdadmk1dpz8ZDz9vugy3mAy6y6iVAqJAssxIXwTZacR352Y6ZfA6X7x6q6d76pCBPX x57f7tQfdD3hl3k9ZqQ0Q3sVyRUxN0dvmHGlWEiHj9hyqHt+Zo87DczyhKWbUkb2gB4W 14j3wR29RLQBNEq8gOeLJI96ExxB9TLOCTEKX2Pk5jWg0TQX1Qm4nYlakaT7fsLQlrsT I4pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724769333; x=1725374133; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VnfXNCF1KBF4rlWVelRTUGApghL75WzMzCfMoz4kvws=; b=I8S2S/kZKZDqfhMxCX7IY3T2xRvrxsD10SCSi02kswPL5boTPt2yQSdKhA0o9+gir+ hr0zNpaiqz6K0EUlf7+sAsdE8RClXjn2ZDecTi7Z6+jBR4fABSyt1LBoBNmA3xVMavJj ZJWtC4eskD6n/JxkK0nqI6WNsAMgyfa8PKvXZDV1vECYaKfziEI8n44RAH6ukT/FoZfH 4oBe0Z25rLJunrgHnVMpJwV+rM1of+ewswavMoVSSeRU3NnxuRAMzGZTh9NpJiNm00xA 7iXTNB3a+B/IWIKwW651AQpYwL+UIppxR255Qa1oiaXQCCeyHFA34b1+/DJkSA6BWCWe +b4g== X-Gm-Message-State: AOJu0Yz24wVIkq6NOjJQQOBRcrZd8vx2NCcRcky7e2oTNgbCjnmc8WAr yftMmDsMAbAMI5j156AOJ9fFvfP3FKPtJS+i3ufVRXRIYCRCt290edEuPveRE7cXYO7M77FSwR4 NHmd3pQ+tbY67KkZl9sQVeONOL/w= X-Google-Smtp-Source: AGHT+IHgqweb1QvyyUgKNa4WX0bgYbPBrThet+B3ITkIcy4kt3a4TqDCdwEbFwPc6Nby9AueRy0pCMY2xpjdX/gVwTg= X-Received: by 2002:a05:6808:6486:b0:3d9:e1d1:1580 with SMTP id 5614622812f47-3de2a870544mr12178745b6e.21.1724769333482; Tue, 27 Aug 2024 07:35:33 -0700 (PDT) In-Reply-To: <05924929-997f-4d37-ba3b-a4620a687c03@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290827 Archived-At: I think the fix makes sense. Please push it to Emacs 30, and thanks in advance. If you can please use this format for the commit message subject, which is my more or less usual practice. Eglot: fix the frobnication (bug#12345) * lisp/progmodes/eglot.el (eglot-foo): pass foo to eglot-bar. On Tue, Aug 27, 2024 at 2:41=E2=80=AFAM Dmitry Gutov wro= te: > > X-Debbugs-Cc: joaotavora@gmail.com > > 1. Server gopls, for example. > 2. completion-ignore-case=3Dnil, its default value. > 3. Input "clCe" and completions for it like > > clockCenterX > clockCenterY > > Completions are case-sensitive, but completions' highlighting works as > if it's insensitive - highlights are on "cl", second "c" and "e", > whereas the capital "C" is not highlighted. > > This fixes it for me: > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index 844fc634be9..acc197754db 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -3260,7 +3260,7 @@ eglot-completion-at-point > (try-completion pattern (funcall proxies))) > ((eq action t) ; all-completi= ons > (let ((comps (funcall proxies))) > - (dolist (c comps) (eglot--dumb-flex pattern c t)) > + (dolist (c comps) (eglot--dumb-flex pattern c > completion-ignore-case)) > (all-completions > "" > comps > > > --=20 Jo=C3=A3o T=C3=A1vora