From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#52342: [PATCH] Add Texinfo support for Flymake Date: Tue, 4 Jan 2022 21:00:04 +0000 Message-ID: References: <3948b4c7-bd61-e2f8-6b02-6057631139cb@protonmail.com> <10e97159-488f-2ade-52fa-82a0708d7237@protonmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000092765805d4c7eceb" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26698"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Okamsn , Stefan Kangas , 52342@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 04 22:01:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n4qve-0006lz-K9 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Jan 2022 22:01:10 +0100 Original-Received: from localhost ([::1]:58040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4qvd-00059s-7N for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Jan 2022 16:01:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4qvW-00058Z-Og for bug-gnu-emacs@gnu.org; Tue, 04 Jan 2022 16:01:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55559) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n4qvW-00009s-Eq for bug-gnu-emacs@gnu.org; Tue, 04 Jan 2022 16:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n4qvW-00012D-0j for bug-gnu-emacs@gnu.org; Tue, 04 Jan 2022 16:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jan 2022 21:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52342 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52342-submit@debbugs.gnu.org id=B52342.16413300243924 (code B ref 52342); Tue, 04 Jan 2022 21:01:01 +0000 Original-Received: (at 52342) by debbugs.gnu.org; 4 Jan 2022 21:00:24 +0000 Original-Received: from localhost ([127.0.0.1]:38872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4quu-00011E-Ia for submit@debbugs.gnu.org; Tue, 04 Jan 2022 16:00:24 -0500 Original-Received: from mail-pj1-f52.google.com ([209.85.216.52]:34618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4qus-00010y-6Q for 52342@debbugs.gnu.org; Tue, 04 Jan 2022 16:00:23 -0500 Original-Received: by mail-pj1-f52.google.com with SMTP id v13-20020a17090a088d00b001b0e3a74cf7so2308985pjc.1 for <52342@debbugs.gnu.org>; Tue, 04 Jan 2022 13:00:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ftQb/2bgcWS5q4DP6AXIZjBCG1t/AfCr/Okfji3Iy/w=; b=njKphazhAgGN7gX9WiApZHXCPgs4difKUh32EFe0zVGFchtFtidPEeVHSnQKYe8Krz zaQN6ny70OzAHYSMj6ZVIH7BhwOldfZBMpUR6sa2I39ulqUu+vEuEz06uupxZoit/eZ/ lBIrLHTkI8CipghZZWcDsK6xKRFPV2/b1Ozx+selwf41Gc6UlnmLW2/VhRHCZFrMFWo6 M2QpQ/b23cj7AFZj0q5kWYGbjF7uOye+kcNL+oX3N0DdpIgwoiapljuzjIPTiiDydOPG bAKmfRNLl5qIn9Y26X8WBHIv1RDZh++SH5k0RLNNtDcZBeedA75UNzQk1Dw4PuYZNggL cfww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ftQb/2bgcWS5q4DP6AXIZjBCG1t/AfCr/Okfji3Iy/w=; b=m4+z3TM8POqFm7v0ibnMXTqrHAjeUf2Jd5MNOvBVm2KVqqBzniLwI+qLkExVRguw1v u60CAOfaenFR4M0zoOKVWdYADLfF/cusKIkQH4k6CGjF9MJGjPWp3BLeCOgtrWLDVY/i wvsTHiPqwvnmtKoMX0TY+RDoaTvRmq0BQbL6crOeT/gem7NuV8PASy4wOegbqnMdxuQA CikH+Er1/TR5ARg5DKuyuQtvC0A1frCRTmJNu9Rb0hMpmnv4qatmKEQBRDMSFItd24DY C6iligrBsWaNyW6nC2uVkw1rFV2g0qk0l4BwzAh/3yjwCqJT+nr/7FGEmcO3UCbnRFCl 1zSw== X-Gm-Message-State: AOAM530NCt/FHdxy2PpCUY2yCNu3DicNQGIAhAZFtanEVJk6z/1u+BRa u76imvXxkVF1mboDyDA5WKUknhjEh7BNEJb2rdQ= X-Google-Smtp-Source: ABdhPJw32yoQ3vdqtoDoCTYPe6Xa5wjh1wt+kOOnofQxA7nacHMJpCXeajQxCadMhe5SF6z+Rf9B3A3vNSU2fU6kD2o= X-Received: by 2002:a17:903:1210:b0:149:8d21:3e43 with SMTP id l16-20020a170903121000b001498d213e43mr34467381plh.83.1641330016153; Tue, 04 Jan 2022 13:00:16 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223665 Archived-At: --00000000000092765805d4c7eceb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jan 4, 2022 at 8:21 PM Stefan Monnier wrote: > Sorry for this late answer, you got stuck in a slow lane :-( > > > Do you have any thoughts about the lazy loading of Flymake features use= d > > in the patch discussed in this thread (re-attached for convenience)? > > Looks fine to me. > [ The amount of work needed for `flymake-log` is a bit disheartening, tho= . > Not sure making it a macro is worth the trouble. ] Yup, I wrote somewhere else that I think that part is a bit over-enginneered. The idea was/is to have it add the locus of the log call to the log entry. But I don't remember ever having used that functionality. So go ahead and make it an (autoloaded) function if you think it's best. Jo=C3=A3o --00000000000092765805d4c7eceb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Jan 4, 2022 at 8:21 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
=
Sorry for this late answe= r, you got stuck in a slow lane :-(

> Do you have any thoughts about the lazy loading of Flymake features us= ed
> in the patch discussed in this thread (re-attached for convenience)?
Looks fine to me.
[ The amount of work needed for `flymake-log` is a bit disheartening, tho.<= br> =C2=A0 Not sure making it a macro is worth the trouble.=C2=A0 ]

Yup, I wrote somewhere else that I think that part is = a bit over-enginneered.
The idea was/is to have it add the locus = of the log call to the log entry.
But I don't remember ever h= aving used that functionality.

So go ahead and mak= e it an (autoloaded) function if you think it's best.

Jo=C3=A3o
--00000000000092765805d4c7eceb--