From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server Date: Thu, 10 Nov 2022 21:59:37 +0000 Message-ID: References: <8cf8ba5d-c604-b2dc-274a-7597b19fb73f@dfreeman.email> <87ilk5xq01.fsf@gmail.com> <87r0yrwfn3.fsf@gmail.com> <37716e41-5955-99f6-5204-e760a716fbf6@yandex.ru> <9bb290c8-f000-31d8-265d-b5441c33eb38@dfreeman.email> <4d50b820-7053-75eb-5b11-d3d36a02b013@dfreeman.email> <87v8nxsrq6.fsf@gmail.com> <87cza40xgs.fsf@dfreeman.email> <83edubrvf0.fsf@gnu.org> <87cz9v9irh.fsf@gmail.com> <83o7terf9a.fsf@gnu.org> <87k042tqze.fsf@dfreeman.email> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c0add305ed24dfde" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5166"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , dgutov@yandex.ru, felician.nemeth@gmail.com, 58790@debbugs.gnu.org, stefankangas@gmail.com To: Danny Freeman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 10 22:59:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otFZq-000199-VD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Nov 2022 22:59:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otFZg-0005sP-W4; Thu, 10 Nov 2022 16:59:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otFZe-0005rs-Or for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 16:59:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otFZe-0000TG-Gd for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 16:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otFZe-000556-9i for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 16:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Nov 2022 21:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58790 X-GNU-PR-Package: emacs Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.166811752019505 (code B ref 58790); Thu, 10 Nov 2022 21:59:02 +0000 Original-Received: (at 58790) by debbugs.gnu.org; 10 Nov 2022 21:58:40 +0000 Original-Received: from localhost ([127.0.0.1]:44564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otFZH-00054X-IP for submit@debbugs.gnu.org; Thu, 10 Nov 2022 16:58:39 -0500 Original-Received: from mail-oa1-f47.google.com ([209.85.160.47]:45641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otFZF-00054J-Qm for 58790@debbugs.gnu.org; Thu, 10 Nov 2022 16:58:38 -0500 Original-Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-13be3ef361dso3605225fac.12 for <58790@debbugs.gnu.org>; Thu, 10 Nov 2022 13:58:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YbAZCXTjnEXcI9lnOcmW+Kraxv82tUXYkzSKbslatKs=; b=SWBv7Ni4Dcg50rUdQFRhu7fahyoEERJjpsVMDdPT737DTOJbd6vfuWoz+HJDuR+cWk uVCzevOi69m6rEVGn4vOu8e+w+oM428cvXMLjgv8/LNlczjJJ5tkbu+m5rfhIwBpfKZF cg0XG2/G3/sKXHMB8J2xHqGEtazgeFxB0PRWUg4uuCnYqneKEbZUjuOHtJVpJqKSGB9X T3AINuNDxAWoy5hc8LW+r7PW7HjMzAGNbGAtwR3tqRG9SqoG/neqS+XzxDMEiFz5QeKg Fyn4o+wOdk3biH1c+WNtU8Mn8rreN3vUF44qajFUofdncpFnNLzeEuM4o5+SMhJfinSm NT9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YbAZCXTjnEXcI9lnOcmW+Kraxv82tUXYkzSKbslatKs=; b=kPQ2vMMop3lOGAFCLe1AvlzoU1MP3NyY7kPPO1cSrOX8co7bwqVvnkJ/Bpf3rLRSTA +mchFKph+o1A1zTRp2IDD++6CbTpfNkfVDngpnMw9baoVY7lvqOc4faSDPxBU2Iulhc8 cw7kQNYgBWaH4CPwryX7TtxKC20Qr1IwtInkvmQmnyJrJMIwvgKfcx5KORp0l8r6Y9p/ 47nQCGCrfxeitzgDBmhOwNiLfG3HK+h4gkOs58mK+gmS/i7uVhQoiBlVHfgSdwmbksp+ ISyMMFWBI+8fdg/8OTWGzfWc6yRfYxKwgh7Co0uHHjdMWEILL1hggTk9yuRGKpv+RVZJ SjRg== X-Gm-Message-State: ACrzQf1EuwnH9M6QEr54l4tkXricJQvTcJTqXLhyXj5NtirRMnXllLuj R/UNJyJWxAPZlIOuE6y7QzSFfMGlQAtWwhCnGPY= X-Google-Smtp-Source: AMsMyM7N9BHSfvEjmKz/YuSd93LaHjOiUvATl//Qp1nbaOhqqM+M4dQGIF/MIOFcbfqlq78Mjek6k5XNtN0A0pS5qC4= X-Received: by 2002:a05:6870:2402:b0:132:a103:ae22 with SMTP id n2-20020a056870240200b00132a103ae22mr2332475oap.215.1668117512104; Thu, 10 Nov 2022 13:58:32 -0800 (PST) In-Reply-To: <87k042tqze.fsf@dfreeman.email> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247554 Archived-At: --000000000000c0add305ed24dfde Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I agree on the two comments about the ChangeLog style entries and the spacing. But when dealing with eglot.el, which I am the prime maintainer of, I really prefer to see design described in the commit message where the design was introduced. It plays very well with vc-region-history. So Danny, if you don't mind, please revert that part. Jo=C3=A3o On Thu, Nov 10, 2022 at 9:54 PM Danny Freeman wrote: > > Eli Zaretskii writes: > > > > > OK, then I have a few minor comments, before this can be installed: > > > > This lacks ChangeLog-style parts which specify the file(s) and > > function(s) which were changed. > > Thanks for your patience, I believe I've got that corrected now. See the > attachments. > > > Also, in the text above, please leave two spaces between sentences, > > per our conventions, and refill the text to be at most 63 columns. > > I cut it down to 63. I don't mind either way, but thought I would > mention that the CONTRIBUTE file mentions 79 columns, which is what I > normally default to in commit messages. > > >> The file-name-operation being checked, any-handler, has no significant > >> meaning, other than that it is not one that would be suppressed by > >> inhibit-file-name-operation. We just want to check that a handler exis= ts > >> and has the potential to handle this URI, not actually dispatch a > >> file-name-operation right now. > > > > Same here. And in this case, the text should definitely be in > > comments. > > Done!!! > > > > Thank you, > -- > Danny Freeman > --=20 Jo=C3=A3o T=C3=A1vora --000000000000c0add305ed24dfde Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I agree on the two comments about the ChangeLog style= entries and the
spacing.=C2=A0

But= when dealing with eglot.el, which I am the prime maintainer of,
=
I really prefer to see design described in the commit message where th= e
design was introduced. It plays very well with vc-region-h= istory.

So Danny, if you don't mind, pleas= e revert that part.=C2=A0

Jo=C3=A3o
=
On Thu= , Nov 10, 2022 at 9:54 PM Danny Freeman <danny@dfreeman.email> wrote:=

Eli Zaretskii <eliz@gn= u.org> writes:

>
> OK, then I have a few minor comments, before this can be installed: >
> This lacks ChangeLog-style parts which specify the file(s) and
> function(s) which were changed.

Thanks for your patience, I believe I've got that corrected now. See th= e
attachments.

> Also, in the text above, please leave two spaces between sentences, > per our conventions, and refill the text to be at most 63 columns.

I cut it down to 63. I don't mind either way, but thought I would
mention that the CONTRIBUTE file mentions 79 columns, which is what I
normally default to in commit messages.

>> The file-name-operation being checked, any-handler, has no signifi= cant
>> meaning, other than that it is not one that would be suppressed by=
>> inhibit-file-name-operation. We just want to check that a handler = exists
>> and has the potential to handle this URI, not actually dispatch a<= br> >> file-name-operation right now.
>
> Same here.=C2=A0 And in this case, the text should definitely be in > comments.

Done!!!



Thank you,
--
Danny Freeman


--
Jo=C3=A3o T=C3=A1vora
--000000000000c0add305ed24dfde--