From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#48073: 27.2; [Eglot] Don't bind `completion-styles' buffer locally? Date: Tue, 27 Apr 2021 20:31:43 +0100 Message-ID: References: <871rav4jri.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a4c46705c0f950dc" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34460"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48073@debbugs.gnu.org To: Augusto Stoffel , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 27 21:33:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbTSL-0008rP-Vl for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Apr 2021 21:33:14 +0200 Original-Received: from localhost ([::1]:36928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbTSL-00075z-0i for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Apr 2021 15:33:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbTSA-0006zr-3k for bug-gnu-emacs@gnu.org; Tue, 27 Apr 2021 15:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39426) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbTS9-0003Ug-N1 for bug-gnu-emacs@gnu.org; Tue, 27 Apr 2021 15:33:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lbTS9-0005p7-IA for bug-gnu-emacs@gnu.org; Tue, 27 Apr 2021 15:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Apr 2021 19:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48073 X-GNU-PR-Package: emacs Original-Received: via spool by 48073-submit@debbugs.gnu.org id=B48073.161955192522318 (code B ref 48073); Tue, 27 Apr 2021 19:33:01 +0000 Original-Received: (at 48073) by debbugs.gnu.org; 27 Apr 2021 19:32:05 +0000 Original-Received: from localhost ([127.0.0.1]:50972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbTRF-0005nu-A4 for submit@debbugs.gnu.org; Tue, 27 Apr 2021 15:32:05 -0400 Original-Received: from mail-io1-f44.google.com ([209.85.166.44]:45801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbTRB-0005nM-HA for 48073@debbugs.gnu.org; Tue, 27 Apr 2021 15:32:04 -0400 Original-Received: by mail-io1-f44.google.com with SMTP id z14so8239043ioc.12 for <48073@debbugs.gnu.org>; Tue, 27 Apr 2021 12:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DYFENYJHaECY1S/55bBue/1VwGH6fiiYUq0uLrUSoG0=; b=g5XoK4zTNDHQgYBL2Y7CKc324c300Pbx9RK/6OHIpKTc65nvpiNFkwJQgi32iEU9+A dCZUqThzSqkvKd0rL8yJ22wTA71gVSRUKH6rhp+5LPXm4S8GBwYYmOoUGB5oA305DaXC xap6PWh/SLEyCl0fPy8/pZgk61zAFcT/lDPriZW7R8udtPCYbq7Xr2tPgBpx5WqAwQjU n92C9+VtOOMm2lKOZSfHz4mhTZFFfAq2SY117uYz1gSohdq3gUA0Gs+I608lua3glv/M E2WamFu4gskS4xcTCG5RWWViw16BLVrS6olJmSEYSfeptBovFHV2lqfe0A9RkGwTS457 TUgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DYFENYJHaECY1S/55bBue/1VwGH6fiiYUq0uLrUSoG0=; b=dFG5nKuKN+l4Uqh/1P49dvB7rdko1Z/wa2vJa/Hsxl0kiyytxOdbyk+qzJ07E7QrF5 2DhnMWik1/b9ZDU73xxNeCmK0vywZmR1H7ospRdbREZun8byrNdjXotU+5af7nq6YtAk KGJfgkDWMtfAPXHSRu2xxsQgjf+BbrMy+oJed4gEX/8MWDsjKbV0DvYDxhtVEe9ODJ5g BPqx7quWcyLGpte3FVA8Cg6azVxk6mmML3g2TVeY8TIpoYecoBHB8AR230BYY4ZBzoFO MWJcdSgDPMhDOKX/DdIcDSycRRZAPZ7OmpqyHUM6pqGq1RPOHgs0r5gPIvYp1JX9pSyZ YLrA== X-Gm-Message-State: AOAM5322RpkeVw1CNCsltSjXJdguQpmpy73dMFfEBAq/6oF7C0ZUIAZs EDqUly1/8yv88gQHFymQwxSJJlO3lERrvB8ciek= X-Google-Smtp-Source: ABdhPJxPR0dERWZDWEZOdZd8npNE+COCv/dIUAvkqEw2Gv367jNKleyKvLkBFI3RtxXOWGemmD5KKc98Wglawf9QMgY= X-Received: by 2002:a6b:2d0:: with SMTP id 199mr20932902ioc.156.1619551915917; Tue, 27 Apr 2021 12:31:55 -0700 (PDT) In-Reply-To: <871rav4jri.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205052 Archived-At: --000000000000a4c46705c0f950dc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Apr 27, 2021 at 8:21 PM Augusto Stoffel wrote= : > Binding `completion-styles' buffer locally can lead to problems on > alternative completion UIs, say if the minibuffer is involved (this used > to happen with Consult's compeltion in region until recently). > > It seems that a more appropriate way to override the completion style > would be to include a category in the completion table metadata, and add > a corresponding entry to `completion-category-defaults', which can be > done globally. > Hi Augusto, Yes, I think you are right about this. And then Eglot's completion table would use use a category that points to the style? Is that the idea? The end goal is not to lose flex-style completion for LSP-servers. If so, can you draft a patch and attach it to your reply? By the way, thanks for inaugurating the Emacs bug tracker for Eglot bugs. Also CCint Stefan Monnier since he usually has insight about this. Jo=C3=A3o --000000000000a4c46705c0f950dc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Apr 27, 2021 at 8:21 PM Augusto Stoffel <arstoffel@gmail.com> wrote:
Bi= nding `completion-styles' buffer locally can lead to problems on
alternative completion UIs, say if the minibuffer is involved (this used to happen with Consult's compeltion in region until recently).

It seems that a more appropriate way to override the completion style
would be to include a category in the completion table metadata, and add a corresponding entry to `completion-category-defaults', which can be done globally.

Hi= Augusto,

Yes, I think you are right about this.= =C2=A0 And then Eglot's completion table would use
use a cate= gory that points to the style? Is that the idea?=C2=A0 The end goal=C2=A0 i= s not to
lose flex-style completion for LSP-servers.

If so, can you draft a patch and attach it to your re= ply? By the way, thanks for
inaugurating the Emacs bug track= er for Eglot bugs.

Also CCint Stefan Monnier since= he usually has insight about this.

Jo=C3=A3o
<= /div>



=C2=A0
--000000000000a4c46705c0f950dc--