From: "João Távora" <joaotavora@gmail.com>
To: Augusto Stoffel <arstoffel@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 48073@debbugs.gnu.org
Subject: bug#48073: 27.2; [Eglot] Don't bind `completion-styles' buffer locally?
Date: Tue, 27 Apr 2021 20:31:43 +0100 [thread overview]
Message-ID: <CALDnm502VBA0b0H1iGfoiPvkucF0gmrcaCwKB7ZPC4DGNSN6+A@mail.gmail.com> (raw)
In-Reply-To: <871rav4jri.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 987 bytes --]
On Tue, Apr 27, 2021 at 8:21 PM Augusto Stoffel <arstoffel@gmail.com> wrote:
> Binding `completion-styles' buffer locally can lead to problems on
> alternative completion UIs, say if the minibuffer is involved (this used
> to happen with Consult's compeltion in region until recently).
>
> It seems that a more appropriate way to override the completion style
> would be to include a category in the completion table metadata, and add
> a corresponding entry to `completion-category-defaults', which can be
> done globally.
>
Hi Augusto,
Yes, I think you are right about this. And then Eglot's completion table
would use
use a category that points to the style? Is that the idea? The end goal
is not to
lose flex-style completion for LSP-servers.
If so, can you draft a patch and attach it to your reply? By the way,
thanks for
inaugurating the Emacs bug tracker for Eglot bugs.
Also CCint Stefan Monnier since he usually has insight about this.
João
[-- Attachment #2: Type: text/html, Size: 1474 bytes --]
next prev parent reply other threads:[~2021-04-27 19:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 19:20 bug#48073: 27.2; [Eglot] Don't bind `completion-styles' buffer locally? Augusto Stoffel
2021-04-27 19:31 ` João Távora [this message]
2021-04-27 20:37 ` Stefan Monnier
2021-04-27 21:10 ` João Távora
2021-04-27 22:37 ` Stefan Monnier
2021-04-27 22:42 ` João Távora
2021-04-27 23:13 ` Stefan Monnier
2021-04-28 7:00 ` Augusto Stoffel
2021-04-28 12:03 ` João Távora
2021-04-27 21:01 ` bug#48073: [External] : " Drew Adams
2021-04-27 21:53 ` João Távora
2021-04-27 22:06 ` Drew Adams
2021-04-27 22:10 ` João Távora
2021-04-27 22:12 ` João Távora
2021-04-28 16:10 ` Drew Adams
2021-04-28 16:13 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm502VBA0b0H1iGfoiPvkucF0gmrcaCwKB7ZPC4DGNSN6+A@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=48073@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).