From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#70036: a fix that Date: Thu, 18 Apr 2024 18:27:39 +0100 Message-ID: References: <86y19ad61t.fsf@gnu.org> <86sezid4gp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29563"; mail-complaints-to="usenet@ciao.gmane.io" Cc: felician.nemeth@gmail.com, 70036@debbugs.gnu.org, theo@thornhill.no To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 18 19:28:58 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rxVZC-0007QX-5T for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Apr 2024 19:28:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxVZ5-0001wp-6j; Thu, 18 Apr 2024 13:28:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxVZ3-0001wZ-7j for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 13:28:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxVZ2-0003YK-W3 for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 13:28:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rxVZG-0005Ax-HJ for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 13:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Apr 2024 17:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70036 X-GNU-PR-Package: emacs Original-Received: via spool by 70036-submit@debbugs.gnu.org id=B70036.171346129319545 (code B ref 70036); Thu, 18 Apr 2024 17:29:02 +0000 Original-Received: (at 70036) by debbugs.gnu.org; 18 Apr 2024 17:28:13 +0000 Original-Received: from localhost ([127.0.0.1]:53614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxVYR-00054n-O3 for submit@debbugs.gnu.org; Thu, 18 Apr 2024 13:28:13 -0400 Original-Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:57847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxVYQ-00053j-8Z for 70036@debbugs.gnu.org; Thu, 18 Apr 2024 13:28:10 -0400 Original-Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2d8b4778f5fso11151581fa.3 for <70036@debbugs.gnu.org>; Thu, 18 Apr 2024 10:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713461270; x=1714066070; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CCP659ObvLw+FZEw5SXI4JJyr7brnTgJCjjPrdR7Dg0=; b=EtOXD7CmUzB9ElrZFsWJVdusBxXRcxU3Ku3shXYTPMj/Z6MUQYWnHeCKyQQYrzZ0qc rkqVlJyxOJ1tav4G2LT7gYclxC8QoeD70Dx7Ks97OnigNWpjo4Iy4v1SbMB4qnJyHW3M ZwhEqF+fbmWpDCE5NXfrMqt/CmMIet5xMUic3N+RLPXuiw4JE7IziOien5iOGm2943LU j9iQFT8TsvFri1O4/SvKglaZIv/iugmSTPY3zQL2n3U4FGiCeedKNpECLNs9j9TwmI7p YkMX6J3vqnOSIs9TzlzIbABQbTYD5iZXM+TRJWp9s5/7P0M0eo8d5MPwN/gH2g9LUcZY c1Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713461270; x=1714066070; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CCP659ObvLw+FZEw5SXI4JJyr7brnTgJCjjPrdR7Dg0=; b=ZzsHSwjb4sW3u5gcd6Tue62Os3sDWnp/KJQQK7kj7vRibif4USMVEGGMfhU9O8+wfU W53TBzMqhkBScjy5Go3jCwUIcTiYtQAJAjuyT3sHkmQz9ylkBrFTx2waaxaeaYl03wra KyreQxXE+sdAfIgvOzmvkhnfZL8Wr4uTazZGSu6pB/e/XfnbRQwtcpgjy9Dnlfq1v6Eh ZHI0IWfM9KQlVS/4TpbStLPXzsU6uhsLuRXqJyOUYPtX7YzJObHpdTkqAgLW+lDS1JRd lfjgiZeip5+LjHQXoH52sFPQdubc4iv+2R0UCcWKt8KSarE88Vr7WVl+Fr7fNJotZvzV 0mfQ== X-Forwarded-Encrypted: i=1; AJvYcCUC6l4SafKn6g5/wGhYdAdii3WNBxv87tgCom0O4yFNg+amnfbuF4yKiTu5QheseARDDkNepd9sq+m0XsKMZYUUytua1uc= X-Gm-Message-State: AOJu0Ywpf15TbXodWFe3mFN/9n8+8AzhHJYB0jyC4lqVS+3V+8aD9WqL Vr/B0VX0xKRENKes0wYYaUdCGlp+I2QbMx7DCw4Xsng93W8zm187Yotq3y8H5As1kt9FdjN46Hn bIcyX3OFAM//VpYPh84YoBzHOVbgcIdBl X-Google-Smtp-Source: AGHT+IEH2adtBSe6PzfYu/ZOF5BdrBwB4USAExiW2G16sYDTLg5jETM+C8V7C3B9Oi3Rhe4mfZP6msdsbcBHSOrIfxM= X-Received: by 2002:a05:651c:2203:b0:2da:562b:7aa6 with SMTP id y3-20020a05651c220300b002da562b7aa6mr2615418ljq.43.1713461270342; Thu, 18 Apr 2024 10:27:50 -0700 (PDT) In-Reply-To: <86sezid4gp.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283595 Archived-At: On Thu, Apr 18, 2024 at 5:24=E2=80=AFPM Eli Zaretskii wrote: > If you timed this code with the likes of benchmark-run, please show > the timings. Profiles are not the best instrument for this kind of > decisions. I disagree completely, but whatever. It's microbenchmarks that are useless, because they don't have any context. But if you want some of these, here you go. I benchmarked eglot--TextDocumentIdentifier because that's the only reasonable thing I could gather from the profile. ;; before Theodor's patch (benchmark-run 10000 (eglot--TextDocumentIdentifier)) ;; (1.716975213 21 0.8623904230000008) ;; after Theodor's patch (benchmark-run 10000 (eglot--TextDocumentIdentifier)) ;; (0.651663934 11 0.46295383499999687) ;; after I reverted Theodor's patch and added my patch (benchmark-run 10000 (eglot--TextDocumentIdentifier)) ;; (0.000280462 0 0.0) yes, this is just reading a cached variable. Jo=C3=A3o