From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#42149: Substring and flex completion ignore implicit trailing =?UTF-8?Q?=E2=80=98any=E2=80=99?= Date: Wed, 25 Nov 2020 00:01:41 +0000 Message-ID: References: <87k0znsdjb.fsf@gmail.com> <87sgbsv7gg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000007ecf5405b4e32269" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38129"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42149@debbugs.gnu.org, Stefan Monnier To: Dario Gjorgjevski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 25 01:03:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khiHC-0009mV-Vt for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Nov 2020 01:03:15 +0100 Original-Received: from localhost ([::1]:57772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khiHC-0005Q4-0D for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Nov 2020 19:03:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khiH1-0005Pw-0l for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2020 19:03:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50132) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khiH0-0008Nr-B8 for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2020 19:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1khiH0-0007Hr-76 for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2020 19:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Nov 2020 00:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42149-submit@debbugs.gnu.org id=B42149.160626252427941 (code B ref 42149); Wed, 25 Nov 2020 00:03:02 +0000 Original-Received: (at 42149) by debbugs.gnu.org; 25 Nov 2020 00:02:04 +0000 Original-Received: from localhost ([127.0.0.1]:33444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khiG4-0007GZ-6t for submit@debbugs.gnu.org; Tue, 24 Nov 2020 19:02:04 -0500 Original-Received: from mail-io1-f48.google.com ([209.85.166.48]:34908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khiFy-0007Fx-KR for 42149@debbugs.gnu.org; Tue, 24 Nov 2020 19:02:03 -0500 Original-Received: by mail-io1-f48.google.com with SMTP id i9so372308ioo.2 for <42149@debbugs.gnu.org>; Tue, 24 Nov 2020 16:01:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sN+fRfvfRlhVilHghQVT98/cdfZ4XuEmFkP4Azz0TX0=; b=VjrZFy0bVINCMvju8wFN3v4laONlPYRjiYyLV4VcmzCzI2TStf7yW13zJprgNA06ML 3Sq4VekBhG6RcxhbYA7d2Wb0SKmleg2o2wmeyhJ0J8gf1ZzkC/kbKihR9FdU4bajkrAN 2ejahVLxjQ+x1vIOaOxitlp9/Edjsus7zefxDJ0gGwdPkCMqt/E74AY2ec4wHPRWX+Pv WrJ5l1Q4ViLDwN1xhNRMRyuKnOV7JpVDb+kbDpXCm1BucplXYwpFccaZk9xpF1lqOjT8 unOQBe3riIObsam/cjg1Y0Ogc7u7RvUQslf5ZyWhVnkS/8CBIW4qoXI8gHMWgC+o1/wW sAQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sN+fRfvfRlhVilHghQVT98/cdfZ4XuEmFkP4Azz0TX0=; b=ISNyxFi9hKfh67yhs7JZCuRQPQt/9Bjs5oBUdKrpeKv6VGq7yJWgR5zaF0eLzlPpTe 2dezK7ZoPw/LYnoVNfevo/bOjthuTVHhvQTuZUxvM06Jd40EDLFdDB2njLsVuMeVuwaW teX0eEtSX26FJFh7UQYpZqHs4ySKP7l3lxMPTwXhDZ1HJcsBuL2b77ZiGEJyT/txrTKB kZLgtUK3wBsfbi1HikCjgSW5VQCrTc5GKzvPCRsBTAYt0jAVuqkk1pwrnzPfzC09Btzt 9U6XTcNEP38ybDYGIKkiEUIYXUnsiptfL2llJa5v4MuosBQ7kupdU3EE+FMVg/slC5jn KJBQ== X-Gm-Message-State: AOAM532n1P74wpEaOI26VyLNZP+LPud8udb5iDA2P7uDFyGYBTZRuZYx /IOnlQidg/9alovrG2jYlzatpTA4qrumfmu1hS0= X-Google-Smtp-Source: ABdhPJy5Ve74DXziOhYk/swF8Fcz3lFbDB80LqMYpcfF/DxWAxCGI0hKxLaJRxKYPOCtB5IstVT8YNMkJTDJUFgMORw= X-Received: by 2002:a6b:750c:: with SMTP id l12mr642948ioh.57.1606262512864; Tue, 24 Nov 2020 16:01:52 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194140 Archived-At: --0000000000007ecf5405b4e32269 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Dario, I took a better look at your patch finally, but I still don't understand it fully. Don't worry, I will soon. First thing I looked at was the tests you provided, which are very welcome. I restructured them, creating instead 13 small tests instead of just 3 tests that currently fail. Like this I can see exactly what's failing and what's not. 6 of the new tests fail, 7 pass. Tomorrow I'll look at your patch and why it (probably) fixes the 6 failures. The branch I'm doing this work in is called: scratch/bug-42149-funny-pcm-completion-scores I'm the author of one of the commits there and credit you as "Co-author". If you'd rather reverse that, let me know. Jo=C3=A3o On Fri, Nov 20, 2020 at 9:27 PM Jo=C3=A3o T=C3=A1vora wrote: > Indeed, sometimes a bump is needed. I'll have a good look > as soon as possible. > > Jo=C3=A3o > > On Fri, Nov 20, 2020 at 8:39 PM Dario Gjorgjevski < > dario.gjorgjevski@gmail.com> wrote: > >> Just a friendly bump. >> >> Best regards, >> Dario >> >> -- >> $ keyserver=3Dhkps://hkps.pool.sks-keyservers.net >> $ keyid=3D744A4F0B4F1C9371 >> $ gpg --keyserver $keyserver --search-keys $keyid >> > > > -- > Jo=C3=A3o T=C3=A1vora > --=20 Jo=C3=A3o T=C3=A1vora --0000000000007ecf5405b4e32269 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dario,

I took a better lo= ok at your patch finally, but I still
don't understand it ful= ly.

Don't worry, I will soon.=C2=A0 Firs= t thing I looked at
was the tests you provided, which are very we= lcome.
I restructured them, creating instead 13 small tests
<= /div>
instead of just 3 tests that currently fail.

=
Like this I can see exactly what's failing and what's
not.=C2=A0 6 of the new tests fail, 7 pass.=C2=A0

Tomorrow I'll look at your patch and why it (probably)
fixes the 6 failures.

The branch I'm doing th= is work in is called:

scratch/bug-42149-funny-pcm-= completion-scores

I'm the author of one of the= commits there and credit
you as "Co-author".=C2= =A0 If you'd rather reverse that, let
me know.

Jo=C3=A3o

On Fri, Nov 20, 2020 at 9:27 PM Jo=C3=A3= o T=C3=A1vora <joaotavora@gmail.= com> wrote:
Indeed, sometimes a bump is needed.=C2=A0 I'll= have a good look
as soon as possible.

<= div>Jo=C3=A3o

On Fri, Nov 20, 2020 at 8:39 PM Dario Gjorgjevski &l= t;dario.gj= orgjevski@gmail.com> wrote:
Just a friendly bump.

Best regards,
Dario

--
$ keyserver=3Dhkps://hkps.pool.sks-keyservers.net
$ keyid=3D744A4F0B4F1C9371
$ gpg --keyserver $keyserver --search-keys $keyid


--
Jo=C3=A3o = T=C3=A1vora


--
Jo=C3=A3o T=C3=A1vora
--0000000000007ecf5405b4e32269--