From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jonathan Kotta Newsgroups: gmane.emacs.bugs Subject: bug#27362: Bug #27362: Date: Fri, 18 Aug 2017 11:55:53 -0500 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a11494e5ee98a2905570a021c" X-Trace: blaine.gmane.org 1503075432 30598 195.159.176.226 (18 Aug 2017 16:57:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Aug 2017 16:57:12 +0000 (UTC) Cc: 27362@debbugs.gnu.org To: Nathan Moreau Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 18 18:57:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dika1-0007WJ-F8 for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Aug 2017 18:57:05 +0200 Original-Received: from localhost ([::1]:41217 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dika8-0006tT-89 for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Aug 2017 12:57:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dika1-0006sg-QO for bug-gnu-emacs@gnu.org; Fri, 18 Aug 2017 12:57:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dikZy-0005Mz-Pc for bug-gnu-emacs@gnu.org; Fri, 18 Aug 2017 12:57:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35888) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dikZy-0005Mt-LK for bug-gnu-emacs@gnu.org; Fri, 18 Aug 2017 12:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dikZy-0000RB-8c for bug-gnu-emacs@gnu.org; Fri, 18 Aug 2017 12:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jonathan Kotta Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Aug 2017 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27362-submit@debbugs.gnu.org id=B27362.15030754001653 (code B ref 27362); Fri, 18 Aug 2017 16:57:02 +0000 Original-Received: (at 27362) by debbugs.gnu.org; 18 Aug 2017 16:56:40 +0000 Original-Received: from localhost ([127.0.0.1]:44569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dikZc-0000Qb-38 for submit@debbugs.gnu.org; Fri, 18 Aug 2017 12:56:40 -0400 Original-Received: from mail-ua0-f173.google.com ([209.85.217.173]:36735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dikZb-0000QQ-7W for 27362@debbugs.gnu.org; Fri, 18 Aug 2017 12:56:39 -0400 Original-Received: by mail-ua0-f173.google.com with SMTP id k43so37582499uaf.3 for <27362@debbugs.gnu.org>; Fri, 18 Aug 2017 09:56:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=g1f9mUnpewLRfkUjPG7ZyPlWSPegE8UJ4E3uhsksotA=; b=L4Lm2O9GAMeLGO7uDj0H19gNR5fctBzg9st5W+pB0vhMXSYK4DLCwWyLlnhepQzAGz 7Gpy7d0eHkF0cM83fcANemfKZTPXgvbyhqajDqLwnyXiZdW3NIE5I3W8ml1sSEAw3DYr QINtRFY5Feg5039tc5lYPulGatySLSzbgbjOx7S3C29YiaN0DuEm3hHtUzO+eJfo2giC m538epsUmbw8Ud0suQtAm550Gc3Nxzxt99Vtc6HpyAJc4zvuZVhLosovemWJBgXW2h/X fFKLK7uTJr2jpZqh8ybZ5RZypoQm8kJ2xrtgyKZhJMxng0sHqpSwCvwiQg+K6lQ6W6Jr EtjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=g1f9mUnpewLRfkUjPG7ZyPlWSPegE8UJ4E3uhsksotA=; b=ZD7OPLBBVqF01jpkg/5yJ1vlATZBjftTbeIMQUUtzkvRbqShnz/n/JO39EXjRK9x0W Fcwwuap3atm0+JY0CV75BXZOWhRwoUy7vDLrBINMNlmNWemuI7xchnR/V8O+eJeD4NNe KNvJvXsPEpkzkUoRWWY4H5STK3/kdBAE77z3+S3r3bYfRe8/2XTCJtHnATPEVsHQifba FPhGqCDSzwO7Nzm8hoiAOrI86Eh4X6LrrJ1DEtEcyoP8R7nNeS/xDelI/FM6LNCC/hgo KJBSBE6Fhsp9zMhyDZ/H9RaKTo1a0RgIwtwEm8hss4+okRsyDS/nGG8S4At242PbBBvy MAyQ== X-Gm-Message-State: AHYfb5icNNrBu1EjbRngvAWnNre/w+6ayVB2xloelKCYabCLDlf1l3fP 9M3d4cL+z9DobOTDsXQU5dfm9Yluzw== X-Received: by 10.159.54.111 with SMTP id s44mr6525475uad.197.1503075393701; Fri, 18 Aug 2017 09:56:33 -0700 (PDT) Original-Received: by 10.103.45.3 with HTTP; Fri, 18 Aug 2017 09:55:53 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135900 Archived-At: --001a11494e5ee98a2905570a021c Content-Type: text/plain; charset="UTF-8" Yes, that works for me. My workaround was to save the current-buffer after occur-mode-goto-occurrence, and then set-buffer outside the with-current-buffer, but apparently that was overkill. On Thu, Aug 17, 2017 at 4:36 AM, Nathan Moreau wrote: > Here is a patch that fixes the reported problem. > > A minimal reproduction test: > > (ert-deftest totoro () > (set-buffer "*scratch*") > (insert "setq") > (setq next-error-recenter '(4)) > (occur "setq") > (next-error)) > > It seems that occur-mode-goto-occurrence should be called after > restoring the original buffer. > > Nathan > -- Thanks, Jonathan Kotta Hofstadter's Law: It always takes longer than you expect, even when you take into account Hofstadter's Law. --001a11494e5ee98a2905570a021c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, that works for me.=C2=A0 My workaround was to save th= e current-buffer after occur-mode-goto-occurrence, and then set-buffer outs= ide the with-current-buffer, but apparently that was overkill.

On Thu, Aug 17, 2017 at = 4:36 AM, Nathan Moreau <nathan.moreau@m4x.org> wrote:
Here=C2=A0 is a patch that fixes the report= ed problem.

A minimal reproduction test:

(ert-deftest totoro ()
=C2=A0 (set-buffer "*scratch*")
=C2=A0 (insert "setq")
=C2=A0 (setq next-error-recenter '(4))
=C2=A0 (occur "setq")
=C2=A0 (next-error))

It seems that occur-mode-goto-occurrence should be called after
restoring the original buffer.

Nathan



--
Thanks,

Jonathan Kotta

Hofstadter's Law:
=C2= =A0 =C2=A0 It always takes longer than you expect, even
=C2=A0 =C2=A0 wh= en you take into account Hofstadter's Law.
--001a11494e5ee98a2905570a021c--