From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eyal Lotem Newsgroups: gmane.emacs.bugs Subject: bug#22976: 24.5; setting unread-command-events to non cons puts emacs in 100% CPU use Date: Thu, 10 Mar 2016 14:40:24 +0200 Message-ID: References: <838u1qmxz5.fsf@gnu.org> <834mcemxbv.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11468f18557d02052db11eef X-Trace: ger.gmane.org 1457613706 17006 80.91.229.3 (10 Mar 2016 12:41:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Mar 2016 12:41:46 +0000 (UTC) Cc: Andreas Schwab , 22976@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 10 13:41:36 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1adzu5-00080S-NO for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Mar 2016 13:41:21 +0100 Original-Received: from localhost ([::1]:48003 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adzu0-0006fw-5G for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Mar 2016 07:41:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adztr-0006er-W3 for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2016 07:41:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adztm-0002q4-5z for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2016 07:41:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adztm-0002pz-37 for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2016 07:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1adztl-0005Ll-Pg for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2016 07:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eyal Lotem Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Mar 2016 12:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22976 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22976-submit@debbugs.gnu.org id=B22976.145761363320521 (code B ref 22976); Thu, 10 Mar 2016 12:41:01 +0000 Original-Received: (at 22976) by debbugs.gnu.org; 10 Mar 2016 12:40:33 +0000 Original-Received: from localhost ([127.0.0.1]:42384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adztI-0005Ku-Pm for submit@debbugs.gnu.org; Thu, 10 Mar 2016 07:40:33 -0500 Original-Received: from mail-wm0-f47.google.com ([74.125.82.47]:33190) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adztG-0005Kh-Li for 22976@debbugs.gnu.org; Thu, 10 Mar 2016 07:40:31 -0500 Original-Received: by mail-wm0-f47.google.com with SMTP id l68so26915764wml.0 for <22976@debbugs.gnu.org>; Thu, 10 Mar 2016 04:40:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=iz9zLEJVo0Kz5tgQ7JNhForimI79TUGRl5zP32NRqXc=; b=DTrj8lENkg6iBjYwGTLshheKEXgX9gfjzbWL0TL/r2gmUfBQMRu4JmXdpI3ppLXDsh bQkPXJ5aJYT1g6CTvaEzmEtqKvZ7Rvu0vcHSTat08Aa1yvGC72SyhgVOQI6b1boNhhK2 6vvvX+5wcKZT7idNrhXEKVG6bg9Sv59AHkz6UGB9MJS98ZLYPk2B1UNmmId1En9aZfEt Bhv1Ra3nFB+ecLonbYwwD2L9taOeFyiNr4wULQGdjutgW0Hx12JdmjkXTOmzt0O80C2V q4huH0k1mKfJK6DL/3cCZJUl1b7BhnvOytkpUBq0lHhEwxccrU6J2B4+WPoEX2wTGn8f icoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=iz9zLEJVo0Kz5tgQ7JNhForimI79TUGRl5zP32NRqXc=; b=VRhyNvLNJJQaH8GSiqjegpH4weTllYwwIrn30Q2uVxzylAvzrPBLp4Si4Z7YJPxfQl XlIt4XjGmLnxMfizu6tTZDDb5ikUcTMVTd/QAxSfUA7vZ0VVA+BTSDCefeOfBwO5MJBI CMTuyn7s56iezMYpQLfJhSIWh27VKLo1wuyF/hL+UCr+Xj182F6paG6+K/M3Rv/fZPGv fiejMth9lsbfrQnojirs8IRCvc8QY3iCO1oVMVsjnWCMnxQu5n7M2S+SP1CmmPxw/WKu yXht5fNUrlhVNIzbvPKhjAu2vHDZIrVPpE4/9oC2oAif4Oaij43pHO7zUiBz80bZWQyu yWgw== X-Gm-Message-State: AD7BkJKH6vfAxMBLevCrbtwVuwiwPDKAefKQKM4MGkJ8G22I0NUfkS5BT065l1JaJeC29DjT36SpCXjTcMUYrQ== X-Received: by 10.28.217.146 with SMTP id q140mr3521497wmg.85.1457613624930; Thu, 10 Mar 2016 04:40:24 -0800 (PST) Original-Received: by 10.28.94.66 with HTTP; Thu, 10 Mar 2016 04:40:24 -0800 (PST) In-Reply-To: <834mcemxbv.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114704 Archived-At: --001a11468f18557d02052db11eef Content-Type: text/plain; charset=UTF-8 On Thu, Mar 10, 2016 at 12:39 PM, Eli Zaretskii wrote: > > Date: Thu, 10 Mar 2016 12:34:08 +0200 > > From: Eyal Lotem > > Cc: Andreas Schwab , 22976@debbugs.gnu.org > > > > It can be set to any value at all, unfortunately. > > That's not what I asked. I asked whether non-nil, non-cons values > have any meaning in unread-command-events. > Don't think they do. They are an error. > > > The problem now is that non-cons/non-nil values are ignored. > > > > The loop to repeatedly thinks there's input so it consumes 100% cpu, > each iteration seeing that it isn't a cons > > cell, so there's "nothing to do". > > Exactly. So these values aren't ignored, they create an illusion that > some input is available. I was thinking about ignoring them entirely, > i.e. treating such values as nil (and maybe even silently replacing > them with nil). > Ah, sorry I misunderstood originally! That sounds good to me (though it would be slightly better to warn about it somewhere, IMO) > > The question is: would that kind of change break something? > I think most scenarios it would break would be ones that currently consume 100% cpu. So besides scenarios like https://xkcd.com/1172/ it is unlikely :) -- Eyal --001a11468f18557d02052db11eef Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Thu, Mar 10, 2016 at 12:39 PM, Eli Zaretskii <<= a href=3D"mailto:eliz@gnu.org" target=3D"_blank">eliz@gnu.org> wrote:
> Date: Thu, 10 Mar 2016 12:34:08 +0200
> From: Eyal Lotem <eyal.lote= m@gmail.com>
> Cc: Andreas Schwab <schwab@suse.d= e>, 22976@debbugs.gnu.org
>
> It can be set to any value at all, unfortunately.

That's not what I asked.=C2=A0 I asked whether non-nil, non-cons= values
have any meaning in unread-command-events.

<= div>Don't think they do. They are an error.=C2=A0

> The problem now is that non-cons/non-nil values are ignored.
>
> The loop to repeatedly thinks there's input so it consumes 100% cp= u, each iteration seeing that it isn't a cons
> cell, so there's "nothing to do".

Exactly.=C2=A0 So these values aren't ignored, they create an il= lusion that
some input is available.=C2=A0 I was thinking about ignoring them entirely,=
i.e. treating such values as nil (and maybe even silently replacing
them with nil).

A= h, sorry I misunderstood originally!

That sounds good to me (though it would be s= lightly better to warn about it somewhere, IMO)

= =C2=A0

The question is: would that kind of change break something?

I think most scenarios it would break would be ones that currently = consume 100% cpu. So besides scenarios like https://xkcd.com/1172/ it is unlikely :)


--
Eyal
--001a11468f18557d02052db11eef--