From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Ki=C3=AAn_?= =?UTF-8?Q?Nguy=E1=BB=85n?= Quang Newsgroups: gmane.emacs.bugs Subject: bug#57386: 29.0.50; support make-symbolic-link without admin priviledge on Windows Date: Thu, 25 Aug 2022 19:32:13 +0900 Message-ID: References: <838rnd638m.fsf@gnu.org> <83wnax4hw5.fsf@gnu.org> <83h72050tc.fsf@gnu.org> <83y1vc3d1l.fsf@gnu.org> <83wnaw3asz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000064162905e70e5066" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18218"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57386@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 25 12:34:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRAC0-0004SR-IE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Aug 2022 12:34:32 +0200 Original-Received: from localhost ([::1]:35686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRABz-0007tx-LX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Aug 2022 06:34:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRAAZ-00073e-MK for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2022 06:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59349) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRAAZ-0002G5-Ce for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2022 06:33:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oRAAY-0007UC-8u for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2022 06:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Ki=C3=AAn_?= =?UTF-8?Q?Nguy=E1=BB=85n?= Quang Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Aug 2022 10:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57386 X-GNU-PR-Package: emacs Original-Received: via spool by 57386-submit@debbugs.gnu.org id=B57386.166142355628711 (code B ref 57386); Thu, 25 Aug 2022 10:33:02 +0000 Original-Received: (at 57386) by debbugs.gnu.org; 25 Aug 2022 10:32:36 +0000 Original-Received: from localhost ([127.0.0.1]:49091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRAA7-0007T1-UR for submit@debbugs.gnu.org; Thu, 25 Aug 2022 06:32:36 -0400 Original-Received: from mail-ej1-f52.google.com ([209.85.218.52]:36507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRAA6-0007So-0B for 57386@debbugs.gnu.org; Thu, 25 Aug 2022 06:32:34 -0400 Original-Received: by mail-ej1-f52.google.com with SMTP id d21so19306870eje.3 for <57386@debbugs.gnu.org>; Thu, 25 Aug 2022 03:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=dYQi9k2C4CUA9zvb3ReGjf5HlDaJsn+12sTSFB9nyRE=; b=ma6Kj157FgFIM1egKrc/yDwK9jzrTIplm8OFPITbUJ0ZVLKWk5g4t+p+yAilYpVoBQ c2/T2UOGFywQ5qFWoP2M1Ve5w0tVywdnyDia00LjZgEu5Bqgrwg0G42W7Mpe6sx9aNtU b3z0LlL8uqaOrn3qDwyxSbI/Hp+MaiHC9BgxCB5GIpAMLxNTGNnPh8UvEiLacCg/piqf J5vXu/jQtEbE22VxviT230VNoA3X89XRMDsk5sbrE8wUNHBSLw8q6FkyoPLs6WErrI3U iUWSPBmaU/Wh39e0zm1hVkGvP9IQ7j3igSOHFKbeAp0ky0vmblolVeUkzxxOjuSM03QH DqjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=dYQi9k2C4CUA9zvb3ReGjf5HlDaJsn+12sTSFB9nyRE=; b=co+gr8E2Dytu1J9LMt5NyE0r/JtvCgCHwYq382u9tD/wqmsf/ECsS7S/FGQGqLzq7h GQVhueG9AJwwG3YXEWo0kcAkbdq1/a6idCMYtTpVmaKcvEITHJ6tvjPSkz2r6UQwk0/i Rfyep1yfNkXYEZnEmON2yRowmfOskppGKRebenjy8cevCcV5NSrXPd0cD2gv/BJQmrI6 RqXB6wIWhA/K+jAc2D4+4p9zfx7IChER8OxzVFETXjGBMWlT8r8+h9EE6HHWVUwjZwxs F2wCSMvumHDQV0WsJxhWrBKSYT0lKXMgIsbCNP1P1sxTc5Y+yMfiCBwF+bjicNgjWtSB gmRQ== X-Gm-Message-State: ACgBeo1esxpxCH1ntl+ZLIDjfCG/QERgTF9+aoIzpgS9PNgPvWATJBhj f29CNos3ftHaWB6jTrtan4su4FL+x4BiIKNHW8kVbvmB X-Google-Smtp-Source: AA6agR69Osvo4lpgh/R403eD+Igp0e2UqHzA4Aimh/x0TLS1yzWgy8opEXHYIhWKFCFyegEtEHMFY3DzGSupau1xgdo= X-Received: by 2002:a17:907:7fa5:b0:730:5d54:4c24 with SMTP id qk37-20020a1709077fa500b007305d544c24mr2000119ejc.641.1661423547834; Thu, 25 Aug 2022 03:32:27 -0700 (PDT) In-Reply-To: <83wnaw3asz.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240696 Archived-At: --00000000000064162905e70e5066 Content-Type: multipart/alternative; boundary="00000000000064162705e70e5064" --00000000000064162705e70e5064 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Oops. Here it is. On Thu, Aug 25, 2022 at 6:57 PM Eli Zaretskii wrote: > > From: Ki=C3=AAn Nguy=E1=BB=85n Quang > > Date: Thu, 25 Aug 2022 18:51:30 +0900 > > Cc: 57386@debbugs.gnu.org > > > > > When you call an API with a parameter that is invalid, you are riskin= g > > > an exception, depending on the API and the build (debug or not). Thi= s > > > has various unpleasant consequences; in the worst case, the Emacs > > > process could be terminated. As documented, the problem is limited t= o > > > CRT functions, but our general policy is to avoid that even when usin= g > > > the Win32 APIs. And version check is a simple enough way of avoiding > > > that, so I see no reason not to do it here. > > > > Okay, that makes sense. Although I think that's the problem of CRT APIs > only, as API should never throw > > exceptions, which is a foreign concept to ABI and requires an exact > library match to handle correctly > > > > The new patch is attached. > > Thanks, but I think you sent a wrong patch? > --=20 Nguyen Quang Kien - =E3=82=B0=E3=82=A8=E3=83=B3 =E3=82=AF=E3=82=A2=E3=83= =B3 =E3=82=AD=E3=82=A8=E3=83=B3 Software Developer @ MSD --00000000000064162705e70e5064 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Oops. Here it is.

=
On Thu, Aug 25, 2022 at 6:57 PM Eli Z= aretskii <eliz@gnu.org> wrote:
> From: Ki=C3= =AAn Nguy=E1=BB=85n Quang <kien.n.quang@gmail.com>
> Date: Thu, 25 Aug 2022 18:51:30 +0900
> Cc: 57386@d= ebbugs.gnu.org
>
> > When you call an API with a parameter that is invalid, you are ri= sking
> > an exception, depending on the API and the build (debug or not).= =C2=A0 This
> > has various unpleasant consequences; in the worst case, the Emacs=
> > process could be terminated.=C2=A0 As documented, the problem is = limited to
> > CRT functions, but our general policy is to avoid that even when = using
> > the Win32 APIs.=C2=A0 And version check is a simple enough way of= avoiding
> > that, so I see no reason not to do it here.
>
> Okay, that makes sense. Although I think that's the problem of CRT= APIs only, as API should never throw
> exceptions, which is a foreign concept to ABI and requires an exact li= brary match to handle correctly
>
> The new patch is attached.

Thanks, but I think you sent a wrong patch?


--
=C2=A0Nguyen Quang Kien - =E3=82=B0=E3=82=A8=E3=83=B3=E3=80=80=E3=82=AF=E3= =82=A2=E3=83=B3=E3=80=80=E3=82=AD=E3=82=A8=E3=83=B3
=C2=A0Software Devel= oper @ MSD
--00000000000064162705e70e5064-- --00000000000064162905e70e5066 Content-Type: application/octet-stream; name="0001-symlink-allow-w32-user-to-create-symlink-without-adm.patch" Content-Disposition: attachment; filename="0001-symlink-allow-w32-user-to-create-symlink-without-adm.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l78wnxle0 RnJvbSBkMTA4NTYxZTU4YTNhNTExN2IyNTliZjAzY2I3OTBkYjE0MDdlNjcwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLaWVuIE5ndXllbiA8a2llbi5uLnF1YW5nQGdtYWlsLmNvbT4K RGF0ZTogV2VkLCAyNCBBdWcgMjAyMiAyMzoxOTozNSArMDkwMApTdWJqZWN0OiBbUEFUQ0hdIHN5 bWxpbms6IGFsbG93IHczMiBub24tYWRtaW4gdXNlciB0byBjcmVhdGUgc3ltbGluawoKKiBzcmMv dzMyLmMgKHN5bWxpbmspOiBhbGxvdyB3MzIgdXNlciB0byBjcmVhdGUgc3ltbGluayB3aXRob3V0 IGFkbWluIHByaXZpbGVnZWQKCi0tLQogc3JjL3czMi5jIHwgOSArKysrKysrLS0KIDEgZmlsZSBj aGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3Jj L3czMi5jIGIvc3JjL3czMi5jCmluZGV4IGNiY2ZjZGQ0Zi4uNWU1ZWQ5ODBmIDEwMDY0NAotLS0g YS9zcmMvdzMyLmMKKysrIGIvc3JjL3czMi5jCkBAIC01OTkyLDEyICs1OTkyLDE3IEBAIHN5c191 bWFzayAoaW50IG1vZGUpCiAjaWZuZGVmIFNZTUJPTElDX0xJTktfRkxBR19ESVJFQ1RPUlkKICNk ZWZpbmUgU1lNQk9MSUNfTElOS19GTEFHX0RJUkVDVE9SWSAweDEKICNlbmRpZgorI2lmbmRlZiBT WU1CT0xJQ19MSU5LX0ZMQUdfQUxMT1dfVU5QUklWSUxFR0VEX0NSRUFURQorI2RlZmluZSBTWU1C T0xJQ19MSU5LX0ZMQUdfQUxMT1dfVU5QUklWSUxFR0VEX0NSRUFURSAweDIKKyNlbmRpZgogCiBp bnQKIHN5bWxpbmsgKGNoYXIgY29uc3QgKmZpbGVuYW1lLCBjaGFyIGNvbnN0ICpsaW5rbmFtZSkK IHsKICAgY2hhciBsaW5rZm5bTUFYX1VURjhfUEFUSF0sICp0Z3RmbjsKLSAgRFdPUkQgZmxhZ3Mg PSAwOworICAvKiBUaGUgbmV3IGZsYWcgaXMgc3VwcG9ydGVkIGZyb20gYnVpbGQgMTQ5NzIgKi8K KyAgRFdPUkQgZmxhZ3MgPSAodzMyX2J1aWxkX251bWJlciA+PSAxNDk3MikgPworICAgIFNZTUJP TElDX0xJTktfRkxBR19BTExPV19VTlBSSVZJTEVHRURfQ1JFQVRFIDogMDsKICAgaW50IGRpcl9h Y2Nlc3MsIGZpbGVuYW1lX2VuZHNfaW5fc2xhc2g7CiAKICAgLyogRGlhZ25vc3RpY3MgZm9sbG93 cyBQb3NpeCBhcyBtdWNoIGFzIHBvc3NpYmxlLiAgKi8KQEAgLTYwNTUsNyArNjA2MCw3IEBAIHN5 bWxpbmsgKGNoYXIgY29uc3QgKmZpbGVuYW1lLCBjaGFyIGNvbnN0ICpsaW5rbmFtZSkKICAgICAg ZGlyZWN0b3J5LiAgKi8KICAgZmlsZW5hbWVfZW5kc19pbl9zbGFzaCA9IElTX0RJUkVDVE9SWV9T RVAgKGZpbGVuYW1lW3N0cmxlbiAoZmlsZW5hbWUpIC0gMV0pOwogICBpZiAoZGlyX2FjY2VzcyA9 PSAwIHx8IGZpbGVuYW1lX2VuZHNfaW5fc2xhc2gpCi0gICAgZmxhZ3MgPSBTWU1CT0xJQ19MSU5L X0ZMQUdfRElSRUNUT1JZOworICAgIGZsYWdzIHw9IFNZTUJPTElDX0xJTktfRkxBR19ESVJFQ1RP Ulk7CiAKICAgdGd0Zm4gPSAoY2hhciAqKW1hcF93MzJfZmlsZW5hbWUgKGZpbGVuYW1lLCBOVUxM KTsKICAgaWYgKGZpbGVuYW1lX2VuZHNfaW5fc2xhc2gpCi0tIAoyLjM3LjAud2luZG93cy4xCgo= --00000000000064162905e70e5066--