unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michel de Ruiter <mdruiter@gmail.com>
To: 35646@debbugs.gnu.org
Subject: bug#35646: In SQL mode /- incorrectly starts a comment
Date: Thu, 9 May 2019 09:56:46 +0200	[thread overview]
Message-ID: <CAL0PwJS7q=SBNgEeCVEAMVAtLuYC4qnUC8CBWcUOmajYbm2mww@mail.gmail.com> (raw)

Hi,

I found that both -* and /- incorrectly start a comment in SQL mode.
The -* combination starts a block comment, but cannot be valid SQL
syntax AFAIK. However /- can be and should not start a line comment as
it does now. The simplest example is:
  SELECT 1/-1
It took me a while (https://emacs.stackexchange.com/q/50375) to
understand that this is expected behavior given the
sql-mode-syntax-table.
Of course using whitespace to separate / and -  'solves' the issue.
Someone might want to properly fix this using
syntax-propertize-function (as suggested by Stefan Monnier?,
https://emacs.stackexchange.com/a/50399).

Hope this helps!

Greets, Michel.





             reply	other threads:[~2019-05-09  7:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09  7:56 Michel de Ruiter [this message]
2019-10-27 20:48 ` bug#35646: In SQL mode /- incorrectly starts a comment Kristian Hole
2020-01-20 19:44   ` Stefan Kangas
2020-08-10 11:25   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL0PwJS7q=SBNgEeCVEAMVAtLuYC4qnUC8CBWcUOmajYbm2mww@mail.gmail.com' \
    --to=mdruiter@gmail.com \
    --cc=35646@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).