From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ola Nilsson Newsgroups: gmane.emacs.bugs Subject: bug#36317: [PATCH] Correct the name part of defun-prompt-regex in sh-script-mode Date: Mon, 24 Jun 2019 22:23:18 +0200 Message-ID: References: <20190620230122.22553-1-ola.nilsson@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="28961"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36317@debbugs.gnu.org To: rms@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 24 22:24:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfVVl-0007Rn-SQ for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jun 2019 22:24:21 +0200 Original-Received: from localhost ([::1]:54518 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfVVk-0004Er-FB for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jun 2019 16:24:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33665) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfVVc-0004Cy-SQ for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 16:24:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfVVa-00048Z-24 for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 16:24:12 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44569) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfVVS-0003xt-58 for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 16:24:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfVVR-0003WI-S5 for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 16:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ola Nilsson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2019 20:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36317 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36317-submit@debbugs.gnu.org id=B36317.156140781713499 (code B ref 36317); Mon, 24 Jun 2019 20:24:01 +0000 Original-Received: (at 36317) by debbugs.gnu.org; 24 Jun 2019 20:23:37 +0000 Original-Received: from localhost ([127.0.0.1]:58113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfVV3-0003Vf-Ba for submit@debbugs.gnu.org; Mon, 24 Jun 2019 16:23:37 -0400 Original-Received: from mail-pl1-f196.google.com ([209.85.214.196]:35140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfVV0-0003VP-W8 for 36317@debbugs.gnu.org; Mon, 24 Jun 2019 16:23:36 -0400 Original-Received: by mail-pl1-f196.google.com with SMTP id p1so7542825plo.2 for <36317@debbugs.gnu.org>; Mon, 24 Jun 2019 13:23:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6qAI+VHhU0BblPLOIfvLDAf3GhmEljHiuV4x6osRmR0=; b=W1/ahsqADcHFodX4hS9bEVBdJZL/x8rOhLvD6aSKnGgxg7N5UGSpINvRB8Jd78USTE Zm4Fs6HV4GGkSAeQezx5236g7VN1FLBxsdH7ilnTQpHX62BsCnXFM6UzEo99RSbI7zy/ e42hFbTjjspImSzR9ud+OeSfZA3+a/DeIhgWeGNCursNhP1YsnOXO67bot5TDhVV4817 +u6E1AXJ5jW0MxQDhDjHc/bmAaR8So+zafg5868YgKpcJ/Q6Oaamz3GJMP8rxCpuYWqK x/ksC5kjePEKzJQbsMdKiY4kS0tqbhkOnW0rEuhtbswO3J8p/POW13sewvJTL1xEeZ4+ A6YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6qAI+VHhU0BblPLOIfvLDAf3GhmEljHiuV4x6osRmR0=; b=B6m2/2VH8/Bk8SPUyM14U82zGnzP6NgqWUQRUdFUf//8PlryCcxReyzgDmNLBUZzFO cTj+S5dc60EtxLuxpOXrYI7Hda8ulnfFeS/820NKt9OLmm3JYscyNnJxFYkPYBT74Vxv FRe/KyXJaGASLyyHPf4HWJx7AbWnJxBEScpkXLpffmOwRe+KLmWOSSb0BRuh6lVrr/0X v+9F4Hdr3dpKWQaIctBxEvbqrngmFNPpM2OhDTzC5o1PT+ha0xUVObkCzpEltJtYRjjw DHfpbmMCFnERwXEfRm7xOaXQqTtYRPcnV7ZMc1x4Ocb7WfqfizSWP0SwO9RaSXvx0qVD khdg== X-Gm-Message-State: APjAAAW7tW3jgqzrlfDp9pGLiAo65vdMfdPVM05tbb3S3c76+WL3SFA/ fUO2tZ6ZgD6YkGZOPj1buZI8ooF4UfRrpWp3dO8= X-Google-Smtp-Source: APXvYqzar7QOloxdRNCK3lMjGKBZqj4tCS1IqOUZ+PknJx7sxlsO+xSjhlLisrah88Fhd8lgYAJSg6CNUYTeXYf8kjI= X-Received: by 2002:a17:902:704a:: with SMTP id h10mr41771138plt.337.1561407809065; Mon, 24 Jun 2019 13:23:29 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161277 Archived-At: On Sat, Jun 22, 2019 at 6:13 AM Richard Stallman wrote: > > It should try to recognize anything that POSIX says is valid. > However, rejecting something just because POSIX says it is invalid > is a non-goal. Ok, that makes total sense and is probably mentioned in the POSIX specification. > Maybe shells don't support such function names. If so, maybe the > change not to highlight them is good -- maybe. Highlighting erroneous > function names might be helpful for the user. When person runs the > script, and gets an error, person will change the name. Until then, > highlighting the name during editing might still be helpful. This is not actually about highlighting, but function navigation. beginning-of-defun, end-of-defun, and narrow-to-defun does not behave as expected for functions with underscores in their names. I've sent a V2 patch. -- Ola Nilsson