unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ola Nilsson <ola.nilsson@gmail.com>
To: rms@gnu.org
Cc: 36317@debbugs.gnu.org
Subject: bug#36317: [PATCH] Correct the name part of defun-prompt-regex in sh-script-mode
Date: Mon, 24 Jun 2019 22:23:18 +0200	[thread overview]
Message-ID: <CAKyOKyHKVrR-b4W0Q3arD8RdZgpxFCH5t8Cr6neQ9g0HK0zpkw@mail.gmail.com> (raw)
In-Reply-To: <E1heXOf-0007hm-NX@fencepost.gnu.org>

On Sat, Jun 22, 2019 at 6:13 AM Richard Stallman <rms@gnu.org> wrote:
>
> It should try to recognize anything that POSIX says is valid.
> However, rejecting something just because POSIX says it is invalid
> is a non-goal.

Ok, that makes total sense and is probably mentioned in the POSIX specification.

> Maybe shells don't support such function names.  If so, maybe the
> change not to highlight them is good -- maybe.  Highlighting erroneous
> function names might be helpful for the user.  When person runs the
> script, and gets an error, person will change the name.  Until then,
> highlighting the name during editing might still be helpful.

This is not actually about highlighting, but function navigation.
beginning-of-defun, end-of-defun, and narrow-to-defun does not
behave as expected for functions with underscores in their names.

I've sent a V2 patch.

-- 
Ola Nilsson





  reply	other threads:[~2019-06-24 20:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20 23:01 bug#36317: [PATCH] Correct the name part of defun-prompt-regex in sh-script-mode Ola Nilsson
2019-06-22  4:13 ` Richard Stallman
2019-06-24 20:23   ` Ola Nilsson [this message]
2019-06-23 21:00 ` bug#36317: [PATCH v2] Allow underscore in defun-prompt-regex names for sh-script Ola Nilsson
2019-06-25 14:01   ` Noam Postavsky
2019-06-26 20:58     ` Ola Nilsson
2019-06-28  0:15       ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKyOKyHKVrR-b4W0Q3arD8RdZgpxFCH5t8Cr6neQ9g0HK0zpkw@mail.gmail.com \
    --to=ola.nilsson@gmail.com \
    --cc=36317@debbugs.gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).