From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Agustin Martin Newsgroups: gmane.emacs.bugs Subject: bug#24439: ispell.el; cutom setting `ispell-library-directory'; patch Date: Sat, 8 Oct 2016 13:30:50 +0200 Message-ID: References: <57DB4C52.1050307@yahoo.com> <83h99g5ooh.fsf@gnu.org> <57F62864.4010609@yahoo.com> <83wphkilif.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1141b958ecc59c053e58dbc0 X-Trace: blaine.gmane.org 1475926287 1028 195.159.176.226 (8 Oct 2016 11:31:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 8 Oct 2016 11:31:27 +0000 (UTC) Cc: Laimonas =?UTF-8?Q?V=C4=97bra?= To: 24439@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 08 13:31:23 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bspqU-00074n-Fm for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Oct 2016 13:31:14 +0200 Original-Received: from localhost ([::1]:40512 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bspqT-000150-2N for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Oct 2016 07:31:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bspqM-00014t-RX for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2016 07:31:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bspqI-00080H-HX for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2016 07:31:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42122) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bspqI-000804-CQ for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2016 07:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bspqI-00044H-2G for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2016 07:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Agustin Martin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Oct 2016 11:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24439 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24439-submit@debbugs.gnu.org id=B24439.147592625815411 (code B ref 24439); Sat, 08 Oct 2016 11:31:02 +0000 Original-Received: (at 24439) by debbugs.gnu.org; 8 Oct 2016 11:30:58 +0000 Original-Received: from localhost ([127.0.0.1]:48312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bspqE-000408-6J for submit@debbugs.gnu.org; Sat, 08 Oct 2016 07:30:58 -0400 Original-Received: from mail-oi0-f41.google.com ([209.85.218.41]:36316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bspqC-0003u8-Ol for 24439@debbugs.gnu.org; Sat, 08 Oct 2016 07:30:57 -0400 Original-Received: by mail-oi0-f41.google.com with SMTP id m72so82947182oik.3 for <24439@debbugs.gnu.org>; Sat, 08 Oct 2016 04:30:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=oTbmdP9JTAc1QJqocOsfgpd6734Vz2mx7N1zF3tOB/c=; b=hkiA4vKGuA+sXDjtEUGRwUfLhY2dB3sxC44rXxzS/l84ELGNXWy4cRJWUv0CtAfGLe 9TLxDFGPmGH6VqsKKS31/1RHDiLCP40tyAlh4pHYKpbveMgFZC6G7iDDOHALr/JdhHt5 5BQ3iW85PJAbopDjXi90YTOL6wU1HWr7volP8LOSsrx+MGOVt5kN478VqcPx5uPHmVlP yH/JapbLl1KI4ovFwoR6a318GRKLhDhq1pTg9g+kKxhszyPNX9kvxCIUwXQS+aN9zkO5 yxDxjeIwt5mWNkQMlQwF5AIw7/IKP5hl8izxk0py3OaFzwCRc6OqFi89N63nw/inCffG ZJ3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=oTbmdP9JTAc1QJqocOsfgpd6734Vz2mx7N1zF3tOB/c=; b=U9GZA7eTD70gd699T6Xuxnd+m5SCxOzd5ZuixG59OvoRDIJi/15rZ+YS6efc7Da+5Q e64F3rSwIpH5YXgA55GhfEAjAbl1faD8jT8Hc9OeIuiOgVUXAhY3+w4wwyV5YxGHoeXx Gfx6U+K89OWiMMrb/ownoT2j0v8A+kNcAm4CTUH5h6DQnSNYXPCA0D/F1JE7VUcDn029 8PbE5NoQHFd0jqNSR5nyt5nsUFZSyRvERItaHXXqQBv8UxjEuMqKsT1+HHkF90jguYlt KfIArz00CXHngtLwmPAhCU4sRKLgPvUaxUtv1p/FbQo7tU3TBNR/ATg3waEiSaE/AStw 0a5g== X-Gm-Message-State: AA6/9RlKBabggVfrF86bCaQ3mHZHHWVtSC0tweXxdhaugZhbfAui/icnvt8q4uGPfM94o8ap0xq1JpVhiiLRAQ== X-Received: by 10.202.107.134 with SMTP id g128mr17516988oic.17.1475926251323; Sat, 08 Oct 2016 04:30:51 -0700 (PDT) Original-Received: by 10.157.51.82 with HTTP; Sat, 8 Oct 2016 04:30:50 -0700 (PDT) In-Reply-To: <83wphkilif.fsf@gnu.org> X-Google-Sender-Auth: 7a9ANjj8YHq9coQx4Sb4iRtfCpg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124195 Archived-At: --001a1141b958ecc59c053e58dbc0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 2016-10-07 10:58 GMT+02:00 Eli Zaretskii : > Agustin, could you please take a look at the proposed patch? TIA. > > > From: Laimonas V=C4=97bra > > Cc: 24439@debbugs.gnu.org > > Date: Thu, 6 Oct 2016 13:33:08 +0300 > > > > Eli Zaretskii wrote: > > > > >> Sorry, that is not true (mistakenly thought, that fopen won't work > with > > >> windows paths). Then i should really rebuild ispell with LIBDIR set = to > > >> native path and it will work with Emacs. > > > > > > I think you don't even need that. You need to set ISPELL_DICTDIR in > > > the environment to point to that directory. > > > > > > (The reason I didn't suggest this earlier is that I didn't know Cygwi= n > > > can fopen Windows-style absolute file names.) > > > > Actually that won't work with current ispell.el, because LIBRARYVAR is > > completely ignored and dictionaries searched only in LIBDIR (though it > > can be overridden by LIBRARYVAR). > > > > Fixed this and other (-d with an absolute path) issues in attached patc= h. > Hi, Eli I had a look at your patch and it looks really fine, thanks for caring about this. Needed to first read the whole thread (gmail decided to tag part of it as spam) and refresh my lisp a bit, I am currently busy with other things and am less responsive. I have also run some tests with it, and seems to work very well regarding dictionary selection. Did not check actual spellchecking (Checked with an old 24.4.1 where at least a function is not available, but could at least check that lists of available dictionaries) Best regards, --=20 Agustin --001a1141b958ecc59c053e58dbc0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
2016= -10-07 10:58 GMT+02:00 Eli Zaretskii <eliz@gnu.org>:
Agustin, could you please take a look at the proposed= patch?=C2=A0 TIA.

> From: Laimonas V=C4=97bra <laimonas.vebra@yahoo.com>
> Cc: 24439@d= ebbugs.gnu.org
> Date: Thu, 6 Oct 2016 13:33:08 +0300
>
> Eli Zaretskii wrote:
>
> >> Sorry, that is not true (mistakenly thought, that fopen won&#= 39;t work with
> >> windows paths). Then i should really rebuild ispell with LIBD= IR set to
> >> native path and it will work with Emacs.
> >
> > I think you don't even need that.=C2=A0 You need to set ISPEL= L_DICTDIR in
> > the environment to point to that directory.
> >
> > (The reason I didn't suggest this earlier is that I didn'= t know Cygwin
> > can fopen Windows-style absolute file names.)
>
> Actually that won't work with current ispell.el, because LIBRARYVA= R is
> completely ignored and dictionaries searched only in LIBDIR (though it=
> can be overridden by LIBRARYVAR).
>
> Fixed this and other (-d with an absolute path) issues in attached pat= ch.
=C2= =A0
Hi, Eli

<= div class=3D"m_-5198939978098904263h5">I had a look at your patch and it lo= oks really fine, thanks for caring about this. Needed to first read the who= le thread (gmail decided to tag part of it as spam) and refresh my lisp a b= it, I am currently busy with other things and am less responsive.

I have also run some tests with= it, and seems to work very well regarding dictionary selection. Did not ch= eck actual spellchecking (Checked with an old 24.4.1 where at least a funct= ion is not available, but could at least check that lists of available dict= ionaries)

Best regards,

--
Agustin

=C2=A0

--001a1141b958ecc59c053e58dbc0--