From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lin Sun via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#47521: 28.0.50; [PATCH] [image-mode] reduce calling for image-toggle-display-text Date: Wed, 31 Mar 2021 22:47:33 +0800 Message-ID: References: <40B0A46C-9AFD-49AF-BCDE-0B5E2CF8ED6B@hxcore.ol> Reply-To: Lin Sun Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000008b49b505bed6328e" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18632"; mail-complaints-to="usenet@ciao.gmane.io" To: 47521@debbugs.gnu.org, Glenn Morris , Eli Zaretskii , sunlin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 31 16:48:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRc8i-0004hU-C4 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 31 Mar 2021 16:48:12 +0200 Original-Received: from localhost ([::1]:54660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRc8h-00056o-Bc for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 31 Mar 2021 10:48:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRc8Y-00056g-NU for bug-gnu-emacs@gnu.org; Wed, 31 Mar 2021 10:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43541) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRc8Y-00011K-G4 for bug-gnu-emacs@gnu.org; Wed, 31 Mar 2021 10:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lRc8Y-0007L0-F6 for bug-gnu-emacs@gnu.org; Wed, 31 Mar 2021 10:48:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <40B0A46C-9AFD-49AF-BCDE-0B5E2CF8ED6B@hxcore.ol> Resent-From: Lin Sun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Mar 2021 14:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47521 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47521-submit@debbugs.gnu.org id=B47521.161720207228178 (code B ref 47521); Wed, 31 Mar 2021 14:48:02 +0000 Original-Received: (at 47521) by debbugs.gnu.org; 31 Mar 2021 14:47:52 +0000 Original-Received: from localhost ([127.0.0.1]:55082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRc8O-0007KQ-Ji for submit@debbugs.gnu.org; Wed, 31 Mar 2021 10:47:52 -0400 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:35610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRc8L-0007K6-U2 for 47521@debbugs.gnu.org; Wed, 31 Mar 2021 10:47:51 -0400 Original-Received: by mail-wr1-f54.google.com with SMTP id j18so19973239wra.2 for <47521@debbugs.gnu.org>; Wed, 31 Mar 2021 07:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zoom.us; s=google; h=mime-version:from:date:message-id:subject:to; bh=ZNOEU2KO8GcVsS2jH64mjgsshUefAVtZ85zvfzEImk4=; b=VAAd2JtQFkgUnX3TJMW2X57xXYVlEA2Shykpg/4QgDaFQfGdhFPbmQekvA6IgAbOC0 uI8bDPQOl9CPVU4qHJiCu+OKLqumVQQqstSZC/DXkp7QGE5qV/NAx+C5x2/UAo54K9zc y846Xnst1Ke0cnDXGYrsA76sPUUj4lrqzuPb0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ZNOEU2KO8GcVsS2jH64mjgsshUefAVtZ85zvfzEImk4=; b=pm+oVnCx8hKq4vARKH3ayi2dSclKTG1alNahCokF53nL6pDaO6fZXpdFfUphLH1jTV b6yUzmATxJqkByfCB9/VAf3vjMpqs2SC79f4a/ZgYJwWo+T5Cep1xUE0txADwmG+kwmZ 4L3ia0CIPxzwz/OtlQYGBq5uKyURZ77QRfgP+9P80kgav+DFHO/cGvYMJA1WpwfV+aOK mC+0R1qvv7N0NKlNmeLgEid3wReYpOqmsKhn+TZOZ2aqsRqn6PaRvDcP7jhmOtmtSz3l BSNfR5xMWQ0cW0t8732GFQkpOn0BP62IPTWm7X5qVGLOwSGX49Lfa+1RnBPWXOMctUwv 2JXw== X-Gm-Message-State: AOAM532QQtHS3++elEDTiM5BM8oc7zQ9N+SaYY0hfOrp5B638JWLF3Lv n1OrJF+fiIQrHxyCJ882gn88woliBkiO+A6kdcLew7OY1OjbYQ== X-Google-Smtp-Source: ABdhPJwVNODQvckFTFER8mfFJszfdlS3fdUDsVCN3TQj1DpHGLJgyS+7G0VCLObC+vARIqpzOCdg+oRgPq9pTFcasZA= X-Received: by 2002:adf:a302:: with SMTP id c2mr4135434wrb.212.1617202063803; Wed, 31 Mar 2021 07:47:43 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203368 Archived-At: --0000000000008b49b505bed6328e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable (Resend in text mail format.) Hi, When opening a png file and toggle display from image to text by C-c C-c, the `image-toggle-display-text` will be called twice in function `image-toggle-display-text`. The first call is from the major mode change hook, in the following line will cause `change-major-mode-hook` be run and it=E2=80=99s `image-toggle-display-text` for image-mode. image-mode.el:730 (major-mode-restore '(image-mode image-mode-as-te= xt)) The second call is from the direct call at image-mode.el:736 (image-toggle-display-text) Try debug-on-entry on `image-toggle-display-text`, then switch image to text in image-mode by press C-c C-c to observe the issue. And the patch tries to reduce calling for `image-toggle-display-text`. Best Regards Lin Sun --0000000000008b49b505bed6328e Content-Type: application/octet-stream; name="0001-image-mode-reduce-calling-for-image-toggle-display-t.patch" Content-Disposition: attachment; filename="0001-image-mode-reduce-calling-for-image-toggle-display-t.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kmxkcg1c0 RnJvbSBhMmFmMzhmYjA1NjQxODM4NmI3MDliODY1M2YwZDM2NzdiNDgyYWY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxsaW4uc3VuQHpvb20udXM+CkRhdGU6IFdlZCwg MzEgTWFyIDIwMjEgMjA6MDI6MTggKzA4MDAKU3ViamVjdDogW1BBVENIXSBbaW1hZ2UtbW9kZV0g cmVkdWNlIGNhbGxpbmcgZm9yIGltYWdlLXRvZ2dsZS1kaXNwbGF5LXRleHQKCipsaXNwL2ltYWdl LW1vZGUuZWw6IGRvIG5vdCBjYWxsIHRoZSBpbWFnZS10b2dnbGUtZGlzcGxheS10ZXh0IHR3aWNl CndoZW4gdG9nZ2xlIGltYWdlIGRpc3BsYXkuCi0tLQogbGlzcC9pbWFnZS1tb2RlLmVsIHwgNSAr KystLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9saXNwL2ltYWdlLW1vZGUuZWwgYi9saXNwL2ltYWdlLW1vZGUuZWwKaW5kZXgg MmRlMTZjYi4uZjRmZjM1ZiAxMDA2NDQKLS0tIGEvbGlzcC9pbWFnZS1tb2RlLmVsCisrKyBiL2xp c3AvaW1hZ2UtbW9kZS5lbApAQCAtNzMyLDggKzczMiw5IEBAIGltYWdlLW1vZGUtdG8tdGV4dAog ICAgIChzZXRxIGltYWdlLXR5cGUgcHJldmlvdXMtaW1hZ2UtdHlwZSkKICAgICA7OyBFbmFibGUg aW1hZ2UgbWlub3IgbW9kZSB3aXRoIGBDLWMgQy1jJy4KICAgICAoaW1hZ2UtbWlub3ItbW9kZSAx KQotICAgIDs7IFNob3cgdGhlIGltYWdlIGZpbGUgYXMgdGV4dC4KLSAgICAoaW1hZ2UtdG9nZ2xl LWRpc3BsYXktdGV4dCkpKQorICAgICh1bmxlc3MgKGltYWdlLWdldC1kaXNwbGF5LXByb3BlcnR5 KQorICAgICAgOzsgU2hvdyB0aGUgaW1hZ2UgZmlsZSBhcyB0ZXh0LgorICAgICAgKGltYWdlLXRv Z2dsZS1kaXNwbGF5LXRleHQpKSkpCiAKIChkZWZ1biBpbWFnZS1tb2RlLWFzLWhleCAoKQogICAi U2V0IGEgbm9uLWltYWdlIG1vZGUgYXMgbWFqb3IgbW9kZSBpbiBjb21iaW5hdGlvbiB3aXRoIGlt YWdlIG1pbm9yIG1vZGUuCi0tIAoyLjcuMAoK --0000000000008b49b505bed6328e--