From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lin Sun via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#47119: 28.0.50; [patch][Dired] new user option for compressing dir suffix Date: Sat, 13 Mar 2021 15:50:17 +0800 Message-ID: References: <83eegjjyhq.fsf@gnu.org> Reply-To: Lin Sun Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000002f3a4305bd664531" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37186"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sunlin , 47119@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 13 08:51:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKz3S-0009YS-Cd for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Mar 2021 08:51:22 +0100 Original-Received: from localhost ([::1]:33324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKz3R-0003La-Dp for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Mar 2021 02:51:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKz38-0003Bh-Ni for bug-gnu-emacs@gnu.org; Sat, 13 Mar 2021 02:51:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47463) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKz38-0005HB-GP for bug-gnu-emacs@gnu.org; Sat, 13 Mar 2021 02:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lKz38-0001LK-EE for bug-gnu-emacs@gnu.org; Sat, 13 Mar 2021 02:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lin Sun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Mar 2021 07:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47119 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47119-submit@debbugs.gnu.org id=B47119.16156218365090 (code B ref 47119); Sat, 13 Mar 2021 07:51:02 +0000 Original-Received: (at 47119) by debbugs.gnu.org; 13 Mar 2021 07:50:36 +0000 Original-Received: from localhost ([127.0.0.1]:58998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKz2i-0001K2-K1 for submit@debbugs.gnu.org; Sat, 13 Mar 2021 02:50:36 -0500 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:39259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKz2g-0001Ji-HZ for 47119@debbugs.gnu.org; Sat, 13 Mar 2021 02:50:35 -0500 Original-Received: by mail-wr1-f41.google.com with SMTP id b18so6007416wrn.6 for <47119@debbugs.gnu.org>; Fri, 12 Mar 2021 23:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zoom.us; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sjaU7YodJig9QnFc5WW9L58LwGg20bWm4RFX6Gx91mU=; b=VEtVKEyNGX7yBM36oXTosr7RzTzU4bNlexWmLT+LkYkHaZDI2azGErCs2NNe6sjgX/ vsPahH5sHN9kxgWKOAdbnmMo1pPeT7t6Hrg1e7q/QxzVouYoo3TmNWyoDfW8YxJIlUrX WbN8rhlpyJ2X/wcM9LVPVzoWZHDubXmNFMISA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sjaU7YodJig9QnFc5WW9L58LwGg20bWm4RFX6Gx91mU=; b=W8EoXiI5y66IIgKXfIFAE6MARv3L83ctuLEpx7CEXlkquFLFwz24xpH9i5FtODtSqf 3L8dWE72pemsuBMwBsNbB7uo4N/byHwzHYEFsSSkg85V8k/h3V82N9UiEFgFtJnJJR94 +0ah+9vqbZ2KJdk5j/LgToAOoCRrBQb5KWVn8RHuS3nD8Oz6XYg5ihQnbvMmU7PEI5fb YLfwMR86c0D50R3RLCzjlUCpDKryKLj9n+tHeGG1QmaRgJaLqixG3qaQ3gor1SDFSMgS iXldvgf54L8/ATgibeZsIeIMTfjz304zNx8IBTAbkBhXpimw6McKNzaESjTJIedYMRlu z0kg== X-Gm-Message-State: AOAM533O6fmwwbgZTBEDWfit659Zzu9xDMm40VLCuuxLqsyKJHyfixCa LCV5Xp1h2cLWQybquCoQBX0j6Bw/XOyKs+25RwpAXQ== X-Google-Smtp-Source: ABdhPJwYAiwA05nDlNnQGBL8WFWVfH5V4NiHgeDMTVxUw2oeNJYT4v/lCPH5O6IcQs4FTh2n3hFSJBDFP/e0id22hpk= X-Received: by 2002:adf:8341:: with SMTP id 59mr17099158wrd.130.1615621828576; Fri, 12 Mar 2021 23:50:28 -0800 (PST) In-Reply-To: <83eegjjyhq.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202238 Archived-At: --0000000000002f3a4305bd664531 Content-Type: text/plain; charset="UTF-8" Hi Eli, Thanks for your comments, I add the ":type 'string" for this new option, and the manual change is reverted now. New patch is attached. On Sat, Mar 13, 2021 at 3:37 PM Eli Zaretskii wrote: > > > Date: Sat, 13 Mar 2021 11:55:48 +0800 > > From: Lin Sun via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > A new user option `dired-compress-files-default-suffix' for > > controlling the default format for compressing directory. > > Thanks, but wouldn't it be better to use symbols instead of strings? > That way, we could prevent typos easier, and also offer completion for > setting the option interactively. > > Also, doesn't the user manual need to be changed as well? --0000000000002f3a4305bd664531 Content-Type: application/octet-stream; name="0001-dired-new-user-option-dired-compress-files-default-suffix.patch" Content-Disposition: attachment; filename="0001-dired-new-user-option-dired-compress-files-default-suffix.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_km7fi2yr0 RnJvbSAxYTU1ZGIyNjIzZTljZGIzZDU1YzUzOGEyNTE4MTc4Y2M2YjI4MGY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxsaW4uc3VuQHpvb20udXM+CkRhdGU6IFNhdCwg MTMgTWFyIDIwMjEgMTE6NDc6MjMgKzA4MDAKU3ViamVjdDogW1BBVENIXSBbKmRpcmVkXSBuZXcg dXNlciBvcHRpb24KICdkaXJlZC1jb21wcmVzcy1maWxlcy1kZWZhdWx0LXN1ZmZpeCcKCipkaXJl ZC1hdXguZWw6IHVzZXIgb3B0aW9uICdkaXJlZC1jb21wcmVzcy1maWxlcy1kZWZhdWx0LXN1ZmZp eCcgZm9yCmRlZmF1bHQgc3VmZml4IGZvciBjb21wcmVzc2luZyBkaXJlY3RvcnkuCi0tLQogZXRj L05FV1MgICAgICAgICAgfCAgNiArKysrKysKIGxpc3AvZGlyZWQtYXV4LmVsIHwgNDkgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQogMiBmaWxlcyBjaGFu Z2VkLCAzNyBpbnNlcnRpb25zKCspLCAxOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9ldGMv TkVXUyBiL2V0Yy9ORVdTCmluZGV4IGZhODc4NGQuLmUyMGJlZWUgMTAwNjQ0Ci0tLSBhL2V0Yy9O RVdTCisrKyBiL2V0Yy9ORVdTCkBAIC02MzUsNiArNjM1LDEyIEBAIGxpbmUsIGFuZCBhbGxvd3Mg dHJ1bmNhdGluZyB0aGVtICh0byBwcmVzZXJ2ZSBzcGFjZSBvbiB0aGUgbW9kZSBsaW5lKQogb3Ig c2hvd2luZyB0aGVtIGxpdGVyYWxseSwgZWl0aGVyIGluc3RlYWQgb2YsIG9yIGluIGFkZGl0aW9u IHRvLAogZGlzcGxheWluZyAiYnkgbmFtZSIgb3IgImJ5IGRhdGUiIHNvcnQgb3JkZXIuCiAKKysr KworKioqIE5ldyB1c2VyIG9wdGlvbiAnZGlyZWQtY29tcHJlc3MtZmlsZXMtZGVmYXVsdC1zdWZm aXgnLgorVGhpcyB1c2VyIG9wdGlvbiBjb250cm9scyBkZWZhdWx0IHN1ZmZpeCBmb3IgY29tcHJl c3NpbmcgZGlyZWN0b3J5LiAgSWYgaXQncworbmlsLCB0aGUgIi50YXIuZ3oiIHdpbGwgYmUgdXNl ZC4gUmVmZXIgdGhlICdkaXJlZC1jb21wcmVzcy1maWxlcy1hbGlzdCcgZm9yCitzdXBwb3J0ZWQg c3VmZml4IGxpc3QuCisKIC0tLQogKioqIEJyb2tlbiBhbmQgY2lyY3VsYXIgbGlua3MgYXJlIHNo b3duIHdpdGggdGhlICdkaXJlZC1icm9rZW4tc3ltbGluaycgZmFjZS4KIApkaWZmIC0tZ2l0IGEv bGlzcC9kaXJlZC1hdXguZWwgYi9saXNwL2RpcmVkLWF1eC5lbAppbmRleCBkNWY0OTEwLi4yMzcx ODJlIDEwMDY0NAotLS0gYS9saXNwL2RpcmVkLWF1eC5lbAorKysgYi9saXNwL2RpcmVkLWF1eC5l bApAQCAtMTEzMiw2ICsxMTMyLDcgQEAgZGlyZWQtY29tcHJlc3MtZmlsZS1zdWZmaXhlcwogICAg IDs7IFNvbGFyaXMgMTAgdmVyc2lvbiBvZiB0YXIgKG9ic29sZXRlIGluIDIwMjQ/KS4KICAgICA7 OyBTYW1lIHRoaW5nIG9uIEFJWCA3LjEgKG9ic29sZXRlIDIwMjM/KSBhbmQgNy4yIChvYnNvbGV0 ZSAyMDIyPykuCiAgICAgKCJcXC50YXJcXC5nelxcJyIgIiIgImd6aXAgLWRjICVpIHwgdGFyIC14 ZiAtIikKKyAgICAoIlxcLnRhclxcLnh6XFwnIiAiIiAieHogLWRjICVpIHwgdGFyIC14ZiAtIikK ICAgICAoIlxcLnRnelxcJyIgIiIgImd6aXAgLWRjICVpIHwgdGFyIC14ZiAtIikKICAgICAoIlxc Lmd6XFwnIiAiIiAiZ3VuemlwIikKICAgICAoIlxcLmx6XFwnIiAiIiAibHppcCAtZCIpCkBAIC0x MTQ5LDEwICsxMTUwLDcgQEAgZGlyZWQtY29tcHJlc3MtZmlsZS1zdWZmaXhlcwogICAgICgiXFwu enN0XFwnIiAiIiAidW56c3RkIC0tcm0iKQogICAgICgiXFwuN3pcXCciICIiICI3eiB4IC1hb2Eg LW8lbyAlaSIpCiAgICAgOzsgVGhpcyBpdGVtIGNvbnRyb2xzIG5hbWluZyBmb3IgY29tcHJlc3Np b24uCi0gICAgKCJcXC50YXJcXCciICIudGd6IiBuaWwpCi0gICAgOzsgVGhpcyBpdGVtIGNvbnRy b2xzIHRoZSBjb21wcmVzc2lvbiBvZiBkaXJlY3Rvcmllcy4gIEl0cyBSRUdFWFAKLSAgICA7OyBl bGVtZW50IHNob3VsZCBuZXZlciBtYXRjaCBhbnkgdmFsaWQgZmlsZSBuYW1lLgotICAgICgiXDAw MCIgIi50YXIuZ3oiICJ0YXIgLWNmIC0gJWkgfCBnemlwIC1jOSA+ICVvIikpCisgICAgKCJcXC50 YXJcXCciICIudGd6IiBuaWwpKQogICAiQ29udHJvbCBjaGFuZ2VzIGluIGZpbGUgbmFtZSBzdWZm aXhlcyBmb3IgY29tcHJlc3Npb24gYW5kIHVuY29tcHJlc3Npb24uCiBFYWNoIGVsZW1lbnQgc3Bl Y2lmaWVzIG9uZSB0cmFuc2Zvcm1hdGlvbiBydWxlLCBhbmQgaGFzIHRoZSBmb3JtOgogICAoUkVH RVhQIE5FVy1TVUZGSVggUFJPR1JBTSkKQEAgLTExNjgsNiArMTE2NiwxMyBAQCBkaXJlZC1jb21w cmVzcy1maWxlLXN1ZmZpeGVzCiBPdGhlcndpc2UsIHRoZSBydWxlIGlzIGEgY29tcHJlc3Npb24g cnVsZSwgYW5kIGNvbXByZXNzaW9uIGlzIGRvbmUgd2l0aCBnemlwLgogQVJHUyBhcmUgY29tbWFu ZCBzd2l0Y2hlcyBwYXNzZWQgdG8gUFJPR1JBTS4iKQogCisoZGVmY3VzdG9tIGRpcmVkLWNvbXBy ZXNzLWZpbGVzLWRlZmF1bHQtc3VmZml4IG5pbAorICAiRGVmYXVsdCBzdWZmaXggZm9yIGNvbXBy ZXNzaW5nIGRpcmVjdG9yeS4KK0lmIG5pbCwgdGhlIFwiLnRhci5nelwiIHdpbGwgYmUgdXNlZC4i CisgIDp0eXBlICdzdHJpbmcKKyAgOmdyb3VwICdkaXJlZAorICA6dmVyc2lvbiAiMjguMSIpCisK IChkZWZ2YXIgZGlyZWQtY29tcHJlc3MtZmlsZXMtYWxpc3QKICAgJygoIlxcLnRhclxcLmd6XFwn IiAuICJ0YXIgLWNmIC0gJWkgfCBnemlwIC1jOSA+ICVvIikKICAgICAoIlxcLnRhclxcLmJ6Mlxc JyIgLiAidGFyIC1jZiAtICVpIHwgYnppcDIgLWM5ID4gJW8iKQpAQCAtMTI3NSwyMCArMTI4MCwy OCBAQCBkaXJlZC1jb21wcmVzcy1maWxlCiAgICAgICAgICAgIDs7IFRyeSBnemlwOyBpZiB3ZSBk b24ndCBoYXZlIHRoYXQsIHVzZSBjb21wcmVzcy4KICAgICAgICAgICAgKGNvbmRpdGlvbi1jYXNl IG5pbAogICAgICAgICAgICAgICAgKGlmIChmaWxlLWRpcmVjdG9yeS1wIGZpbGUpCi0gICAgICAg ICAgICAgICAgICAgKHByb2duCi0gICAgICAgICAgICAgICAgICAgICAoc2V0cSBzdWZmaXggKGNk ciAoYXNzb2MgIlwwMDAiIGRpcmVkLWNvbXByZXNzLWZpbGUtc3VmZml4ZXMpKSkKLSAgICAgICAg ICAgICAgICAgICAgICh3aGVuIHN1ZmZpeAotICAgICAgICAgICAgICAgICAgICAgICAobGV0ICgo b3V0LW5hbWUgKGNvbmNhdCBmaWxlIChjYXIgc3VmZml4KSkpCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgIChkZWZhdWx0LWRpcmVjdG9yeSAoZmlsZS1uYW1lLWRpcmVjdG9yeSBmaWxlKSkp Ci0gICAgICAgICAgICAgICAgICAgICAgICAgKGRpcmVkLXNoZWxsLWNvbW1hbmQKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgKHJlcGxhY2UtcmVnZXhwLWluLXN0cmluZwotICAgICAgICAgICAg ICAgICAgICAgICAgICAgIiVvIiAoc2hlbGwtcXVvdGUtYXJndW1lbnQgb3V0LW5hbWUpCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAocmVwbGFjZS1yZWdleHAtaW4tc3RyaW5nCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgIiVpIiAoc2hlbGwtcXVvdGUtYXJndW1lbnQgKGZpbGUtbmFt ZS1ub25kaXJlY3RvcnkgZmlsZSkpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNhZHIg c3VmZml4KQotICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5pbCB0KQotICAgICAgICAgICAg ICAgICAgICAgICAgICAgbmlsIHQpKQotICAgICAgICAgICAgICAgICAgICAgICAgIG91dC1uYW1l KSkpCisgICAgICAgICAgICAgICAgICAgKGxldCogKChzdWZmaXgKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgIChvciBkaXJlZC1jb21wcmVzcy1maWxlcy1kZWZhdWx0LXN1ZmZpeCAiLnRhci5n eiIpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAocnVsZSAoY2wtZmluZC1pZgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxhbWJkYSAoeCkgKHN0cmluZy1tYXRjaC1wIChj YXIgeCkgc3VmZml4KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRpcmVkLWNv bXByZXNzLWZpbGVzLWFsaXN0KSkpCisgICAgICAgICAgICAgICAgICAgICAoaWYgcnVsZQorICAg ICAgICAgICAgICAgICAgICAgICAgIChsZXQgKChvdXQtbmFtZSAoY29uY2F0IGZpbGUgc3VmZml4 KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZGVmYXVsdC1kaXJlY3RvcnkgKGZp bGUtbmFtZS1kaXJlY3RvcnkgZmlsZSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgKGRp cmVkLXNoZWxsLWNvbW1hbmQKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAocmVwbGFjZS1y ZWdleHAtaW4tc3RyaW5nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIlbyIgKHNoZWxs LXF1b3RlLWFyZ3VtZW50IG91dC1uYW1lKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo cmVwbGFjZS1yZWdleHAtaW4tc3RyaW5nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi JWkiIChzaGVsbC1xdW90ZS1hcmd1bWVudCAoZmlsZS1uYW1lLW5vbmRpcmVjdG9yeSBmaWxlKSkK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChjZHIgcnVsZSkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIG5pbCB0KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBuaWwg dCkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICBvdXQtbmFtZSkKKyAgICAgICAgICAgICAg ICAgICAgICAgKHVzZXItZXJyb3IKKyAgICAgICAgICAgICAgICAgICAgICAgICJObyBjb21wcmVz c2lvbiBydWxlIGZvdW5kIGZvciBcCitgZGlyZWQtY29tcHJlc3MtZmlsZXMtZGVmYXVsdC1zdWZm aXgnICVzLCBzZWUgYGRpcmVkLWNvbXByZXNzLWZpbGVzLWFsaXN0JyBmb3JcCisgdGhlIHN1cHBv cnRlZCBzdWZmaXhlcyBsaXN0LiIKKyAgICAgICAgICAgICAgICAgICAgICAgIGRpcmVkLWNvbXBy ZXNzLWZpbGVzLWRlZmF1bHQtc3VmZml4KSkpCiAgICAgICAgICAgICAgICAgIChsZXQgKChvdXQt bmFtZSAoY29uY2F0IGZpbGUgIi5neiIpKSkKICAgICAgICAgICAgICAgICAgICAoYW5kIChvciAo bm90IChmaWxlLWV4aXN0cy1wIG91dC1uYW1lKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAoeS1vci1uLXAKLS0gCjIuNy4wCgo= --0000000000002f3a4305bd664531--