From: Ryan Olson <ryan.olson.x@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 21857@debbugs.gnu.org
Subject: bug#21857: PATCH to show message after `package-install` installs successfully
Date: Sun, 23 Feb 2020 08:19:07 -0700 [thread overview]
Message-ID: <CAKkY5K75LVZS_iR=TVnSvDAhRoBadBzVgUfc6QHQ6eETErOH4Q@mail.gmail.com> (raw)
In-Reply-To: <877e0dbc6f.fsf_-_@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
Noam Postavsky <npostavs@gmail.com> wrote:
> The patch looks fine. It would help if it included a commit log message
> (as described in CONTRIBUTE). That way it's a bit less work to merge
> it, and is therefore more likely to happen.
Thanks! Attached is a new patch created using instructions found in CONTRIBUTE.
[-- Attachment #2: 0001-Show-friendly-message-after-package-install.patch --]
[-- Type: application/octet-stream, Size: 1130 bytes --]
From e8c08bc17c5a453ea0ba52f9afe2dcb36ecc98a7 Mon Sep 17 00:00:00 2001
From: Ryan Olson <ryanolsonx@gmail.com>
Date: Sun, 23 Feb 2020 08:15:10 -0700
Subject: [PATCH] Show friendly message after package install
Once we know the package has successfully been installed using the
`package-install` command, instead of relying on the compile "Done"
message, give a message that tells the user that the package has been
installed. (Bug#21857)
---
lisp/emacs-lisp/package.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index c91ee445e1..43eb038a86 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2081,7 +2081,8 @@ package-install
(package-compute-transaction () (list (list pkg))))))
(progn
(package-download-transaction transaction)
- (package--quickstart-maybe-refresh))
+ (package--quickstart-maybe-refresh)
+ (message "Package `%s' installed." name))
(message "`%s' is already installed" name))))
(defun package-strip-rcs-id (str)
--
2.23.0
next prev parent reply other threads:[~2020-02-23 15:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 23:41 bug#21857: package install should give better feedback David Reitter
2015-11-09 0:06 ` Artur Malabarba
2020-01-17 17:53 ` bug#21857: PATCH to show message after `package-install` installs successfully Ryan Olson
2020-01-17 18:04 ` Ryan Olson
2020-02-20 17:52 ` bug#21857: Feedback / Merge on patch Ryan Olson
2020-02-23 14:39 ` bug#21857: PATCH to show message after `package-install` installs successfully Noam Postavsky
2020-02-23 15:19 ` Ryan Olson [this message]
2020-02-26 0:47 ` Noam Postavsky
2020-08-09 12:09 ` bug#21857: package install should give better feedback Lars Ingebrigtsen
2020-08-09 14:29 ` David Reitter
2020-08-10 10:49 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKkY5K75LVZS_iR=TVnSvDAhRoBadBzVgUfc6QHQ6eETErOH4Q@mail.gmail.com' \
--to=ryan.olson.x@gmail.com \
--cc=21857@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).