unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ryan Olson <ryan.olson.x@gmail.com>
To: 21857@debbugs.gnu.org
Subject: bug#21857: PATCH to show message after `package-install` installs successfully
Date: Fri, 17 Jan 2020 11:04:22 -0700	[thread overview]
Message-ID: <CAKkY5K5FbhfUdj7tygVM1dY=MgokhU=hh0L1H5Q46mwZbT56BA@mail.gmail.com> (raw)
In-Reply-To: <CAKkY5K4YROAxzMk6_Ta76_-avnmPrXmXvMqapp7iWsGxsH5htw@mail.gmail.com>

Switched patch to `diff -u` variant.

--- package.el.orig 2020-01-17 10:11:48.000000000 -0700
+++ package.el 2020-01-17 10:12:36.000000000 -0700
@@ -2076,7 +2076,8 @@
                  (package-compute-transaction () (list (list pkg))))))
         (progn
           (package-download-transaction transaction)
-          (package--quickstart-maybe-refresh))
+          (package--quickstart-maybe-refresh)
+          (message "Package `%s' installed." name))
       (message "`%s' is already installed" name))))

 (defun package-strip-rcs-id (str)

On Fri, Jan 17, 2020 at 10:53 AM Ryan Olson <ryan.olson.x@gmail.com> wrote:
>
> When `package-install` function finishes successfully, this patch
> (below) shows the message "Package `package-name` installed."  This
> matches the message that is shown with the function `package-delete`.
> I feel like this solves the primary issue: messaging.  After this
> patch, the user should know that everything was a success.
>
> *** package.el.orig 2020-01-17 10:11:48.000000000 -0700
> --- package.el 2020-01-17 10:12:36.000000000 -0700
> *************** to install it but still mark it as selec
> *** 2076,2082 ****
>                    (package-compute-transaction () (list (list pkg))))))
>           (progn
>             (package-download-transaction transaction)
> !           (package--quickstart-maybe-refresh))
>         (message "`%s' is already installed" name))))
>
>   (defun package-strip-rcs-id (str)
> --- 2076,2083 ----
>                    (package-compute-transaction () (list (list pkg))))))
>           (progn
>             (package-download-transaction transaction)
> !           (package--quickstart-maybe-refresh)
> !           (message "Package `%s' installed." name))
>         (message "`%s' is already installed" name))))
>
>   (defun package-strip-rcs-id (str)





  reply	other threads:[~2020-01-17 18:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-07 23:41 bug#21857: package install should give better feedback David Reitter
2015-11-09  0:06 ` Artur Malabarba
2020-01-17 17:53 ` bug#21857: PATCH to show message after `package-install` installs successfully Ryan Olson
2020-01-17 18:04   ` Ryan Olson [this message]
2020-02-20 17:52 ` bug#21857: Feedback / Merge on patch Ryan Olson
2020-02-23 14:39   ` bug#21857: PATCH to show message after `package-install` installs successfully Noam Postavsky
2020-02-23 15:19     ` Ryan Olson
2020-02-26  0:47       ` Noam Postavsky
2020-08-09 12:09 ` bug#21857: package install should give better feedback Lars Ingebrigtsen
2020-08-09 14:29   ` David Reitter
2020-08-10 10:49     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKkY5K5FbhfUdj7tygVM1dY=MgokhU=hh0L1H5Q46mwZbT56BA@mail.gmail.com' \
    --to=ryan.olson.x@gmail.com \
    --cc=21857@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).